?
Solved

Checking abort condition in VBA UDF

Posted on 2011-02-10
15
Medium Priority
?
316 Views
Last Modified: 2012-06-27
I am using this statement in a UDF which works fine if the value of st is found in the range A:A.

sabbr = Sheet2.Range("A:A").Find(st, , , xlWhole).Offset(0, 1)

But if the data is not found the code execution is aborted. Can someone show me how to check the presence of st in the range before executing the above statement so that the execution is not aborted.
0
Comment
Question by:Saqib Husain, Syed
  • 8
  • 5
  • 2
15 Comments
 
LVL 50

Expert Comment

by:Dave Brett
ID: 34868352
Use a range object then test for nothing

ie

Dave
Sub d()
    Dim sabbr As Range
    Set sabbr = Sheet2.Range("A:A").Find(st, , , xlWhole).Offset(0, 1)
    If sabbr Is Nothing Then
        MsgBox sabbr.Value
    Else
        MsgBox "didn''t find it"
    End If
End Sub

Open in new window

0
 
LVL 50

Expert Comment

by:Dave Brett
ID: 34868356
typo :)
Dim sabbr As Range
    Set sabbr = Sheet2.Range("A:A").Find(st, , , xlWhole)
    If Not sabbr Is Nothing Then
        MsgBox sabbr.Offset(0, 1).Value
    Else
        MsgBox "didn''t find it"
    End If

Open in new window

0
 
LVL 43

Author Comment

by:Saqib Husain, Syed
ID: 34868483
Dave, the assignment is in a udf and not a sub. As soon as the statement is executed the function is aborted. The next statement is not executed.

Saqib
0
What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.

 
LVL 50

Expert Comment

by:Dave Brett
ID: 34868502
Saqib

If I run my sample like this then the UDF either gives me the Offset value or a "no find" message

It won't abort

Cheers

Dave
Function Test() As String
    Dim sabbr As Range
    Dim st
    st = "test"
    Set sabbr = Sheets(2).Range("A:A").Find(st, , , xlWhole)
    If Not sabbr Is Nothing Then
        Test = sabbr.Offset(0, 1).Value
    Else
        Test = "didn''t find it"
    End If
End Function


Sub TestMe()
MsgBox Test
End Sub

Open in new window

0
 
LVL 43

Author Comment

by:Saqib Husain, Syed
ID: 34868560
Dave, please take a look at this file UDF-abort.xls

Cell F21 contains refereence to this UDF

Saqib
0
 
LVL 50

Expert Comment

by:Dave Brett
ID: 34868769
Saaib,

What do you want to happen once
HR: MARULA DITCH MR & METER FLUME,OUTLET
is not found?

Cheers

Dave
0
 
LVL 85

Expert Comment

by:Rory Archibald
ID: 34868858
FWIW, you'd be better off passing all ranges as arguments to the function. They should not really be hardcoded in the UDF itself.
0
 
LVL 43

Author Comment

by:Saqib Husain, Syed
ID: 34868881
Dave,
If it does not find it in the range I want it to continue with the routine as though the statement was not there.
In fact if the match is found I would like it to exit the routine after assigning the value of sabbr to the function.

Rory,
Yes rory, I agree but for my present assignment there is hardly going to be changes to the ranges.

Saqib
0
 
LVL 50

Accepted Solution

by:
Dave Brett earned 2000 total points
ID: 34868902
Saqib,

You could use these two lines then.

I would also advise not using the Sheet2.Range logic, rather work with the sheet names or sheet index

Cheers

Dave

Set sabbr1 = Sheet2.Range("A:A").Find(st, , , xlWhole)
If sabbr1 Is Nothing Then sabbr = sabbr1.Offset(0, 1)

Open in new window

0
 
LVL 50

Expert Comment

by:Dave Brett
ID: 34868915
wow, typo 2
Set sabbr1 = Sheet2.Range("A:A").Find(st, , , xlWhole)
If Not sabbr1 Is Nothing Then sabbr = sabbr1.Offset(0, 1)

Open in new window

0
 
LVL 85

Expert Comment

by:Rory Archibald
ID: 34868921
Saqib,
Doesn't really seem like much of a reason to me, especially as assignments have a tendency to mutate. ;)
Rory
0
 
LVL 43

Author Comment

by:Saqib Husain, Syed
ID: 34869146
Dave,
got the point, thanks.

Rory,
I wonder if you misunderstood me. By assignment I meant "the task I am working at" and not "the assignment statement in the question"

Saqib
0
 
LVL 50

Expert Comment

by:Dave Brett
ID: 34869636
Cheers Saqib
0
 
LVL 50

Expert Comment

by:Dave Brett
ID: 34869662
>By assignment I meant "the task I am working at

That's what Rory meant. Inevitable scope creep :)
0
 
LVL 43

Author Comment

by:Saqib Husain, Syed
ID: 34869972
Well in that case I would just keep it as it is. There is a lot of work to be done to streamline it. I have been working since a year on it and would need it only for a few months more.

After that... who cares...

;-)
0

Featured Post

[Webinar] Cloud and Mobile-First Strategy

Maybe you’ve fully adopted the cloud since the beginning. Or maybe you started with on-prem resources but are pursuing a “cloud and mobile first” strategy. Getting to that end state has its challenges. Discover how to build out a 100% cloud and mobile IT strategy in this webinar.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

This article describes a serious pitfall that can happen when deleting shapes using VBA.
This article describes how you can use Custom Document Properties to store settings and other information in your workbook so that they will be available the next time you open the workbook.
Graphs within dashboards are meant to be dynamic, representing data from a period of time that will change each time the dashboard is updated with new data. Rather than update each graph to point to a different set within a static set of data, t…
This Micro Tutorial will demonstrate how to use a scrolling table in Microsoft Excel using the INDEX function.

864 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question