Improve company productivity with a Business Account.Sign Up

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 352
  • Last Modified:

MICROSOFT ACCESS 2007 - importing excel files into a table.

I have the following code to import excel files into access table.  But it only inserts the first row of each file.  I need it to insert all the rows of each column.


Public Function MYPREMLOAD()

Dim strPath As String
Dim appExcel As Excel.Application
Dim strFolderPath As String
Dim MyDB As DAO.Database
Dim MyRS As DAO.Recordset
Dim strSQL As String
  
DoCmd.SetWarnings False
  strSQL = "Delete * From tblCustomer;"
  DoCmd.RunSQL strSQL
DoCmd.SetWarnings True
  
Set MyDB = CurrentDb()

Set MyRS = MyDB.OpenRecordset("tblCustomer", dbOpenDynaset)
  
'strFolderPath = "C:\Customers\"
'strPath = "C:\Customers\*.xls"     'Set the path.
  
strFolderPath = "X:\Special Risk\miketesting\POI\"
strPath = "X:\Special Risk\miketesting\POI\*.xls"
  
strPath = Dir(strPath, vbNormal)   'Retrieve the first entry.
Set appExcel = CreateObject("Excel.Application")
  
Do While strPath <> ""    'Initiate the loop
  appExcel.Workbooks.Open strFolderPath & strPath
  appExcel.Visible = True
  appExcel.Sheets("SR").Select
    With MyRS
      .AddNew
        !Policy = appExcel.Range("D2").Value
        !Effective = appExcel.Range("F2").Value
        !Yr = appExcel.Range("G2").Value
        !Premium = appExcel.Range("J2").Value
      .Update
    End With
  strPath = Dir           'Next entry
Loop
  
appExcel.Quit
Set appExcel = Nothing
  
MyRS.Close
Set MyRS = Nothing
  
MsgBox "This Process has completed!"
  

End Function

Open in new window

0
centralmike
Asked:
centralmike
  • 4
  • 2
1 Solution
 
SiddharthRoutCommented:
Try this

Const xlUp = -4162

Public Function MYPREMLOAD()
    Dim strPath As String, strFolderPath As String, strFolderPath As String
    Dim appExcel As Excel.Application
    Dim MyDB As DAO.Database, MyRS As DAO.Recordset
    Dim LastRow As Long
    
    DoCmd.SetWarnings False
    strSQL = "Delete * From tblCustomer;"
    DoCmd.RunSQL strSQL
    DoCmd.SetWarnings True
 
    Set MyDB = CurrentDb()
    
    Set MyRS = MyDB.OpenRecordset("tblCustomer", dbOpenDynaset)
     
    strFolderPath = "X:\Special Risk\miketesting\POI\"
    strPath = "X:\Special Risk\miketesting\POI\*.xls"
     
    strPath = Dir(strPath, vbNormal)
    Set appExcel = CreateObject("Excel.Application")
     
    Do While strPath <> ""
        appExcel.Workbooks.Open strFolderPath & strPath
        appExcel.Visible = True
        With MyRS
            LastRow = Sheets("SR").UsedRange.SpecialCells(xlCellTypeLastCell).Row
            
            For i = 2 To LastRow
                .AddNew
                !Policy = appExcel.Range("D" & i).Value
                !Effective = appExcel.Range("F" & i).Value
                !Yr = appExcel.Range("G" & i).Value
                !Premium = appExcel.Range("J" & i).Value
                .Update
            Next
            
        End With
        strPath = Dir
    Loop
     
    appExcel.Quit
    Set appExcel = Nothing
     
    MyRS.Close
    Set MyRS = Nothing
     
    MsgBox "This Process has completed!"
End Function

Open in new window


Sid
0
 
SiddharthRoutCommented:
Replace line 1

Const xlUp = -4162

by

Const xlCellTypeLastCell = 11

Sid
0
 
centralmikeAuthor Commented:
Thanks the code works great.  Just one addition question.  What if I want to start reading the files at line 3 of all the worksheets.  Is there away do accomplish that?

Thanks

Mike
0
NEW Internet Security Report Now Available!

WatchGuard’s Threat Lab is a group of dedicated threat researchers committed to helping you stay ahead of the bad guys by providing in-depth analysis of the top security threats to your network.  Check out this quarters report on the threats that shook the industry in Q4 2017.

 
SiddharthRoutCommented:
Change

For i = 2 To LastRow

to

For i = 3 To LastRow

Sid
0
 
centralmikeAuthor Commented:
Can column names be used instead of column letters?  What if the policy is column "M" instead of column "D".  Can you reference the name of column in stead of the letter?

Thanks again Mike
0
 
SiddharthRoutCommented:
Yes

Col A - 1
Col B - 2

and so on...

So if you want to refer to Range("A1") then you can also say Cells(1,1) or if you want to refer to range("A2") the you can also refer to it as cells(2,1) where the syntax is

Cells(Row,Column)

Sid
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Get your problem seen by more experts

Be seen. Boost your question’s priority for more expert views and faster solutions

  • 4
  • 2
Tackle projects and never again get stuck behind a technical roadblock.
Join Now