• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 1854
  • Last Modified:

global variables multi-threading application

Hello experts.

I have a multi-threading Delphi application that uses some global variables but only for read-only purposes. The initial value of those global variables is set when the application starts and only the main thread is active. I have not had problems with my application so far but want to know if it is safe to read the value of global variables in a multi-threaded application and the reason why it is safe or not to access the global variables for reading their value.

Regards.
0
arturosm
Asked:
arturosm
4 Solutions
 
Geert GruwezOracle dbaCommented:
it would be better if you pass the value of the variables to the thread
this way you can keep the global variables and the thread is not affected by any changes

you could build in a system to restart the thread

using global variables accessed by threads is not such a good idea

you could protect access to them with critical sections
0
 
Ephraim WangoyaCommented:

So long as they are strictly readonly, then it would be safe to access them.
However for safety and less headache, you should still protect them
0
 
arturosmAuthor Commented:
Thank you Geert_Gruwez.

I don´t know if this is another question, just that I don´t know much about critical sections, can you tell me more please, I'm asking for concepts more than for code.

Regards.

0
Never miss a deadline with monday.com

The revolutionary project management tool is here!   Plan visually with a single glance and make sure your projects get done.

 
arturosmAuthor Commented:
Thank you ewangoya.

Yes, they are strictly read only, basically they contain the value of paths to folders that the application uses for reading and writing files.

Regards.
0
 
Geert GruwezOracle dbaCommented:
unit x;

var globalvar: string;

function valueofglobalvar: string;

implementation

uses SyncObjs;

var cs: TCriticalSection;

procedure initCs;
begin
  cs := TCriticalSection.Create;
end;

procedure EndCs;
begin
  cs.Free;
end;

function valueofglobalvar: string;
begin
  cs.Enter;
  try
    Result := globalvar;
  finally
    cs.Leave;
  end;
end;

initialization
  InitCs;
finalization
  EndCs;
end.




0
 
HypoCommented:
I'd say that it's "safe", but it's considered to be "bad practice" to have unprotected variables that are accessed from multiple threads, even if you only read from them... It would probably work fine in your application since you say that these variables are only written to before any threads start... and then they are only read...

There is a synchronization object in Delphi that's called TMultiReadExclusiveWriteSynchronizer, and the purpose of this object is to allow for multiple threads to access/read the same variables simultaniously, whilst it still gives the possibility to protect the resource when you need to write to it...

This syncrhonization object is also normally used when you have a resource that you know will be often read by mutliple threads, but only written to in rare occacions; and the synchronization object helps speeding up the application since reads then don't have to wait for other reads...

Since the TMultiReadExclusiveWriteSynchronizer allows multiple threads to access the same resource at the same time as long as no one has locked it for writing, I'd say that your application design would be "safe" as well... and If you want to be extra safe, you implement a locking mechanism using the TMultiReadExclusiveWriteSynchronizer.

/Hypo
0
 
arturosmAuthor Commented:
Thank you experts, your comments helped me to understand better this subject.

Regards.
0

Featured Post

Never miss a deadline with monday.com

The revolutionary project management tool is here!   Plan visually with a single glance and make sure your projects get done.

Tackle projects and never again get stuck behind a technical roadblock.
Join Now