Solved

Dynamic WHERE clause in Stored Procedure

Posted on 2011-02-17
12
312 Views
Last Modified: 2012-06-27
I have a stored procedure usp_X.

I am executing another stored procedure usp_Y inside usp_X with an output string(sWHERE) as below

(Desc1 = ’08-100’ AND Year=’2008’ AND ‘Desc2’ = ‘PERM-1’) OR
(Desc1 = ’09-110’ AND Year=’2009’ AND ‘Desc2’ = ‘PERM-2’) OR
(Desc1 = ’10-289’ AND Year=’2010’ AND ‘Desc2’ = ‘PERM-3’)

I want use the above ouput string in the WHERE clause as

SELECT
                col1,
                col2
FROM
                table1 A join table2 B ON A.Id = B.Id
WHERE
               --- use the above output here--- (like sWHERE)

How can i accomplish? would someone help me out !

Thanks.





0
Comment
Question by:cimscims
  • 4
  • 3
  • 2
  • +3
12 Comments
 
LVL 75

Expert Comment

by:Aneesh Retnakaran
ID: 34917448
EXEC( 'SELECT
                col1,
                col2
FROM
                table1 A join table2 B ON A.Id = B.Id
WHERE 1=1 '+ sWhere )
0
 
LVL 142

Expert Comment

by:Guy Hengel [angelIII / a3]
ID: 34917496
you could do that only by making your query in usp_X also dynamic.


declare @sql varchar(max)
declare @where varchar(max)

exec usp_Y @where output

set @sql = 'SELECT
                col1,
                col2
FROM
                table1 A join table2 B ON A.Id = B.Id
WHERE ' + @where

exec(@sql)

Open in new window

0
 
LVL 10

Expert Comment

by:John Claes
ID: 34917499
EXEC( 'SELECT
                col1,
                col2
FROM
                table1 A join table2 B ON A.Id = B.Id
WHERE 1=1 AND ( ' + sWhere + ')' )
0
 
LVL 51

Expert Comment

by:HainKurt
ID: 34917612
WHERE 1=1 AND ( ' + sWhere + ')' )

"1=1" is required in case sWhere is null
but when it is null 34917499 will fail
also 34917496 will fail
34917448 will also fail :)

so, we need to check for null/empty:

declare @sql varchar(max) = 'SELECT col1, col2 FROM table1 A join table2 B ON A.Id = B.Id';
if sWhere<>'' set @sql=@sql + ' WHERE ' + sWhere;
EXEDC (@sql)
0
 
LVL 51

Expert Comment

by:HainKurt
ID: 34917626
typo above, should read as:

declare @sql varchar(max) = 'SELECT col1, col2 FROM table1 A join table2 B ON A.Id = B.Id';
if sWhere<>'' set @sql=@sql + ' WHERE ' + sWhere;
EXEC (@sql)
0
 

Author Comment

by:cimscims
ID: 34917676
I am getting a synrtax error in the SELECT near the column
 CONVERT(varchar,date,101) as date.
0
PRTG Network Monitor: Intuitive Network Monitoring

Network Monitoring is essential to ensure that computer systems and network devices are running. Use PRTG to monitor LANs, servers, websites, applications and devices, bandwidth, virtual environments, remote systems, IoT, and many more. PRTG is easy to set up & use.

 
LVL 40

Expert Comment

by:Sharath
ID: 34917748
You should enclose the date in quotes. Post your query.
0
 

Author Comment

by:cimscims
ID: 34917809

EXEC( 'SELECT
                Id,
                desc1,
                CONVERT(varchar,startdate,101) as 'start date',
                CONVERT(varchar,enddate,101) as 'start date'
FROM
                table1 A join table2 B ON A.Id = B.Id
WHERE 1=1 '+ sWhere )


0
 
LVL 51

Expert Comment

by:HainKurt
ID: 34917813
i dont see anything like "CONVERT(varchar,date,101) as date" above!
0
 
LVL 40

Accepted Solution

by:
Sharath earned 250 total points
ID: 34917905
I think the 2nd date is end date. check this.
EXEC( 'SELECT 
                Id,
                desc1,
                CONVERT(varchar,startdate,101) as [start date],
                CONVERT(varchar,enddate,101) as [end date]
FROM
                table1 A join table2 B ON A.Id = B.Id
WHERE 1=1 '+ @sWhere )

Open in new window

0
 
LVL 51

Assisted Solution

by:HainKurt
HainKurt earned 250 total points
ID: 34917983
@sWhere does not have and in front so, this should work...
EXEC( 'SELECT 
                Id,
                desc1,
                CONVERT(varchar,startdate,101) as [start date],
                CONVERT(varchar,enddate,101) as [end date]
FROM
                table1 A join table2 B ON A.Id = B.Id
WHERE '+ @sWhere )

Open in new window

0
 

Author Closing Comment

by:cimscims
ID: 34918026
Thanks. It worked.
0

Featured Post

PRTG Network Monitor: Intuitive Network Monitoring

Network Monitoring is essential to ensure that computer systems and network devices are running. Use PRTG to monitor LANs, servers, websites, applications and devices, bandwidth, virtual environments, remote systems, IoT, and many more. PRTG is easy to set up & use.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Slowly Changing Dimension Transformation component in data task flow is very useful for us to manage and control how data changes in SSIS.
I have a large data set and a SSIS package. How can I load this file in multi threading?
Via a live example, show how to extract information from SQL Server on Database, Connection and Server properties
Via a live example, show how to set up a backup for SQL Server using a Maintenance Plan and how to schedule the job into SQL Server Agent.

932 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

21 Experts available now in Live!

Get 1:1 Help Now