Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people, just like you, are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
Solved

Group By and Function

Posted on 2011-02-17
5
214 Views
Last Modified: 2012-05-11
This is SQL 2000....

 I have the SQl below. I replaced that SUM statement with a function. This gets a summary. Since I added the function call, I need
to add "group by" at the end of the SQL. But that will cause it to give lots of of rows..because of that PO_Date. How can I change this OR change
 the function to get me the same rows/results as that original SUM?
---***** Function ************----
ALTER FUNCTION [dbo].[fnCalculateCutOffSum]
(@orderDate datetime, @warehouse varchar(2),@ShipMethodAbbrev varchar(10))
RETURNS int
AS
BEGIN
-- *** Used in WHT_OrderSummary
declare @Today int
  -- minus 45 mins..deduct that from @orderDate 
  select @Today = sum(case 
                    when datepart(hour,DateAdd(minute,-45, @orderDate)) <= Datepart(Hour,cutoffHour) 
                        Then 1 else 0
                    end)  --compare hour portion of dates
   from nbCutOff
     where --Priority = @priority 
        warehouse = @warehouse
        and ShipMethodAbbrev = @ShipMethodAbbrev  

return @Today
end

------------ SQL ------------------
ALTER PROCEDURE [dbo].[OrderSummaryTest]
AS 
BEGIN
	SELECT CASE o.Customer_ID
            WHEN 100 THEN 'X'
            WHEN 200 THEN 'Y'
            WHEN 400 THEN 'W'
            WHEN 500 THEN 'P'
            ELSE 'B'
       END AS Company,
       sum(...) AS UPS,
       sum(...) AS AIR,
       sum(..) AS USPS,
       sum(..) AS MAN,
     
    
       dbo.fnCalculateCutOffSum (o.PO_Date,'FN','UPSA') as Today,--added this but then i need to add "group by" for o.PO_Date
       /*sum(CASE 
                WHEN o.PO_Date < dateadd(hour,19,CONVERT(varchar,getdate(),101)) AND c.Abbrev_Name = 'UPSA' THEN 1
                WHEN o.PO_Date < dateadd(hour,14,CONVERT(varchar,getdate(),101)) AND c.Abbrev_Name = 'USPS' THEN 1
                WHEN o.PO_Date < dateadd(hour,15,convert(varchar,getdate(),101)) THEN 1
       ELSE 0
           END) AS Today,*/
      
       count(*) AS Total,
      
FROM   Orders o
.......
 
GROUP BY
       CASE o.Customer_ID
            WHEN 100 THEN 'X'
            WHEN 200 THEN 'Y'
            WHEN 400 THEN 'W'
            WHEN 500 THEN 'P'
            ELSE 'B'
       END 
       
ORDER BY
       1 desc

END

Open in new window

0
Comment
Question by:Camillia
  • 3
  • 2
5 Comments
 
LVL 51

Expert Comment

by:HainKurt
ID: 34919952
looks like this is correct

       /*sum(CASE
                WHEN o.PO_Date < dateadd(hour,19,CONVERT(varchar,getdate(),101)) AND c.Abbrev_Name = 'UPSA' THEN 1
                WHEN o.PO_Date < dateadd(hour,14,CONVERT(varchar,getdate(),101)) AND c.Abbrev_Name = 'USPS' THEN 1
                WHEN o.PO_Date < dateadd(hour,15,convert(varchar,getdate(),101)) THEN 1
       ELSE 0
           END) AS Today,*/

you cannot use the function here, that function will be called once, but above statement will run for each row in the group... whats the problem with the code above?
0
 
LVL 51

Accepted Solution

by:
HainKurt earned 500 total points
ID: 34919965
maybe you can use

sum(dbo.fnCalculateCutOffSum (o.PO_Date,'FN','UPSA')) as Today

0
 
LVL 7

Author Comment

by:Camillia
ID: 34920069
>>but above statement will run for each row in the group...
I want to run function to run for each row...basically, it should be the same results..

Let me try your second suggestion...the thing is...the function is already summing up...so maybe remove the sum from the function?
0
 
LVL 51

Expert Comment

by:HainKurt
ID: 34920114
the function will be called for each row in the group... so, yes, you should return something for each row, not for whole group...
0
 
LVL 7

Author Comment

by:Camillia
ID: 34952820
I will close it but dont quite get it. Will open another one if i dont figure it out.
0

Featured Post

Best Practices: Disaster Recovery Testing

Besides backup, any IT division should have a disaster recovery plan. You will find a few tips below relating to the development of such a plan and to what issues one should pay special attention in the course of backup planning.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

International Data Corporation (IDC) prognosticates that before the current the year gets over disbursing on IT framework products to be sent in cloud environs will be $37.1B.
I have a large data set and a SSIS package. How can I load this file in multi threading?
Via a live example combined with referencing Books Online, show some of the information that can be extracted from the Catalog Views in SQL Server.
Via a live example, show how to set up a backup for SQL Server using a Maintenance Plan and how to schedule the job into SQL Server Agent.

808 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question