Solved

Having problems with CFIF Input using listcontains

Posted on 2011-02-18
10
460 Views
Last Modified: 2012-08-13
I have a form which grabs the MASTER data dynamically from this query and displays it as check boxes on a form:
<cfquery name="getSCMaster" datasource="csf">
SELECT     checklistID, category, criteria, scholarshipName
FROM         dbo.tblScholarshipChecklist
WHERE            checklistID <> 1
</cfquery>

I then have a query which grabs data from another table.  The "shared" field is checklistID:
<cfquery name="getSCApp" datasource="csf">
SELECT     applicantChecklistID, applicationID, checklistID
FROM         dbo.tblApplicantChecklist
WHERE     (applicationID = <cfqueryparam cfsqltype="CF_SQL_INTEGER" value="#getAppInfo.applicationID#">) AND checklistID <> 1
</cfquery>

These two tables can't be joined because I need the page to display ALL of the data from the MASTER table, and check the checklistID check box ONLY where the data from the 2nd query is valid.  

I have created a list from the 2nd query and it outputs the data correctly.  
<cfset checklistIDlist = ValueList(getSCApp.checklistID)>
<cfloop list="#checklistIDlist#" index="i">
   <cfoutput>#i# </cfoutput>
</cfloop>
For example, it would output 10 12 15.

This is where the problem starts.  The form is displaying ALL of the numbers in the list returned.  For example, if the list returns 10 12 15, it checks the following checkboxes:
2 5 10 12 15. It's not separating the list correctly and looks for any number within the list and checks that check box.  

This is the input field in my form:
<input name="checklistID" <cfif listContains("#checklistIDlist#", #getSCMaster.checklistID#)>checked="checked"</cfif> type="checkbox" id="checklistID" value="#checklistID#" />

Do I need to add a delimiter to the list somehow or do I need to loop through the list?  Help!  This is driving me crazy!!!  

Thank you!
0
Comment
Question by:ssailer
  • 7
  • 2
10 Comments
 
LVL 39

Accepted Solution

by:
gdemaria earned 500 total points
ID: 34927560
I believe you can join the tables with the LEFT JOIN.

In the code below, the field I added isChecked should be 1 when you need to check the box and 0 when the box would be unchecked.

Give it a test..

<cfquery name="getSCMaster" datasource="csf">
SELECT   sch.checklistID
       , sch.category
       , sch.criteria
       , sch.scholarshipName
       , case when app.applicationID > 0 then 1 else 0 end as IsChecked
FROM     dbo.tblScholarshipChecklist sch
  left join tblApplicantChecklist app on app.checklistID = sch.checklistID
       and app.applicationID = <cfqueryparam cfsqltype="CF_SQL_INTEGER" value="#getAppInfo.applicationID#">) 
       and app.checklistID <> 1
WHERE  sch.checklistID <> 1
</cfquery>

Open in new window

0
 
LVL 39

Expert Comment

by:gdemaria
ID: 34927632
To address your question more directly, you are saying that the following code woud show you the correct values but the checkboxes are ALL checked.


Please try the modifications - you don't need to loop through a list to show the list.   I've cleaned up the INPUT tag to reduce unneeded code..

<cfquery name="getSCApp" datasource="csf">
  SELECT     applicantChecklistID, applicationID, checklistID
  FROM         dbo.tblApplicantChecklist
  WHERE     (applicationID = <cfqueryparam cfsqltype="CF_SQL_INTEGER" value="#getAppInfo.applicationID#">) AND checklistID <> 1
</cfquery>
<cfset checklistIDlist = ValueList(getSCApp.checklistID)>

Only these should be checked: #checklistIDlist#<br>

<cfloop query="getSCMaster">
<input type="checkbox" name="checklistID" <cfif listContains(checklistIDlist, getSCMaster.checklistID)>checked="checked"</cfif> value="#getSCMaster.checklistID#" />
</cfloop>

Open in new window

0
 

Author Comment

by:ssailer
ID: 34927633
YOU ARE A GENIUS!!!  Absolutely PERFECT :)  
0
 
LVL 39

Expert Comment

by:gdemaria
ID: 34927688
I didn't notice it before, also please change listContains() to ListFind()
<cfloop query="getSCMaster">
<input type="checkbox" name="checklistID" <cfif listFind(checklistIDlist, getSCMaster.checklistID)>checked="checked"</cfif> value="#getSCMaster.checklistID#" />
</cfloop>

Open in new window

0
 
LVL 39

Expert Comment

by:gdemaria
ID: 34927706
I think you clicked the wrong button, you are attempting to accept your own answer.   Please try again and accept the answer that you're going to use :)

Don't forget listFind() is the right function, listContains does something different
0
Find Ransomware Secrets With All-Source Analysis

Ransomware has become a major concern for organizations; its prevalence has grown due to past successes achieved by threat actors. While each ransomware variant is different, we’ve seen some common tactics and trends used among the authors of the malware.

 
LVL 52

Expert Comment

by:_agx_
ID: 34928832
@ssailer - did you mean to accept gdemaria's answer?

<cfif listContains(checklistIDlist, getSCMaster.checklistID)>

But I wanted to mention, that's the wrong function for matching whole ID's.  ListContains matches substrings.  So "2" will match "12", "214", "512" - not just the whole value "2".  For an exact match, use ListFind/FindNoCase instead.

0
 
LVL 39

Expert Comment

by:gdemaria
ID: 34928880

agx, I suspect you stopped reading all the posts, which if fine - I do the same thing, but I did mention that in the last two.. :)
0
 
LVL 39

Expert Comment

by:gdemaria
ID: 34928883

Author intended to accept my answer, I believe and checked his own by mistake
0
 
LVL 52

Expert Comment

by:_agx_
ID: 34928909
Yeah, I missed it.  But now they have an explanation of why use one not the other ;-)
0
 
LVL 39

Expert Comment

by:gdemaria
ID: 34928927
> But now they have an explanation of why use one not the other

Yes!  perfect..
0

Featured Post

How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

Join & Write a Comment

Suggested Solutions

Today, I was working on some optimization and spam-stopping techniques when I encountered Ben Nadel's post to reduce spam feature using Math (http://www.bennadel.com/blog/197-How-I-Stop-Spammers-On-My-ColdFusion-Blog.htm). While this method is not o…
This is an updated version of a post made on my blog over 3 years ago. It is unfortunately, still very relevant as we continue to see both SQLi (SQL injection) and XSS (cross site scripting) attacks hitting some of the most recognizable website and …
In this seventh video of the Xpdf series, we discuss and demonstrate the PDFfonts utility, which lists all the fonts used in a PDF file. It does this via a command line interface, making it suitable for use in programs, scripts, batch files — any pl…
Polish reports in Access so they look terrific. Take yourself to another level. Equations, Back Color, Alternate Back Color. Write easy VBA Code. Tighten space to use less pages. Launch report from a menu, considering criteria only when it is filled…

762 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

19 Experts available now in Live!

Get 1:1 Help Now