Solved

RegEx search for repeating hyphens

Posted on 2011-02-20
4
657 Views
Last Modified: 2012-05-11
I am trying to replace multiple hyphens with a single one. Here is my php code to achive this

<?php
  $string = "a--b---c-d-e";
  $newstring = preg_replace("/(-)(\1+)/", "-", $string);
?>

Open in new window


I want the $newsting to be "a-b-c-d-e"

However, it does not do anything to the original string. Why is it not working?
0
Comment
Question by:hvs69
4 Comments
 
LVL 27

Accepted Solution

by:
Lukasz Chmielewski earned 125 total points
ID: 34936129
Try
<?php
  $string = "a--b---c-d-e";
  $newstring = preg_replace("/[-]+/", "-", $string);
  echo"$newstring";
?>
0
 
LVL 4

Expert Comment

by:LAMASE
ID: 34936273
i agree with @Roads. If you want something more general you can use

<?php
  $string = "a--b--  ## -c-d-..e(@)-g";
  $newstring = preg_replace("/[^a-z]+/", "-", $string);
  echo $newstring;
?>

this will eliminate everything between lowercase letters and puts a single hypen between..

This and @Roads solutions doesn't remove the trailing hypens: if you have

$string = '-a-b-';

it will keep as is. Do you need this too? You can do it in two easy steps (or in one with a more complex regexp)

<?php
  $string = "a--b---c-d-e";
  $newstring = preg_replace("/[^a-z]+/", " ", $string);
  $newstring = preg_replace("/ +/", "-", trim($string));
  echo"$newstring";
?>

0
 
LVL 1

Expert Comment

by:jfk013097
ID: 34936869
ereg_replace("--*", "-", $string)

will replace all multiple instances of - with a single one
0
 
LVL 108

Expert Comment

by:Ray Paseur
ID: 34937757
ereg functions are deprecated.

Regarding this, "it does not do anything to the original string." - that is correct, because the new value is assigned to the variable named $newstring.

http://www.laprbass.com/RAY_temp_hvs69.php

Outputs: a-b-c-d-e
<?php // RAY_temp_hvs69.php
error_reporting(E_ALL);

// TEST DATA FROM THE POST AT EE
$string = "a--b---c-d-e";

// CONSTRUCT A REGEX
$regex 
= '/'  // REGEX DELIMITER
. '-+' // MORE THAN ONE HYPHEN
. '/'  // REGEX DELIMITER
;

// REPLACE THE HYPHENS WITH ONE HYPHEN
$newstring = preg_replace($regex, '-', $string);
echo $newstring;

Open in new window

0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Deprecated and Headed for the Dustbin By now, you have probably heard that some PHP features, while convenient, can also cause PHP security problems.  This article discusses one of those, called register_globals.  It is a thing you do not want.  …
I imagine that there are some, like me, who require a way of getting currency exchange rates for implementation in web project from time to time, so I thought I would share a solution that I have developed for this purpose. It turns out that Yaho…
The viewer will learn how to dynamically set the form action using jQuery.
This tutorial will teach you the core code needed to finalize the addition of a watermark to your image. The viewer will use a small PHP class to learn and create a watermark.

867 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

21 Experts available now in Live!

Get 1:1 Help Now