Solved

Always prefer a greater value using IF Statements

Posted on 2011-02-21
5
800 Views
Last Modified: 2012-08-13
Hello,

I'm after a bit of help with a script I have written, I'm pretty new to PHP and struggling to get my head around it.

I have a website which uses a shipping calculator, featuring the dimensions (width, length, height) and the weight (in kg) of a parcel.
I'm using 2 variables; $volumetric and $weight.
The $volumetric variable is calculated as such, (weight * length * height) / 5000.

Here's what the script is intended to do:-
1. Get values from an HTML form. In this case, 'volumetric' and 'weight'.
2. Compare the values to see which is the largest.
3. Return/redirect to the corresponding URL of the product from the web shop.

At the moment it always takes preference to the volumetric value and does not take the weight into consideration.

An example would be as follows:
Customer enters their dimensions of their box size, 10cm x 10cm x 10cm. This works out to be a volumetric weight value of 0.2KG.
If the customer enters the weight for their parcel as say 5KG, it should return the product for 5KG.

Essentially what I'm trying to do is return/redirect to the URL of a product which has the greater value. I'm currently using IF statements to do this, however, I'm always open to suggestions!

I have attached the code for your reference.

Many Thanks in advance for your reply.

Ben M. fetchProduct.php fetchProduct.php
0
Comment
Question by:Steve-UK
  • 2
  • 2
5 Comments
 
LVL 14

Assisted Solution

by:Scott Madeira
Scott Madeira earned 100 total points
ID: 34942662
Try this...  I think it does the same thing you want but with less code and will handle weights up to any value.  You could put an upper limit on it if you needed to.
 
<?php

// ALWAYS SET ERROR REPORTING SO YOU CAN SEE IF ANYTHING IS AMISS
error_reporting(E_ALL);

if (isset($_POST["width"]) && isset($_POST["length"]) && isset($_POST["height"]))
{
	// GET THE VARIABLES FROM THE QUOTE FORM
	$volumetric = ($_POST["width"] * $_POST["length"] * $_POST["height"]) / 5000;
	$dimensions = ($_POST["width"] * $_POST["length"] * $_POST["height"]);
	$weight = ($_POST["weight"]);
	
	
	// round both values up to next greatest integer
	$weight =  intval(ceil($weight));
	$volumetric = intval(ceil($volumetric));
	
	if ($weight > $volumetric){
		// This will create a string value
		$product = 'UPS-'.$weight.'KG';		
	} else {		
		$product = 'UPS-'.$volumetric.'KG-Volumetric';		
	}
	

		
	// LOAD THE SCRIPT - IT CAN USE THE VALUE IN $volumetric DIRECTLY
	include_once ('http://79.170.44.122/parcelsave.com/products.php');
	
	// RUN THE FUNCTION
	returnProduct($product, $volumetric, $dimensions);
}
?>

<?php 


function returnProduct($product $volumetric, $dimensions) {
	
	// CATCH INVALID PARCEL - Over 70KG OR Over Dimensions
	if ( ($volumetric > 70) || ($dimensions > 370) ) {
		header("Location: http://79.170.44.122/parcelsave.com/pages.php?pageid=24");
	} else {

		$location = 'Location: http://79.170.44.122/parcelsave.com/products.php?product='.$product;
		header($location);	
	}
	
}

?>

Open in new window

0
 
LVL 12

Accepted Solution

by:
Amick earned 400 total points
ID: 34942701
I don't currently have PHP installed, so this is from memory, but may be useful.
The idea is to take the larger number and rather than running through a number of conditional tests simply create the call.

I didn't handle out-of-bounds packages in my example, but you can easily add that back.

<?php

// ALWAYS SET ERROR REPORTING SO YOU CAN SEE IF ANYTHING IS AMISS
error_reporting(E_ALL);

if (isset($_POST["width"]) && isset($_POST["length"]) && isset($_POST["height"]))
{
	// GET THE VARIABLES FROM THE QUOTE FORM
	$volumetric = ($_POST["width"] * $_POST["length"] * $_POST["height"]) / 5000;
	$dimensions = ($_POST["width"] * $_POST["length"] * $_POST["height"]);
	$weight = ($_POST["weight"]);
	
	if ($weight >= $volumetric) {
		header("Location: http://79.170.44.122/parcelsave.com/products.php?product=UPS-".ceil($weight)."KG");
	else
	($weight >= $volumetric) {
		header("Location: http://79.170.44.122/parcelsave.com/products.php?product=UPS-".ceil($volumetric)."KG-Volumetric");
	}
	
?>

Open in new window

0
 
LVL 12

Expert Comment

by:Amick
ID: 34942727
There is at least one typo in my previous post.  Line 16 should be changed from "($weight >= $volumetric) {" to simply "{" .
0
 

Author Comment

by:Steve-UK
ID: 34942781
Hi guys,

Many thanks for the responses, much appreciated.

I have tried both versions so far and for some reason both are returning the 'Invalid' page no matter what values are entered.

The quote form for testing can be found at http://79.170.44.122/parcelsave.com/pages.php?pageid=19

Looks to me like either method should work, but looks like it's going wrong somewhere.

Thanks again,
Ben
0
 

Author Comment

by:Steve-UK
ID: 34942816
Hi again,

Ignore my last post...managed to get it working!

Just added a couple of braces in the right place.

All that's left is to add an upper limit.

Thank you both very much for all your help.

Regards,
Ben
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Developers of all skill levels should learn to use current best practices when developing websites. However many developers, new and old, fall into the trap of using deprecated features because this is what so many tutorials and books tell them to u…
Since pre-biblical times, humans have sought ways to keep secrets, and share the secrets selectively.  This article explores the ways PHP can be used to hide and encrypt information.
The viewer will learn how to count occurrences of each item in an array.
This tutorial will teach you the core code needed to finalize the addition of a watermark to your image. The viewer will use a small PHP class to learn and create a watermark.

920 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

14 Experts available now in Live!

Get 1:1 Help Now