Solved

Trying to clear column when workbook closes

Posted on 2011-02-21
14
210 Views
Last Modified: 2012-05-11

I have a spreadsheet that I use to check on my credit card balances.  I use a simple "x" in one of the columns to denote that it's been checked.  I'd like to clear this column every time I close the workbook.  I have the attached code in VBA, but it doesn't clear the column when I close the file.

0
Comment
Question by:BBlu
  • 6
  • 5
  • 3
14 Comments
 

Author Comment

by:BBlu
Comment Utility
oops.  Here's the code I'm trying to use.
Sub ClearCheckCol()
'
' ClearCheckCol Macro
'

'
    Columns("G:G").Select
    Selection.ClearContents
End Sub

Private Sub Workbook_BeforeClose(Cancel As Boolean)
    Call ClearCheckCol
End Sub

Open in new window

0
 
LVL 45

Expert Comment

by:patrickab
Comment Utility
BBlu,

>I have the attached code in VBA, but it doesn't clear the column when I close the file.

Please let us see the VBA code - thanks.

Patrick
0
 
LVL 92

Expert Comment

by:Patrick Matthews
Comment Utility
That looks like it ought to work.  Three thoughts:

1) Are you sure macros are enabled?

2) If yes, are you sure that events are enabled?

3) If yes, are you sure that the ClearCheckCol sub is operating against the right worksheet?  Since you are not qualifying the range reference, it is acting against the current active sheet.  You should probably qualify the reference
0
 
LVL 45

Expert Comment

by:patrickab
Comment Utility
BBlu,

>You should probably qualify the reference - as per Patrick Matthews' comment...

Sub ClearCheckCol()
    Sheets("Sheet1").Columns("G:G").ClearContents
'or specify whichever sheet is correct
End Sub

Private Sub Workbook_BeforeClose(Cancel As Boolean)
    Call ClearCheckCol
End Sub

Patrick(ab) - a different Patrick!
0
 

Author Comment

by:BBlu
Comment Utility
I changed the code per Patrick's thoughts.  Still not working.  I have macros enabled.  But I don't know how to enable events.
0
 
LVL 92

Expert Comment

by:Patrick Matthews
Comment Utility
Modify your event sub to read:

Private Sub Workbook_BeforeClose(Cancel As Boolean)
    MsgBox "foo!"
    Call ClearCheckCol
End Sub

Open in new window


If you try to close the workbook, do you get that message?

Also, are you certain that you placed the Workbook_BeforeClose sub in the ThisWorkbook module for the specific workbook you want the code to operate on?  Putting it in a different module, or even a different workbook (such as an add-in or a personal macro workbook) would be a problem :)

I'd also extend the qualification to the workbook:

Sub ClearCheckCol()
    ThisWorkbook.Worksheets("Sheet1").Columns("G:G").ClearContents
'or specify whichever sheet is correct
End Sub

Open in new window

0
 
LVL 45

Accepted Solution

by:
patrickab earned 150 total points
Comment Utility
Perhaps like this:

Sub ClearCheckCol()
    Sheets("Sheet1").Columns("G:G").ClearContents
'or specify whichever sheet is correct
End Sub

Private Sub Workbook_BeforeClose(Cancel As Boolean)
    Application.EnableEvents = True
    Call ClearCheckCol
End Sub
0
What Should I Do With This Threat Intelligence?

Are you wondering if you actually need threat intelligence? The answer is yes. We explain the basics for creating useful threat intelligence.

 
LVL 92

Expert Comment

by:Patrick Matthews
Comment Utility
Patrick,

If events aren't enabled, the BeforeClose event won't fire, and thus events won't get enabled that way :)

Patrick
0
 

Author Comment

by:BBlu
Comment Utility
You are funny, Matthew.  No, I don't get that message.  How do I enable the events?
0
 
LVL 92

Expert Comment

by:Patrick Matthews
Comment Utility
Please state exactly where you placed the Workbook_BeforeClose sub.
0
 

Author Comment

by:BBlu
Comment Utility
I put it in a module for the Workbook.  See attached. Close Event VBA Screenshot
0
 
LVL 92

Assisted Solution

by:Patrick Matthews
Patrick Matthews earned 50 total points
Comment Utility
Code for workbook events belongs in the ThisWorkbook module, not in a "regular" module.
0
 

Author Comment

by:BBlu
Comment Utility
Thanks to you both . The code provided worked...as long as I put it in the right darn location.  LOL
0
 

Author Closing Comment

by:BBlu
Comment Utility
Thanks, again, Guys.
0

Featured Post

Maximize Your Threat Intelligence Reporting

Reporting is one of the most important and least talked about aspects of a world-class threat intelligence program. Here’s how to do it right.

Join & Write a Comment

Suggested Solutions

A little background as to how I came to I design this code: Around 5 years ago I designed an add-in that formatted Excel files to a corporate standard, applying different cell colours and font type depending on whether the cells contained inputs,…
This code takes an Excel list of URL’s and adds a header titled “URL List”. It then searches through all URL’s in column “A”, looking for duplicates. When a duplicate is found, it is moved to the top of the list. The duplicate URL’s are then highlig…
Viewers will learn the basics of slicers and timelines for both PivotTables and standard Excel tables in Excel 2013.
This Micro Tutorial will demonstrate on a Mac how to change the sort order for chart legend values and decrpyt the intimidating chart menu.

772 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

11 Experts available now in Live!

Get 1:1 Help Now