WatchGuard’s Threat Lab is a group of dedicated threat researchers committed to helping you stay ahead of the bad guys by providing in-depth analysis of the top security threats to your network. Check out this quarters report on the threats that shook the industry in Q4 2017.
Solved
Powershell: New-Object add-member for multiple attributes shows no value
Posted on 2011-02-23
Hello Experts,
I have the following Function in powershell to get complete disk information.
The Issue I am facing is when I have only one Hard drive and one partition , the script execute successfully with valid return.
However When a Server is having more than one physical disk or more than one partition it is returning no value for $dskobj properties. Well I understand why it is doing it , because it doesn't know how to present it. However I can't think of any way to present this data.
I have the following Function in powershell to get complete disk information.
function get-diskinfo {
param($servername)
if (($servername -eq "localhost") -or ($servername -eq $hostname)) {
$ldiskobj = Get-WmiObject Win32_logicaldisk -computername $servername |
Where-Object {$_.DriveType -eq "3"} |
Select-Object @{Name="ServerName";Expression={"{0:N1}" -f($_.__SERVER)}},
@{Name="Drive";Expression={"{0:N1}" -f($_.DeviceID)}},
@{Name="Size";Expression={"{0:N1}" -f($_.Size/1gb)}},
@{Name="Freespace";Expression={"{0:N1}" -f($_.FreeSpace/1gb)}}
$phdskobj = Get-WmiObject Win32_DiskDrive -computername $servername |
Select-Object Model,
Bytespersector,
InterfaceType,
Manufacturer,
Status,
TotalHeads,
TotalCylinders
}
else {
$ldiskobj = Get-WmiObject Win32_logicaldisk -computername $servername -Credential $logincred |
Where-Object {$_.DriveType -eq "3"} |
Select-Object @{Name="ServerName";Expression={"{0:N1}" -f($_.__SERVER)}},
@{Name="Drive";Expression={"{0:N1}" -f($_.DeviceID)}},
@{Name="Size";Expression={"{0:N1}" -f($_.Size/1gb)}},
@{Name="Freespace";Expression={"{0:N1}" -f($_.FreeSpace/1gb)}}
$phdskobj = Get-WmiObject Win32_DiskDrive -computername $servername -Credential $logincred |
Select-Object Model,
Bytespersector,
InterfaceType,
Manufacturer,
Status,
TotalHeads,
TotalCylinders
}
$dskobj = New-Object psobject
$dskobj | Add-Member NoteProperty "Model" -Value $phdskobj.Model
$dskobj | Add-Member NoteProperty "Status" -Value $phdskobj.status
$dskobj | Add-Member NoteProperty "Drive" -Value $ldiskobj .Drive
$dskobj | Add-Member NoteProperty "Freespace" -Value $ldiskobj .Freespace
cls
$dskobj |fl
}
The Issue I am facing is when I have only one Hard drive and one partition , the script execute successfully with valid return.
However When a Server is having more than one physical disk or more than one partition it is returning no value for $dskobj properties. Well I understand why it is doing it , because it doesn't know how to present it. However I can't think of any way to present this data.
3-
2
5 Comments
Active today
Because you're returning an array, you'll need to approach it a little bit differently. I haven't put the credential info back in, just adapt this to your needs and see if it works :)
Usage: Get-DiskInfo -target computername
Usage: Get-DiskInfo -target computername
Function Get-DiskInfo
{
param([string]$target)
if (!$target){$target = "."}
$arrDiskInfo = @()
GWMI -ComputerName $target Win32_DiskDrive | % {
$objDiskInfo = New-Object PSObject
$objDiskInfo | Add-Member -Type NoteProperty -Name "Model" -Value $_.Model
$objDiskInfo | Add-Member -Type NoteProperty -Name "Status" -Value $_.Status
GWMI -ComputerName $target -Query "ASSOCIATORS OF {Win32_DiskDrive.DeviceID='$($_.DeviceID)'} WHERE ResultClass=Win32_DiskPartition" | % {
GWMI -ComputerName $target -Query "ASSOCIATORS OF {Win32_DiskPartition.DeviceID='$($_.DeviceID)'} WHERE ResultClass=Win32_LogicalDisk" | % {
$objDiskInfo | Add-Member -Type NoteProperty -Name "Drive" -Value $_.DeviceID
$objDiskInfo | Add-Member -Type NoteProperty -Name "Freespace" -Value $("{0:N1}" -f($_.Freespace/1GB))
}
}
$arrDiskInfo += $objDiskInfo
}
$arrDiskInfo | FL *
}
I have added the credential part and it is working as I wanted. Thanks for your help!!
Now few silly questions to annoy you.
1. What is %{} ? - You piped output of win32_diskdrive into this container is it same as an array @()
Few operation inside the %{} is bit difficult for a newbie like me understand. I understand the Associators of query , however why aren't you doing the same operation for $_.Model as you are doing for $_.deviceid..
Thing is I am writing more functions like this and I can only use wmi queries for data from the servers as none of they will have powershell. So it would be great to know how this is working so that I keep building my shared function scripts
Now few silly questions to annoy you.
1. What is %{} ? - You piped output of win32_diskdrive into this container is it same as an array @()
Few operation inside the %{} is bit difficult for a newbie like me understand. I understand the Associators of query , however why aren't you doing the same operation for $_.Model as you are doing for $_.deviceid..
Thing is I am writing more functions like this and I can only use wmi queries for data from the servers as none of they will have powershell. So it would be great to know how this is working so that I keep building my shared function scripts
Active today
% is a bad habit :) I forgot to replace that with the actual cmdlet when copying it over.
It is a shortcut for the ForEach-Object cmdlet. For example, these will do the same thing.
The reason you don't need to do this to find the model and deviceID, is that there is only 1 reference to each physical device so for each drive in the target host you can assume the model and status will be the same for each partition on that drive.
It is a shortcut for the ForEach-Object cmdlet. For example, these will do the same thing.
Get-Process | Foreach-Object {Blah}
Get-Process | % {Blah}
The reason you don't need to do this to find the model and deviceID, is that there is only 1 reference to each physical device so for each drive in the target host you can assume the model and status will be the same for each partition on that drive.
Active today
Also for some more info on Associators and all that have a look here: http://www.codeproject.com/KB/system/WQLByExample.aspx
Featured Post
Question has a verified solution.
Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.
Have a better answer? Share it in a comment.
Join & Write a Comment Already a member? Login.
In this post, I will showcase the steps for how to create groups in Office 365.
Office 365 groups allow for ease of flexibility and collaboration between staff members.
In migration, Powershell can be a very crucial tool to achieve success and finalize projects within deadline or even fix issues.
X500 or Legacy Exchange DN Attribute can cause lots of issue during the migration
Screencast - Getting to Know the Pipeline
Suggested Courses
Course of the Month6 days, 3 hours left to enroll
569 members asked questions and received personalized solutions in the past 7 days.
Join the community of 500,000 technology professionals and ask your questions.