Solved

vb.net threading question

Posted on 2011-02-23
4
232 Views
Last Modified: 2012-06-27
I'm trying to ensure that I'm using synclock correctly.

I have the following class

public class MyThreadTest
   private MyLockObject as new Object
   private lstOrgs as new List(of Org)
   Private AllergyUpdateThreadPool(MaxAllergyUpdateThreads) As Thread
   Private VendorCount as integer


   Public sub New()
          Dim x As Integer
                For x = 0 To UBound(AllergyUpdateThreadPool) - 1
                    AllergyUpdateThreadPool(x) = New Thread(AddressOf UpdateAllergy)
                    AllergyUpdateThreadPool(x).Name = "DrFirstAllergyUpdateThread #" + CStr(x)
                    ' AllergyUpdateThreadPool(x).Start()
                Next
     end sub


   public sub StartThreads(VendorList as list (of Org))
       dim x as integer
        SyncLock (MySyncLock)
                lstOrgs .Clear()
                LoadVendorList(VendorList)
                VendorCount = -1
          End SyncLock
           For x = 0 To UBound(AllergyUpdateThreadPool) - 1
                        AllergyUpdateThreadPool(x).Start()
            Next
end sub


 Private Sub UpdateAllergy()
          SyncLock (MySyncLock)
                        ' v = OperationQueue.Dequeue()
                        If VendorCount = lVendors.Count - 1 Then
                            VendorCount = 0
                        Else
                            VendorCount += 1
                        End If
                        v = lVendors(VendorCount)
               End SyncLock

                 'Do some work
end sub
           


In Main form
Dim  t as new MyThreadTest
Dim MyVendorList as new List (of Org)

'Load vendor list

t.StartAllergyUpdateProcess(MyVendorList)



Questions
1. Does this look like a safe approach for using the MyLockObject object for multiple threads in this class? Is it declared correctly or does it need to be a shared or protected variable?
2. Any other areas of concern (Note. this is a simplified version of what I'm doing)
0
Comment
Question by:rutledgj
  • 2
  • 2
4 Comments
 
LVL 85

Accepted Solution

by:
Mike Tomlinson earned 500 total points
ID: 34962300
The SyncLock portion will work just fine.  You would need it to be Shared if your List was shared and being used across multiple instances of MyThreadTest.  Since everything is contained within this class it will work as expected.

The counter logic, though, looks off to me.  If you pass in an empty list then both VendorCount and (lVendors.Count - 1) would be -1.  In that case you set VendorCount = 0 and then attempt to access the List at that Index which of course would cause an exception since the List is empty.
0
 

Author Comment

by:rutledgj
ID: 34962454
Thanks, You are right about the empty list. I will add a check for that.

One other question if you don't mind. I aslo will be using a database class to perform database activities within the thread.

Should the database class be instantiated within the UpdateAllergy function (One dbOps object for each thread) or can I declare it once within the whole class and each thread use the same connection?
0
 
LVL 85

Expert Comment

by:Mike Tomlinson
ID: 34962506
I'm not a DB guy but it seems to me that you should have just one instance for the class that all the threads share.  You may need to place calls to the DB within SyncLock blocks to make sure they don't write over each other.
0
 

Author Closing Comment

by:rutledgj
ID: 34962767
Ok. thanks. I think I'll post another question specifically for that.
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

This tutorial demonstrates one way to create an application that runs without any Forms but still has a GUI presence via an Icon in the System Tray. The magic lies in Inheriting from the ApplicationContext Class and passing that to Application.Ru…
Introduction When many people think of the WebBrowser (http://msdn.microsoft.com/en-us/library/2te2y1x6%28v=VS.85%29.aspx) control, they immediately think of a control which allows the viewing and navigation of web pages. While this is true, it's a…
This video explains how to create simple products associated to Magento configurable product and offers fast way of their generation with Store Manager for Magento tool.
A short film showing how OnPage and Connectwise integration works.

937 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

4 Experts available now in Live!

Get 1:1 Help Now