?
Solved

vb.net threading question

Posted on 2011-02-23
4
Medium Priority
?
250 Views
Last Modified: 2012-06-27
I'm trying to ensure that I'm using synclock correctly.

I have the following class

public class MyThreadTest
   private MyLockObject as new Object
   private lstOrgs as new List(of Org)
   Private AllergyUpdateThreadPool(MaxAllergyUpdateThreads) As Thread
   Private VendorCount as integer


   Public sub New()
          Dim x As Integer
                For x = 0 To UBound(AllergyUpdateThreadPool) - 1
                    AllergyUpdateThreadPool(x) = New Thread(AddressOf UpdateAllergy)
                    AllergyUpdateThreadPool(x).Name = "DrFirstAllergyUpdateThread #" + CStr(x)
                    ' AllergyUpdateThreadPool(x).Start()
                Next
     end sub


   public sub StartThreads(VendorList as list (of Org))
       dim x as integer
        SyncLock (MySyncLock)
                lstOrgs .Clear()
                LoadVendorList(VendorList)
                VendorCount = -1
          End SyncLock
           For x = 0 To UBound(AllergyUpdateThreadPool) - 1
                        AllergyUpdateThreadPool(x).Start()
            Next
end sub


 Private Sub UpdateAllergy()
          SyncLock (MySyncLock)
                        ' v = OperationQueue.Dequeue()
                        If VendorCount = lVendors.Count - 1 Then
                            VendorCount = 0
                        Else
                            VendorCount += 1
                        End If
                        v = lVendors(VendorCount)
               End SyncLock

                 'Do some work
end sub
           


In Main form
Dim  t as new MyThreadTest
Dim MyVendorList as new List (of Org)

'Load vendor list

t.StartAllergyUpdateProcess(MyVendorList)



Questions
1. Does this look like a safe approach for using the MyLockObject object for multiple threads in this class? Is it declared correctly or does it need to be a shared or protected variable?
2. Any other areas of concern (Note. this is a simplified version of what I'm doing)
0
Comment
Question by:rutledgj
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 2
  • 2
4 Comments
 
LVL 86

Accepted Solution

by:
Mike Tomlinson earned 2000 total points
ID: 34962300
The SyncLock portion will work just fine.  You would need it to be Shared if your List was shared and being used across multiple instances of MyThreadTest.  Since everything is contained within this class it will work as expected.

The counter logic, though, looks off to me.  If you pass in an empty list then both VendorCount and (lVendors.Count - 1) would be -1.  In that case you set VendorCount = 0 and then attempt to access the List at that Index which of course would cause an exception since the List is empty.
0
 

Author Comment

by:rutledgj
ID: 34962454
Thanks, You are right about the empty list. I will add a check for that.

One other question if you don't mind. I aslo will be using a database class to perform database activities within the thread.

Should the database class be instantiated within the UpdateAllergy function (One dbOps object for each thread) or can I declare it once within the whole class and each thread use the same connection?
0
 
LVL 86

Expert Comment

by:Mike Tomlinson
ID: 34962506
I'm not a DB guy but it seems to me that you should have just one instance for the class that all the threads share.  You may need to place calls to the DB within SyncLock blocks to make sure they don't write over each other.
0
 

Author Closing Comment

by:rutledgj
ID: 34962767
Ok. thanks. I think I'll post another question specifically for that.
0

Featured Post

What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Article by: Kraeven
Introduction Remote Share is a simple remote sharing tool, enabling you to see, add and remove remote or local shares. The application is written in VB.NET targeting the .NET framework 2.0. The source code and the compiled programs have been in…
Introduction As chip makers focus on adding processor cores over increasing clock speed, developers need to utilize the features of modern CPUs.  One of the ways we can do this is by implementing parallel algorithms in our software.   One recent…
In this brief tutorial Pawel from AdRem Software explains how you can quickly find out which services are running on your network, or what are the IP addresses of servers responsible for each service. Software used is freeware NetCrunch Tools (https…
In this video, Percona Solution Engineer Rick Golba discuss how (and why) you implement high availability in a database environment. To discuss how Percona Consulting can help with your design and architecture needs for your database and infrastr…

777 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question