Sub not calling

I have a sub and within it i call various subs

A particular sub is not calling

Call FillFormula

if i step through the sub, it will call, if i run it all at once through a button, it does not call it.

Is there an error in my structure?

Sub RunReport()

    Workbooks.Open Filename:= _
        "G:\Asset Services MI\TLM Stock Breaks\TLM Stock_Break_Data Source.xls"
Call ColumnODate
Call AddDateToCognosFile
Call CopyOverCognosFile
Call TodayANDYesterday
Call DeleteRecords
Call Sorting

    Workbooks("New TLM.xls").Activate
Call Datacall
Call FillFormula
Call AllWorkbookPivots
Call HighlightTotals
Call FutureValues

Sheets("Raw Data").Visible = False

 ActiveWorkbook.UpdateLink Name:= _
        "G:\Asset Services Risk Team\TLM\Asset Services Outstanding Stock Items.xls", _

If Sheets("Screen").Range("L1") = "Q" Then

Call TestInsertPicture


MsgBox "Report Ran, Create File"
End If
End Sub

Open in new window

Who is Participating?
Rory ArchibaldConnect With a Mentor Commented:
No, you just need to make sure that your data retrieval process does not use a background query. If you are using 2003 or earlier, right -click on the resulting data, choose Data Range Properties and uncheck the option to allow background refreshing. Or, if you are not using Refreshall but refreshing a specific table in code, you can specify the Backgroundquery:=false argument in the code.
TracyVBA DeveloperCommented:
Post the FillFormula procedure.

Is it in the same module, is it a function, does it have the word "Private" in front of it?
Seamus2626Author Commented:
Here it is broomee9
Sub FillFormula()

Dim r As Long

Sheets("Raw Data").Visible = True
Sheets("Raw Data").Select
With Sheets("Raw Data")
    r = .Range("A" & Rows.Count).End(xlUp).Row
    .Range("N2").Formula = "=F2"
    .Range("O2").Formula = "=IF(N2<=5,""0-5"",IF(AND(N2>=6,N2<=15),""6-15"",IF(AND(N2>=16,N2<=30),""16-30"",IF(AND(N2>=31,N2<=90),""31-90"",""91+""))))"
    .Range("P2").Formula = "=VLOOKUP(H2,'Mapping Table'!$B$21:$F$40,2,0)"
    .Range("Q2").Formula = "=VLOOKUP(H2,'Mapping Table'!$B$21:$F$40,3,0)"
    .Range("R2").Formula = "=VLOOKUP(H2,'Mapping Table'!$B$21:$F$40,4,0)"
    .Range("S2").Formula = "=VLOOKUP(H2,'Mapping Table'!$B$21:$F$40,5,0)"
    .Range("T2").Formula = "=H2&"" ""&O2"
    .Range("U2").Formula = "=IF(M2=V2,""TRUE"",""FALSE"")"
    .Range("V2").Formula = "=IF(OR(M2=WORKDAY(TODAY(),-1),M2=WORKDAY(TODAY(),-2)),""Keep"",""Delete"")"
    .Range("W2").Formula = "=IF(M2=WORKDAY(TODAY(),-1),""Today"",""No"")"
    .Range("N2:W2").Copy .Range("N2:W" & r)
End With

End Sub

Open in new window

Introducing Cloud Class® training courses

Tech changes fast. You can learn faster. That’s why we’re bringing professional training courses to Experts Exchange. With a subscription, you can access all the Cloud Class® courses to expand your education, prep for certifications, and get top-notch instructions.

TracyVBA DeveloperCommented:
Is it in the same module, or is it in a class module?

What's the name of the module it's in?  Try this, assuming the module name is Module1


Seamus2626Author Commented:
its module5

i tried that and it didnt fill

Rory ArchibaldCommented:
What does Datacall do? If it retrieves external data, my guess would be that that data refreshes in the background so your fillformula sub has nothing to fill when it runs (the data is still refreshing).
TracyVBA DeveloperCommented:
Add this msgbox to the top of your module, and see if the message appears, then you'll know it's being called properly:

Sub FillFormula()

'Add this
msgbox "You made it in"

 'Your code here
End Sub
Seamus2626Author Commented:
Your spot on Rorya, it is retrieving data.

So i need to run the fill data part later in the sub?
TracyVBA DeveloperCommented:
Why don't you just pause your code to let the datacall finish refreshing the data.

Add this to the very top of your module (right below Option Explicit)
Private Declare Sub Sleep Lib "kernel32" (ByVal dwMilliseconds As Long)

Then do something like this:

Call Datacall
Sleep(10000) 'Wait 10 seconds
Call FillFormula
Seamus2626Author Commented:
Thats the problem. Thanks Rorya.

Thank you too Broome9

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.