Solved

How do i fix this code to work

Posted on 2011-03-01
7
208 Views
Last Modified: 2012-05-11
I have this Stored Procedure I am writing, and i need to get the Database name from a table to run another query from that stored database name. how can i fix this.

declare cur1 cursor for
SELECT [id],[Source_Interid],[From_Vendor_ID],[To_Vendor_ID] FROM [CE_CUSTOM].[dbo].[dw_Vendor_Merge] Where processed_flag='N'
            
open cur1
fetch next from cur1 into @id, @Company, @Old_Vendor_ID, @New_Vendor_ID
set @Company=ltrim(rtrim(@Company))
while @@FETCH_STATUS = 0
begin


THIS IS THE PROBLEM LINE OF CODE.

              -- Get the Vedors New Name
    Select @New_Vendor_Name = select VENDNAME from @Company..pm00200 where VENDORID = @New_Vendor_ID

End line of code NOTE WHERE IT SAYS @COMPANY NAME THAT IS THE PROBLEM.



 etch next from cur1 into @id, @Company, @Old_Vendor_ID, @New_Vendor_ID
 end
close cur1
deallocate cur1
0
Comment
Question by:Steve Samson
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 2
  • 2
  • 2
  • +1
7 Comments
 
LVL 23

Expert Comment

by:Rajkumar Gs
ID: 35007479
Replace
Select @New_Vendor_Name = select VENDNAME from @Company..pm00200 where VENDORID = @New_Vendor_ID
to
Select @New_Vendor_Name = VENDNAME from @Company..pm00200 where VENDORID = @New_Vendor_ID
0
 

Author Comment

by:Steve Samson
ID: 35007542
My bad on this, but I had paste that in by mistake. I ment to say exactly what you stated but the problem is this part @Company..pm00200  of  the statement?

 Select @New_Vendor_Name = VENDNAME from @Company..pm00200 where VENDORID = @New_Vendor_ID

I get this error
Msg 102, Level 15, State 1, Procedure ce_sp_DW_Vendor_Merge, Line 40
Incorrect syntax near '.'.
0
 
LVL 9

Accepted Solution

by:
rajeevnandanmishra earned 500 total points
ID: 35007707
Hi,

You need to use the dynamic execution of code. Something like below may be useful.
Please add below code with your code and give it a try.

 
-- Declare a SQL Statement Variable
declare @strSql nvarchar(1000)

-- In the loop of your code assign the value into the @strSql 
select @strSql = 'SELECT @New_Vendor_Name = VENDNAME FROM ' + @Company + '..pm00200 WHERE VENDORID = @New_Vendor_ID'
-- Now execute the below statement. You may need to change the datatype or length
exec sp_executesql @strSql, N'@New_Vendor_Name VARCHAR(50) OUTPUT, @New_Vendor_ID VARCHAR(6)',  @New_Vendor_Name OUTPUT, @New_Vendor_ID 

-- At this point you are having the proper value in the variable @New_Vendor_Name

Open in new window


0
MS Dynamics Made Instantly Simpler

Make Your Microsoft Dynamics Investment Count  & Drastically Decrease Training Time by Providing Intuitive Step-By-Step WalkThru Tutorials.

 
LVL 10

Expert Comment

by:Jacco
ID: 35007783
Hi,

I think you want something along these lines:

declare @ParameterDefinition nvarchar(500) = '@New_Vendor_Name_OUT nvarchar(100) OUTPUT'
declare @New_Vendor_Name nvarchar(100)

declare @qry nvarchar(4000) = 'Select @New_Vendor_Name_OUT = (select VENDNAME from ' + @Company + '..pm00200 where VENDORID = ' + convert(varchar, @New_Vendor_ID) + ')'

exec sp_executesql  @qry, @ParameterDefinition, @New_Vendor_Name_OUT = @New_Vendor_Name OUTPUT

Regards, Jacco
0
 
LVL 10

Expert Comment

by:Jacco
ID: 35007795
lol, 6 minutes :-)
0
 
LVL 23

Expert Comment

by:Rajkumar Gs
ID: 35007864
I agree with rajeevnandanmishra's comment.
@Company is a variable. It cannot be appended directly to actual query string

SELECT * FROM @Company..pm00200
will be executed as it is. Since there is not database with name '@Company' it will be an error
Instead we want the value of that variable
So using dynamic query, it would work
@Company + '..pm00200' will become something like somedbname..pm00200'

Hope it is clear
Raj
0
 

Author Closing Comment

by:Steve Samson
ID: 35142255
Work great
0

Featured Post

NEW Veeam Agent for Microsoft Windows

Backup and recover physical and cloud-based servers and workstations, as well as endpoint devices that belong to remote users. Avoid downtime and data loss quickly and easily for Windows-based physical or public cloud-based workloads!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

JSON is being used more and more, besides XML, and you surely wanted to parse the data out into SQL instead of doing it in some Javascript. The below function in SQL Server can do the job for you, returning a quick table with the parsed data.
In the first part of this tutorial we will cover the prerequisites for installing SQL Server vNext on Linux.
Viewers will learn how to use the INSERT statement to insert data into their tables. It will also introduce the NULL statement, to show them what happens when no value is giving for any given column.
Viewers will learn how to use the SELECT statement in SQL to return specific rows and columns, with various degrees of sorting and limits in place.

617 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question