?
Solved

Function and Getdate()

Posted on 2011-03-01
8
Medium Priority
?
516 Views
Last Modified: 2012-05-11
I have a table that holds cutoffhours like this:
--
1900-01-01 15:00:00.000
1900-01-01 17:00:00.000--


Below SQL works and I get values like this:
2011-03-01 15:00:00.000
2011-03-01 17:00:00.000
select  convert(varchar(10), getdate(), 111) + cutoffhour
from cutoff

---Now, i want to have this in a function and I cant use getdate() in a function. I need to pass getdate() to it. I tried this but get an error to use "convert" . I know i need to use "convert" around cutoffhour ...did that but dont get the "time" part of cutoffhour field
Create function dbo.test
(
  @CurrentTime datetime
)
RETURNS DATETIME
As
Begin

select @cutoff = convert(varchar(10), @CurrentTime, 111) + cutoffhour --somehow need to use convert with cutoffhour to get 2011-03-01 15:00:00.000 (today's date plus the time in that table)
   from cutoff 

...
end

Open in new window

0
Comment
Question by:Camillia
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
8 Comments
 
LVL 39

Expert Comment

by:BrandonGalderisi
ID: 35009427
What data type is cutoff hour?
0
 
LVL 32

Expert Comment

by:Ephraim Wangoya
ID: 35009461

Create function dbo.test
RETURNS DATETIME
As
Begin

select @cutoff = convert(varchar(10), GETDATE(), 111) + cutoffhour
   from cutoff

...
end
0
 
LVL 29

Expert Comment

by:Olaf Doschke
ID: 35009465
No, you don't need to pass in getdate(), but cutoffhour. Also your convert creates a varchar string, not a datetime. This varchar string then may be implictly converted, as the string format is a valid datetime, but lookup convert in the t-sql helpfile, you'll see that convert(varchar(10),...) converts to varchar(10).

Within the user defined function you're not in the context of the table and cannot adress table fields. But you can make use of any standard/syste T-SQL function within your function.

Create Function dbo.cutoffstring
(
  @cutoffhour varchar(13)
)
RETURNS varchar(23)
As
Begin
   return convert(varchar(10), getdate(), 111) + @cutoffhour
End

Open in new window


Then can use this function via
Select dbo.cutoffstring(cutoffhour) from cutoff

Open in new window


Bye, Olaf.
0
Get your Conversational Ransomware Defense e‑book

This e-book gives you an insight into the ransomware threat and reviews the fundamentals of top-notch ransomware preparedness and recovery. To help you protect yourself and your organization. The initial infection may be inevitable, so the best protection is to be fully prepared.

 
LVL 7

Author Comment

by:Camillia
ID: 35010193
You cannot have getdate() in a function.

cutoffhour is datetime...Brandon....
0
 
LVL 7

Author Comment

by:Camillia
ID: 35010450
this is the solution;

convert(char(10), @currentTime, 111) + CONVERT(VARCHAR(8),cutoffhour,108)

0
 
LVL 41

Accepted Solution

by:
Sharath earned 2000 total points
ID: 35011235
Finally convert it to datetime from varchar.

CONVERT(DATETIME,CONVERT(VARCHAR(10),@currentTime,111) + ' ' + CONVERT(VARCHAR(8),currentTime,108))
0
 
LVL 29

Expert Comment

by:Olaf Doschke
ID: 35011267
Yes, if cutoffhour is not varchar, you cannot add it to another varchar.  I'd choose 112 style over 111 for the date portion and style 114 over 108 for the time portion. And finally do a explicit conversion via cast.

cast(datetime,convert(char(8), @currenttime, 112) + CONVERT(char(12), cutoffhour,114) as datetime)

Bye, Olaf.

PS: in SQL2008 you can use getdate() in a UDF, as usage of nondeterministi functions is relaxed there. How do I know what version of SQL Server you are using, Farzadw?

 
0
 
LVL 29

Expert Comment

by:Olaf Doschke
ID: 35011658
This is a full functional example:

IF OBJECT_ID (N'dbo.overridetime') IS NOT NULL
   DROP FUNCTION dbo.overridetime;
GO

CREATE FUNCTION dbo.overridetime(@currenttime datetime, @cutoffhour datetime)
RETURNS datetime
WITH EXECUTE AS CALLER
AS
BEGIN
  return convert(char(8), @currenttime, 112)+' '+convert(char(12), @cutoffhour,114)
END;
GO

IF OBJECT_ID(N'tempdb.dbo.#tmp') IS NULL
BEGIN
   create table #tmp (cutoffhour datetime);  
   insert into #tmp values ('19000101 15:00:00.000');
END;

select dbo.overridetime(getdate(),cutoffhour) as 'mydatetime' from #tmp

Open in new window


Bye, Olaf.
0

Featured Post

What does it mean to be "Always On"?

Is your cloud always on? With an Always On cloud you won't have to worry about downtime for maintenance or software application code updates, ensuring that your bottom line isn't affected.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Why is this different from all of the other step by step guides?  Because I make a living as a DBA and not as a writer and I lived through this experience. Defining the name: When I talk to people they say different names on this subject stuff l…
Slowly Changing Dimension Transformation component in data task flow is very useful for us to manage and control how data changes in SSIS.
Via a live example, show how to set up a backup for SQL Server using a Maintenance Plan and how to schedule the job into SQL Server Agent.
Viewers will learn how to use the SELECT statement in SQL to return specific rows and columns, with various degrees of sorting and limits in place.
Suggested Courses

752 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question