Solved

Function and Getdate()

Posted on 2011-03-01
8
474 Views
Last Modified: 2012-05-11
I have a table that holds cutoffhours like this:
--
1900-01-01 15:00:00.000
1900-01-01 17:00:00.000--


Below SQL works and I get values like this:
2011-03-01 15:00:00.000
2011-03-01 17:00:00.000
select  convert(varchar(10), getdate(), 111) + cutoffhour
from cutoff

---Now, i want to have this in a function and I cant use getdate() in a function. I need to pass getdate() to it. I tried this but get an error to use "convert" . I know i need to use "convert" around cutoffhour ...did that but dont get the "time" part of cutoffhour field
Create function dbo.test
(
  @CurrentTime datetime
)
RETURNS DATETIME
As
Begin

select @cutoff = convert(varchar(10), @CurrentTime, 111) + cutoffhour --somehow need to use convert with cutoffhour to get 2011-03-01 15:00:00.000 (today's date plus the time in that table)
   from cutoff 

...
end

Open in new window

0
Comment
Question by:Camillia
8 Comments
 
LVL 39

Expert Comment

by:BrandonGalderisi
Comment Utility
What data type is cutoff hour?
0
 
LVL 32

Expert Comment

by:ewangoya
Comment Utility

Create function dbo.test
RETURNS DATETIME
As
Begin

select @cutoff = convert(varchar(10), GETDATE(), 111) + cutoffhour
   from cutoff

...
end
0
 
LVL 29

Expert Comment

by:Olaf Doschke
Comment Utility
No, you don't need to pass in getdate(), but cutoffhour. Also your convert creates a varchar string, not a datetime. This varchar string then may be implictly converted, as the string format is a valid datetime, but lookup convert in the t-sql helpfile, you'll see that convert(varchar(10),...) converts to varchar(10).

Within the user defined function you're not in the context of the table and cannot adress table fields. But you can make use of any standard/syste T-SQL function within your function.

Create Function dbo.cutoffstring
(
  @cutoffhour varchar(13)
)
RETURNS varchar(23)
As
Begin
   return convert(varchar(10), getdate(), 111) + @cutoffhour
End

Open in new window


Then can use this function via
Select dbo.cutoffstring(cutoffhour) from cutoff

Open in new window


Bye, Olaf.
0
 
LVL 7

Author Comment

by:Camillia
Comment Utility
You cannot have getdate() in a function.

cutoffhour is datetime...Brandon....
0
Maximize Your Threat Intelligence Reporting

Reporting is one of the most important and least talked about aspects of a world-class threat intelligence program. Here’s how to do it right.

 
LVL 7

Author Comment

by:Camillia
Comment Utility
this is the solution;

convert(char(10), @currentTime, 111) + CONVERT(VARCHAR(8),cutoffhour,108)

0
 
LVL 40

Accepted Solution

by:
Sharath earned 500 total points
Comment Utility
Finally convert it to datetime from varchar.

CONVERT(DATETIME,CONVERT(VARCHAR(10),@currentTime,111) + ' ' + CONVERT(VARCHAR(8),currentTime,108))
0
 
LVL 29

Expert Comment

by:Olaf Doschke
Comment Utility
Yes, if cutoffhour is not varchar, you cannot add it to another varchar.  I'd choose 112 style over 111 for the date portion and style 114 over 108 for the time portion. And finally do a explicit conversion via cast.

cast(datetime,convert(char(8), @currenttime, 112) + CONVERT(char(12), cutoffhour,114) as datetime)

Bye, Olaf.

PS: in SQL2008 you can use getdate() in a UDF, as usage of nondeterministi functions is relaxed there. How do I know what version of SQL Server you are using, Farzadw?

 
0
 
LVL 29

Expert Comment

by:Olaf Doschke
Comment Utility
This is a full functional example:

IF OBJECT_ID (N'dbo.overridetime') IS NOT NULL
   DROP FUNCTION dbo.overridetime;
GO

CREATE FUNCTION dbo.overridetime(@currenttime datetime, @cutoffhour datetime)
RETURNS datetime
WITH EXECUTE AS CALLER
AS
BEGIN
  return convert(char(8), @currenttime, 112)+' '+convert(char(12), @cutoffhour,114)
END;
GO

IF OBJECT_ID(N'tempdb.dbo.#tmp') IS NULL
BEGIN
   create table #tmp (cutoffhour datetime);  
   insert into #tmp values ('19000101 15:00:00.000');
END;

select dbo.overridetime(getdate(),cutoffhour) as 'mydatetime' from #tmp

Open in new window


Bye, Olaf.
0

Featured Post

How to run any project with ease

Manage projects of all sizes how you want. Great for personal to-do lists, project milestones, team priorities and launch plans.
- Combine task lists, docs, spreadsheets, and chat in one
- View and edit from mobile/offline
- Cut down on emails

Join & Write a Comment

Performance is the key factor for any successful data integration project, knowing the type of transformation that you’re using is the first step on optimizing the SSIS flow performance, by utilizing the correct transformation or the design alternat…
This article explains how to reset the password of the sa account on a Microsoft SQL Server.  The steps in this article work in SQL 2005, 2008, 2008 R2, 2012, 2014 and 2016.
This videos aims to give the viewer a basic demonstration of how a user can query current session information by using the SYS_CONTEXT function
Via a live example, show how to setup several different housekeeping processes for a SQL Server.

771 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

12 Experts available now in Live!

Get 1:1 Help Now