Solved

Saving form data to worksheet goes in row ABOVE

Posted on 2011-03-03
6
295 Views
Last Modified: 2012-05-11
I have a user form that accepts changes.  When the user hits save, the data should be saved in the row that appears on the form via the VBA code.  Say data is sourced in Row 11 and this row number is what is reflected on the form.  When the user saves changes, all the data should go back to the proper field on the form in Row 11, but it goes into row 10!  I checked and it seems c onsistent, the data is saved in the row above the row reflected on the form.  
Private Sub SaveData()
'Save changed data to Settings worksheet
With ThisWorkbook.Worksheets("Settings")
    .Unprotect Password:=s_PSWD
          With .Rows(Me.txtRowNumber)
                .Cells(0, 1).Value = Me.txtAddedBy.Value
                .Cells(0, 2).Value = Me.txtAddDate.Value
                .Cells(0, 3).Value = "Yes"
                .Cells(0, 4).Value = Me.txtClosedChangedBy.Value
                .Cells(0, 5).Value = Me.txtCloseChangeDate.Value
                .Cells(0, 6).Value = Me.txtPortfolioCode.Value
                .Cells(0, 7).Value = Me.txtPortfolioName.Value
                .Cells(0, 8).Value = Me.txtURLSectorSummary.Value
                .Cells(0, 9).Value = Me.txtURLSectorDetail.Value
                .Cells(0, 10).Value = Me.txtURLRatingSummary.Value
                .Cells(0, 11).Value = Me.txtURLRatingDetail.Value
         End With
    .Protect Password:=s_PSWD
End With
'Reset form for next data set changes
Call ClearControls
MsgBox "Data has been saved", vbOKOnly
        
Exit_ErrorHandler:
    Exit Sub
ErrorHandler:
        MsgBox Err.Number & " Description: " & Err.Description
        Resume Exit_ErrorHandler
End Sub

Open in new window

0
Comment
Question by:ssmith94015
  • 2
  • 2
  • 2
6 Comments
 
LVL 24

Expert Comment

by:StephenJR
ID: 35028791
Might be your cells notation. Does this work?

.Cells(1, 1).Value = Me.txtAddedBy.Value
0
 
LVL 85

Expert Comment

by:Rory Archibald
ID: 35028796
Change the zeroes in .Cells(0, 1) etc to 1 and you should be fine.
0
 

Author Comment

by:ssmith94015
ID: 35028837
I am looking at it and maybe it is simply that I am referring to the row number, but not telling it to start with cell A11?  that is, if the .Rows(Me.txtRowNumber) = 11, I think I am missing the point in that I need to now tell it the starting cell is A11?  You both are correct in that Cells(1,1) will work, but I am wondering that myproblem is I simply am not telling it which cell to actually start with?
0
Comprehensive Backup Solutions for Microsoft

Acronis protects the complete Microsoft technology stack: Windows Server, Windows PC, laptop and Surface data; Microsoft business applications; Microsoft Hyper-V; Azure VMs; Microsoft Windows Server 2016; Microsoft Exchange 2016 and SQL Server 2016.

 
LVL 24

Assisted Solution

by:StephenJR
StephenJR earned 250 total points
ID: 35028858
If txtRowNumber=11 then Rows(11).Cells(1,1) is A11.
0
 
LVL 85

Accepted Solution

by:
Rory Archibald earned 250 total points
ID: 35028867
No, you are telling it the correct start cell, but Cells(0,1) is the cell above that cell. Perhaps you are confusing it with .Offset(0,1) which would be the cell in the same row but one column across?
0
 

Author Closing Comment

by:ssmith94015
ID: 35028897
Rorya, yes, I think I am getting confused.  I was assuming zero-based starting point and now this does make sense.  Thank you both!  Am splitting points as you both answered the question.  And I appreciate the lesson.
0

Featured Post

Comprehensive Backup Solutions for Microsoft

Acronis protects the complete Microsoft technology stack: Windows Server, Windows PC, laptop and Surface data; Microsoft business applications; Microsoft Hyper-V; Azure VMs; Microsoft Windows Server 2016; Microsoft Exchange 2016 and SQL Server 2016.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

This code takes an Excel list of URL’s and adds a header titled “URL List”. It then searches through all URL’s in column “A”, looking for duplicates. When a duplicate is found, it is moved to the top of the list. The duplicate URL’s are then highlig…
This article descibes how to create a connection between Excel and SAP and how to move data from Excel to SAP or the other way around.
The viewer will learn how to use a discrete random variable to simulate the return on an investment over a period of years, create a Monte Carlo simulation using the discrete random variable, and create a graph to represent the possible returns over…
This Micro Tutorial will demonstrate how to use longer labels with horizontal bar charts instead of the vertical column chart.

777 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question