Solved

Simple powershell script

Posted on 2011-03-04
8
764 Views
Last Modified: 2012-05-11
I have a script right now that looks for all files certain day old and certain file extension and it deletes all of the files. This works fine and it counts fine

Then I have to delete all folders that correspond to being empty and that includes all sub folders too. I also have to output this into a file and display each file deleted. The output would show 30 folders deleted but actually 48 were really deleted.

Now my question is i am trying to do a count of all the folders deleted. I have this script but it just counts the deepest folders not all the ones deleted. Here is the part of the script i can not get to count

$TargetFolder = "C:\Users\user\Desktop\temp"
$LogFile = "C:\Summary.txt"
$Count = 0

Date | Out-File -filepath $LogFile

get-childitem $TargetFolder -recurse -force | Where-Object {$_.psIsContainer}| sort fullName -des |
Where-Object {!(get-childitem $_.fullName -force)} | ForEach-Object{$Count++; $_.fullName} | remove-item -whatif | Out-File -filepath $LogFile -append

$Count = "Total Folders = " + $Count
$Count | Out-File -filepath $LogFile -append

0
Comment
Question by:pitster
  • 4
  • 4
8 Comments
 
LVL 5

Expert Comment

by:daveTechSearch
ID: 35039583
if you JUST run this.... is the count correct?
$TargetFolder = "C:\Users\user\Desktop\temp"

(
get-childitem $TargetFolder -recurse -force | Where-Object {$_.psIsContainer}| sort fullName -des |
Where-Object {!(get-childitem $_.fullName -force)}
).count

Open in new window

0
 
LVL 3

Author Comment

by:pitster
ID: 35055952
No the count shows 30.  So it is counting incorrectly but deleting the right amount.
0
 
LVL 3

Author Comment

by:pitster
ID: 35056154
It seems to just count the deepest folders and ignores the others.  This I do not understand i thought the recurse would count each folder?
0
 
LVL 5

Expert Comment

by:daveTechSearch
ID: 35058848
Hmmm.... I just ran a similar test...

Nested folders with no files in them... and others with files.  The folders deleted were ONLY the deepest folder... I assume this would be due to parent folders *not* being empty... they contain other folders.  In my case, the count was also correct
0
What Is Threat Intelligence?

Threat intelligence is often discussed, but rarely understood. Starting with a precise definition, along with clear business goals, is essential.

 
LVL 5

Accepted Solution

by:
daveTechSearch earned 50 total points
ID: 35058880
0
 
LVL 3

Author Comment

by:pitster
ID: 35059776
not sure if you tested this at all but i get an error of

The term 'prune-directory' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is co
rrect and try again.
At line:1 char:16
+ prune-directory <<<<  c:\users\paul.healey\temp
    + CategoryInfo          : ObjectNotFound: (prune-directory:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
0
 
LVL 5

Expert Comment

by:daveTechSearch
ID: 35060894
prune-directory is actually a function that the author of the post wrote (see the article).

I am guessing that powershell is removing items from top level (rather than bottom up).. resulting in the skewed results... that is... all empty folders deleted, but the count does not add up for empty folders.

If I run this on my test folder:
$TargetFolder = "C:\folders\"

get-childitem $TargetFolder -recurse -force | ? {$_.psIsContainer} |
sort fullName -des | ? {!(get-childitem $_.fullName -force -recurse)} | select fullName

... the bottom level folders are listed.  If I replace the 'select' statement with the 'remove'... the top level folder is also removed.
0
 
LVL 3

Author Closing Comment

by:pitster
ID: 35130849
This got me to part of what i needed still having trouble getting a count but i can now at least display what I need
0

Featured Post

How to improve team productivity

Quip adds documents, spreadsheets, and tasklists to your Slack experience
- Elevate ideas to Quip docs
- Share Quip docs in Slack
- Get notified of changes to your docs
- Available on iOS/Android/Desktop/Web
- Online/Offline

Join & Write a Comment

Hi all.   The other day I had to change the passwords for a bunch of users on the fly. Because they were so many, I decided to do it in an automated way and I would like to share it with you all.   If you are not doing it directly in a Domain Co…
A procedure for exporting installed hotfix details of remote computers using powershell
It is a freely distributed piece of software for such tasks as photo retouching, image composition and image authoring. It works on many operating systems, in many languages.
This demo shows you how to set up the containerized NetScaler CPX with NetScaler Management and Analytics System in a non-routable Mesos/Marathon environment for use with Micro-Services applications.

707 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

12 Experts available now in Live!

Get 1:1 Help Now