Solved

docmd.runsql argument error

Posted on 2011-03-06

Microsoft Access

2 solutions

Medium Priority

647 Views

Last Modified: 2012-08-14

I am trying to loop through each client in the tblclients table and for each client delete some records in another table.

I have a string select statement that changes for each client BUT the docmd.runsql method says it needs an argument consisting of an sql string which I though I had passed it

if i add brackets i get the same.

Private Sub BtnRemoveDeletedCWCodesFromClients_Click()
Dim db As Database
Set db = CurrentDb

Dim rs As DAO.Recordset
Dim clientId As Integer
Dim cwcodetounmatch As String
Dim StrSelect As String
Dim strFrom As String
Dim strWhere As String

Dim newsql As String

Dim sqlstr As String





Set rs = db.OpenRecordset("tblclients")

StrSelect = "SELECT * "

With rs
rs.MoveFirst
    Do While Not rs.EOF
   
    Select Case rs.Fields("clientid").Value

        Case 1
            strFrom = "FROM AbiToMvris "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = AbiToMvris.[mvris code]))<>False));"
        Case 2
            strFrom = "FROM GlassesToMvris "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = GlassesToMvris.[mvris code]))<>False));"
        Case 3
            strFrom = "FROM CW_to_IDS "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CW_to_IDS.[mvriscode]))<>False));"
        Case 4
            strFrom = "FROM CWCode_To_Continental "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CWCode_To_Continental.[cwcode]))<>False));"
        Case 5
            strFrom = "FROM HalfordsToMvris "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = HalfordsToMvris.[mvriscode]))<>False));"
        Case 6
            strFrom = "FROM CWCode_To_Michelin "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CWCode_To_Michelin.[cwcode]))<>False));"
        Case 7
            strFrom = "FROM TechDocToMvris "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = TechDocToMvris.[mvris code]))<>False));"
        Case 8
            strFrom = "FROM VividToMvris "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = VividToMvris.[mvriscode]))<>False));"
        Case 9
            strFrom = "FROM CapToMvris-CW "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CapToMvris-CW.[mvriscode]))<>False));"

End Select
    
    sqlstr = StrSelect & strFrom & strWhere
    
    DoCmd.RunSQL sqlstr
    
    
    Loop
End With
End Sub

Open in new window

Comment

Question by:PeterBaileyUk

[X]

Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

Help others & share knowledge
Earn cash & points
Learn & ask questions

Join The Community

3 Comments

Accepted Solution

by:r1sc

r1sc earned 1000 total points

ID: 350463042011-03-06

Hi PeterBaileyUk,
most cases where RunSQL asks for an argument is related to an column name which is not spelled correctly.
I would bet you wanted to join two tables and select only few rows with matching [mvris code], but sometimes this column has an similar name.
You try to use the second table name in the query in the where clause, but it is not included in your from clause, so the name can not be resolved to a column name in all tables in your from clause.
You need to write:
...from QryCWCodesRemoved, AbiToMvris where QryCWCodesRemoved.[mvris code] = AbiToMvris.[mvris code]
or
...from QryCWCodesRemoved inner join AbiToMvris on QryCWCodesRemoved.[mvris code] = AbiToMvris.[mvris code]

best regards,
r1sc

LVL 77

Assisted Solution

by:peter57r

peter57r earned 1000 total points

ID: 350463542011-03-06

I see that you are using different version of mvriscode/ [mvris code] in different places. This looks like the most obvious place where something could be wrong. But when ypou get the error you need to go into the immediate windoe and do..
?sqlstr
and look at that particular statment.

You could copy it into a new empty query and get a precise error message if necessary.

Author Comment

by:PeterBaileyUk

ID: 350464492011-03-06

it was me being stupid I was testing but change the query to a select query which I subsequently discovered docmd.runsql does not run, now its changed to delete ..... its working.

Private Sub BtnRemoveDeletedCWCodesFromClients_Click()
Dim db As Database
Set db = CurrentDb

Dim rs As DAO.Recordset
Dim clientId As Integer
Dim cwcodetounmatch As String
Dim StrSelect As String
Dim strFrom As String
Dim strWhere As String
Dim newsql As String


'Set qd = db.QueryDefs(stringfull)

Dim sqlstr As String
Dim qd As DAO.QueryDef
Set qd = db.QueryDefs("QryDelFromMatchTable")
sqlstr = qd.SQL


'DoCmd.SetWarnings False

Set rs = db.OpenRecordset("tblclients")


' DoCmd.SetWarnings = False
With rs
rs.MoveFirst
    Do While Not rs.EOF
   
    Select Case rs.Fields("clientid").Value

        Case 1
            StrSelect = "DELETE Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = AbiToMvris.[mvris code]), * "
            strFrom = "FROM AbiToMvris "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = AbiToMvris.[mvris code]))<>False));"
        Case 2
            StrSelect = "DELETE Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = GlassesToMvris.[mvris code]), * "
            strFrom = "FROM GlassesToMvris "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = GlassesToMvris.[mvris code]))<>False));"
        Case 3
            StrSelect = "DELETE Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CW_to_IDS.[mvriscode]), * "
            strFrom = "FROM CW_to_IDS "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CW_to_IDS.[mvriscode]))<>False));"
        Case 4
            StrSelect = "DELETE Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CWCode_To_Continental.[cwcode]), * "
            strFrom = "FROM CWCode_To_Continental "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CWCode_To_Continental.[cwcode]))<>False));"
        Case 5
            StrSelect = "DELETE Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = HalfordsToMvris.[mvriscode]), * "
            strFrom = "FROM HalfordsToMvris "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = HalfordsToMvris.[mvriscode]))<>False));"
        Case 6
            StrSelect = "DELETE Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CWCode_To_Michelin.[cwcode]), * "
            strFrom = "FROM CWCode_To_Michelin "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CWCode_To_Michelin.[cwcode]))<>False));"
        Case 7
            StrSelect = "DELETE Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = TechDocToMvris.[mvris code]), * "
            strFrom = "FROM TechDocToMvris "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = TechDocToMvris.[mvris code]))<>False));"
        Case 8
            StrSelect = "DELETE Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = VividToMvris.[mvriscode]), * "
            strFrom = "FROM VividToMvris "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = VividToMvris.[mvriscode]))<>False));"
        Case 9
            StrSelect = "DELETE Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CapToMvris-CW.[mvriscode]), * "
            strFrom = "FROM CapToMvris-CW "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CapToMvris-CW.[mvriscode]))<>False));"

End Select
    
   newsql = StrSelect & strFrom & strWhere
   
'   Debug.Print newsql
'   qd.SQL = newsql
'   DoCmd.OpenQuery ("QryDelFromMatchTable")
    DoCmd.RunSQL newsql
    rs.MoveNext
    Loop
End With
'DoCmd.SetWarnings True
End Sub

Open in new window

Featured Post

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Automating Microsoft Excel from Access (Part II)

Article by: Dale Fye

In Part II of this series, I will discuss how to identify all open instances of Excel and enumerate the workbooks, spreadsheets, and named ranges within each of those instances.

QODBC: How to use VBA to Disable Non-Updateable QuickBooks® Fields on a Microsoft® Access® Form (Part 1)

Article by: Annaliese

Code that checks the QuickBooks schema table for non-updateable fields and then disables those controls on a form so users don't try to update them.

Secure Portal Encryption

Video by: Dermot

With Secure Portal Encryption, the recipient is sent a link to their email address directing them to the email laundry delivery page. From there, the recipient will be required to enter a user name and password to enter the page. Once the recipient …

display Triangles! and Circles! in a Microsoft Access Query -- Get Previous Record too

Video by: crystal

Visualize your data even better in Access queries. Given a date and a value, this lesson shows how to compare that value with the previous value, calculate the difference, and display a circle if the value is the same, an up triangle if it increased…