Want to win a PS4? Go Premium and enter to win our High-Tech Treats giveaway. Enter to Win

x
?
Solved

docmd.runsql argument error

Posted on 2011-03-06
3
Medium Priority
?
653 Views
Last Modified: 2012-08-14
I am trying to loop through each client in the tblclients table and for each client delete some records in another table.

I have a string select statement that changes for each client BUT the docmd.runsql method says it needs an argument consisting of an sql string which I though I had passed it

if i add brackets i get the same.
Private Sub BtnRemoveDeletedCWCodesFromClients_Click()
Dim db As Database
Set db = CurrentDb

Dim rs As DAO.Recordset
Dim clientId As Integer
Dim cwcodetounmatch As String
Dim StrSelect As String
Dim strFrom As String
Dim strWhere As String

Dim newsql As String

Dim sqlstr As String





Set rs = db.OpenRecordset("tblclients")

StrSelect = "SELECT * "

With rs
rs.MoveFirst
    Do While Not rs.EOF
   
    Select Case rs.Fields("clientid").Value

        Case 1
            strFrom = "FROM AbiToMvris "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = AbiToMvris.[mvris code]))<>False));"
        Case 2
            strFrom = "FROM GlassesToMvris "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = GlassesToMvris.[mvris code]))<>False));"
        Case 3
            strFrom = "FROM CW_to_IDS "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CW_to_IDS.[mvriscode]))<>False));"
        Case 4
            strFrom = "FROM CWCode_To_Continental "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CWCode_To_Continental.[cwcode]))<>False));"
        Case 5
            strFrom = "FROM HalfordsToMvris "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = HalfordsToMvris.[mvriscode]))<>False));"
        Case 6
            strFrom = "FROM CWCode_To_Michelin "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CWCode_To_Michelin.[cwcode]))<>False));"
        Case 7
            strFrom = "FROM TechDocToMvris "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = TechDocToMvris.[mvris code]))<>False));"
        Case 8
            strFrom = "FROM VividToMvris "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = VividToMvris.[mvriscode]))<>False));"
        Case 9
            strFrom = "FROM CapToMvris-CW "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CapToMvris-CW.[mvriscode]))<>False));"

End Select
    
    sqlstr = StrSelect & strFrom & strWhere
    
    DoCmd.RunSQL sqlstr
    
    
    Loop
End With
End Sub

Open in new window

0
Comment
Question by:PeterBaileyUk
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
3 Comments
 

Accepted Solution

by:
r1sc earned 1000 total points
ID: 35046304
Hi PeterBaileyUk,
most cases where RunSQL asks for an argument is related to an column name which is not spelled correctly.
I would bet you wanted to join two tables and select only few rows with matching [mvris code], but sometimes this column has an similar name.
You try to use the second table name in the query in the where clause, but it is not included in your from clause, so the name can not be resolved to a column name in all tables in your from clause.
You need to write:
...from QryCWCodesRemoved, AbiToMvris where QryCWCodesRemoved.[mvris code] = AbiToMvris.[mvris code]
or
...from QryCWCodesRemoved inner join AbiToMvris on QryCWCodesRemoved.[mvris code] = AbiToMvris.[mvris code]

best regards,
r1sc
0
 
LVL 77

Assisted Solution

by:peter57r
peter57r earned 1000 total points
ID: 35046354
I see that you are using different version of mvriscode/ [mvris code] in different places.  This looks like the most obvious place where something could be wrong. But when ypou get the error you need to go into the immediate windoe and do..
?sqlstr
and look at that particular statment.

You could copy it into a new empty query and get a precise error message if necessary.
0
 

Author Comment

by:PeterBaileyUk
ID: 35046449
it was me being stupid I was testing but change the query to a select query which I subsequently discovered docmd.runsql does not run, now its changed to delete ..... its working.
Private Sub BtnRemoveDeletedCWCodesFromClients_Click()
Dim db As Database
Set db = CurrentDb

Dim rs As DAO.Recordset
Dim clientId As Integer
Dim cwcodetounmatch As String
Dim StrSelect As String
Dim strFrom As String
Dim strWhere As String
Dim newsql As String


'Set qd = db.QueryDefs(stringfull)

Dim sqlstr As String
Dim qd As DAO.QueryDef
Set qd = db.QueryDefs("QryDelFromMatchTable")
sqlstr = qd.SQL


'DoCmd.SetWarnings False

Set rs = db.OpenRecordset("tblclients")


' DoCmd.SetWarnings = False
With rs
rs.MoveFirst
    Do While Not rs.EOF
   
    Select Case rs.Fields("clientid").Value

        Case 1
            StrSelect = "DELETE Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = AbiToMvris.[mvris code]), * "
            strFrom = "FROM AbiToMvris "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = AbiToMvris.[mvris code]))<>False));"
        Case 2
            StrSelect = "DELETE Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = GlassesToMvris.[mvris code]), * "
            strFrom = "FROM GlassesToMvris "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = GlassesToMvris.[mvris code]))<>False));"
        Case 3
            StrSelect = "DELETE Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CW_to_IDS.[mvriscode]), * "
            strFrom = "FROM CW_to_IDS "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CW_to_IDS.[mvriscode]))<>False));"
        Case 4
            StrSelect = "DELETE Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CWCode_To_Continental.[cwcode]), * "
            strFrom = "FROM CWCode_To_Continental "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CWCode_To_Continental.[cwcode]))<>False));"
        Case 5
            StrSelect = "DELETE Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = HalfordsToMvris.[mvriscode]), * "
            strFrom = "FROM HalfordsToMvris "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = HalfordsToMvris.[mvriscode]))<>False));"
        Case 6
            StrSelect = "DELETE Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CWCode_To_Michelin.[cwcode]), * "
            strFrom = "FROM CWCode_To_Michelin "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CWCode_To_Michelin.[cwcode]))<>False));"
        Case 7
            StrSelect = "DELETE Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = TechDocToMvris.[mvris code]), * "
            strFrom = "FROM TechDocToMvris "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = TechDocToMvris.[mvris code]))<>False));"
        Case 8
            StrSelect = "DELETE Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = VividToMvris.[mvriscode]), * "
            strFrom = "FROM VividToMvris "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = VividToMvris.[mvriscode]))<>False));"
        Case 9
            StrSelect = "DELETE Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CapToMvris-CW.[mvriscode]), * "
            strFrom = "FROM CapToMvris-CW "
            strWhere = "WHERE (((Exists (Select [mvris code] from QryCWCodesRemoved where QryCWCodesRemoved.[mvris code] = CapToMvris-CW.[mvriscode]))<>False));"

End Select
    
   newsql = StrSelect & strFrom & strWhere
   
'   Debug.Print newsql
'   qd.SQL = newsql
'   DoCmd.OpenQuery ("QryDelFromMatchTable")
    DoCmd.RunSQL newsql
    rs.MoveNext
    Loop
End With
'DoCmd.SetWarnings True
End Sub

Open in new window

0

Featured Post

New feature and membership benefit!

New feature! Upgrade and increase expert visibility of your issues with Priority Questions.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

In Part II of this series, I will discuss how to identify all open instances of Excel and enumerate the workbooks, spreadsheets, and named ranges within each of those instances.
Instead of error trapping or hard-coding for non-updateable fields when using QODBC, let VBA automatically disable them when forms open. This way, users can view but not change the data. Part 1 explained how to use schema tables to do this. Part 2 h…
Using Microsoft Access, learn some simple rules for how to construct tables in a relational database. Split up all multi-value fields into single values: Split up fields that belong to other things into separate tables: Make sure that all record…
What’s inside an Access Desktop Database. Will look at the basic interface, Navigation Pane (Database Container), Tables, Queries, Forms, Report, Macro’s, and VBA code.

636 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question