?
Solved

Syntax help with SQL Function

Posted on 2011-03-06
6
Medium Priority
?
371 Views
Last Modified: 2012-05-11
I have a funtion with one parameter that returns a sum of all wages paid for a particular job from a table called TimeSheets. I use this funtion in a stored procedure but now I find I need fringe costs (Union Dues) also. For every row of wages there are four lines of fringe costs in another related table that I need to include as part of the total wages.

Here is the function I use to return labor costs against a job:

ALTER FUNCTION [dbo].[fn_LaborCosts]
               (@JobNumber char(5))
RETURNS MONEY
AS
  BEGIN
  DECLARE @TotalAmount money
  SELECT @TotalAmount = (SELECT sum(ts.LaborAmount)
  FROM      TimeSheets      ts
            
  WHERE ts.JobNumber = @JobNumber)
                        
  RETURN @TotalAmount

Here is how I use it in the Stored procedure:

ALTER PROCEDURE [dbo].[spSelectJobs]
AS
SELECT      
      JobNumber,
      JobDescription,
      ProposalPrice,
      dbo.fn_LaborCosts(j.JobNumber) AS TotalLabor
                        
FROM   dbo.Jobs   j

The PK for the Fringe table is TsKey so for every row in the TimeSheets table there are four rows in the Fringe table with the TsKey. I need to add up all the fringe costs and add them to the total labor costs and I am not sure how to accomplish this. Thanks for any help on this.
0
Comment
Question by:AkAlan
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 2
  • 2
6 Comments
 
LVL 41

Accepted Solution

by:
Sharath earned 1000 total points
ID: 35050113
Alter the function like this.
ALTER FUNCTION [dbo].[FN_LABORCOSTS] 
              (@JobNumber CHAR(5)) 
RETURNS MONEY 
AS 
  BEGIN 
    DECLARE  @TotalAmount MONEY 
     
    SELECT @TotalAmount = SUM(ts.LaborAmount + ISNULL(f.FringeCost,0)) 
      FROM TimeSheets ts 
           LEFT JOIN (  SELECT TsKey, 
                          SUM(FringeCost) FringeCost 
                     FROM Fringe 
                 GROUP BY TsKey) f 
             ON ts.TsKey = f.TsKey 
     WHERE ts.JobNumber = @JobNumber 
     
    RETURN @TotalAmount 
  END

Open in new window

0
 
LVL 75

Assisted Solution

by:Anthony Perkins
Anthony Perkins earned 1000 total points
ID: 35052154
Or just simply (no points please):
ALTER FUNCTION [dbo].[FN_LABORCOSTS] (@JobNumber CHAR(5))

RETURNS MONEY

AS

BEGIN 
     
RETURN (
   SELECT   SUM(ts.LaborAmount + ISNULL(f.FringeCost, 0))
   FROM     TimeSheets ts
            LEFT JOIN (SELECT   TsKey,
                                SUM(FringeCost) FringeCost
                       FROM     Fringe
                       GROUP BY TsKey) f ON ts.TsKey = f.TsKey
   WHERE    ts.JobNumber = @JobNumber 
     )
END

Open in new window

0
 
LVL 75

Expert Comment

by:Anthony Perkins
ID: 35063539
Sharath_123,

My apologies, as you can see I did try, unfortunately it seems the author overlooked my request.

Feel free to object.

Anthony
0
 
LVL 6

Author Comment

by:AkAlan
ID: 35070776
Ace, I just realized what happened here. I will try and rectify it. I thought the second post was you with a cleaner solution than your first.
0
 
LVL 41

Expert Comment

by:Sharath
ID: 35071490
acperkins -  Not an issue. :) Expected a split, but that's ok.
0

Featured Post

New benefit for Premium Members - Upgrade now!

Ready to get started with anonymous questions today? It's easy! Learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

This is basically a blog post I wrote recently. I've found that SARGability is poorly understood, and since many people don't read blogs, I figured I'd post it here as an article. SARGable is an adjective in SQL that means that an item can be fou…
Hi all, It is important and often overlooked to understand “Database properties”. Often we see questions about "log files" or "where is the database" and one of the easiest ways to get general information about your database is to use “Database p…
How to fix incompatible JVM issue while installing Eclipse While installing Eclipse in windows, got one error like above and unable to proceed with the installation. This video describes how to successfully install Eclipse. How to solve incompa…
Want to learn how to record your desktop screen without having to use an outside camera. Click on this video and learn how to use the cool google extension called "Screencastify"! Step 1: Open a new google tab Step 2: Go to the left hand upper corn…

719 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question