Solved

Syntax help with SQL Function

Posted on 2011-03-06
6
354 Views
Last Modified: 2012-05-11
I have a funtion with one parameter that returns a sum of all wages paid for a particular job from a table called TimeSheets. I use this funtion in a stored procedure but now I find I need fringe costs (Union Dues) also. For every row of wages there are four lines of fringe costs in another related table that I need to include as part of the total wages.

Here is the function I use to return labor costs against a job:

ALTER FUNCTION [dbo].[fn_LaborCosts]
               (@JobNumber char(5))
RETURNS MONEY
AS
  BEGIN
  DECLARE @TotalAmount money
  SELECT @TotalAmount = (SELECT sum(ts.LaborAmount)
  FROM      TimeSheets      ts
            
  WHERE ts.JobNumber = @JobNumber)
                        
  RETURN @TotalAmount

Here is how I use it in the Stored procedure:

ALTER PROCEDURE [dbo].[spSelectJobs]
AS
SELECT      
      JobNumber,
      JobDescription,
      ProposalPrice,
      dbo.fn_LaborCosts(j.JobNumber) AS TotalLabor
                        
FROM   dbo.Jobs   j

The PK for the Fringe table is TsKey so for every row in the TimeSheets table there are four rows in the Fringe table with the TsKey. I need to add up all the fringe costs and add them to the total labor costs and I am not sure how to accomplish this. Thanks for any help on this.
0
Comment
Question by:AkAlan
  • 2
  • 2
6 Comments
 
LVL 40

Accepted Solution

by:
Sharath earned 250 total points
ID: 35050113
Alter the function like this.
ALTER FUNCTION [dbo].[FN_LABORCOSTS] 
              (@JobNumber CHAR(5)) 
RETURNS MONEY 
AS 
  BEGIN 
    DECLARE  @TotalAmount MONEY 
     
    SELECT @TotalAmount = SUM(ts.LaborAmount + ISNULL(f.FringeCost,0)) 
      FROM TimeSheets ts 
           LEFT JOIN (  SELECT TsKey, 
                          SUM(FringeCost) FringeCost 
                     FROM Fringe 
                 GROUP BY TsKey) f 
             ON ts.TsKey = f.TsKey 
     WHERE ts.JobNumber = @JobNumber 
     
    RETURN @TotalAmount 
  END

Open in new window

0
 
LVL 75

Assisted Solution

by:Anthony Perkins
Anthony Perkins earned 250 total points
ID: 35052154
Or just simply (no points please):
ALTER FUNCTION [dbo].[FN_LABORCOSTS] (@JobNumber CHAR(5))

RETURNS MONEY

AS

BEGIN 
     
RETURN (
   SELECT   SUM(ts.LaborAmount + ISNULL(f.FringeCost, 0))
   FROM     TimeSheets ts
            LEFT JOIN (SELECT   TsKey,
                                SUM(FringeCost) FringeCost
                       FROM     Fringe
                       GROUP BY TsKey) f ON ts.TsKey = f.TsKey
   WHERE    ts.JobNumber = @JobNumber 
     )
END

Open in new window

0
 
LVL 75

Expert Comment

by:Anthony Perkins
ID: 35063539
Sharath_123,

My apologies, as you can see I did try, unfortunately it seems the author overlooked my request.

Feel free to object.

Anthony
0
 
LVL 6

Author Comment

by:AkAlan
ID: 35070776
Ace, I just realized what happened here. I will try and rectify it. I thought the second post was you with a cleaner solution than your first.
0
 
LVL 40

Expert Comment

by:Sharath
ID: 35071490
acperkins -  Not an issue. :) Expected a split, but that's ok.
0

Featured Post

PRTG Network Monitor: Intuitive Network Monitoring

Network Monitoring is essential to ensure that computer systems and network devices are running. Use PRTG to monitor LANs, servers, websites, applications and devices, bandwidth, virtual environments, remote systems, IoT, and many more. PRTG is easy to set up & use.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

If you have heard of RFC822 date formats, they can be quite a challenge in SQL Server. RFC822 is an Internet standard format for email message headers, including all dates within those headers. The RFC822 protocols are available in detail at:   ht…
Ever needed a SQL 2008 Database replicated/mirrored/log shipped on another server but you can't take the downtime inflicted by initial snapshot or disconnect while T-logs are restored or mirror applied? You can use SQL Server Initialize from Backup…
Email security requires an ever evolving service that stays up to date with counter-evolving threats. The Email Laundry perform Research and Development to ensure their email security service evolves faster than cyber criminals. We apply our Threat…
Nobody understands Phishing better than an anti-spam company. That’s why we are providing Phishing Awareness Training to our customers. According to a report by Verizon, only 3% of targeted users report malicious emails to management. With compan…

840 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question