Solved

Syntax help with SQL Function

Posted on 2011-03-06
6
347 Views
Last Modified: 2012-05-11
I have a funtion with one parameter that returns a sum of all wages paid for a particular job from a table called TimeSheets. I use this funtion in a stored procedure but now I find I need fringe costs (Union Dues) also. For every row of wages there are four lines of fringe costs in another related table that I need to include as part of the total wages.

Here is the function I use to return labor costs against a job:

ALTER FUNCTION [dbo].[fn_LaborCosts]
               (@JobNumber char(5))
RETURNS MONEY
AS
  BEGIN
  DECLARE @TotalAmount money
  SELECT @TotalAmount = (SELECT sum(ts.LaborAmount)
  FROM      TimeSheets      ts
            
  WHERE ts.JobNumber = @JobNumber)
                        
  RETURN @TotalAmount

Here is how I use it in the Stored procedure:

ALTER PROCEDURE [dbo].[spSelectJobs]
AS
SELECT      
      JobNumber,
      JobDescription,
      ProposalPrice,
      dbo.fn_LaborCosts(j.JobNumber) AS TotalLabor
                        
FROM   dbo.Jobs   j

The PK for the Fringe table is TsKey so for every row in the TimeSheets table there are four rows in the Fringe table with the TsKey. I need to add up all the fringe costs and add them to the total labor costs and I am not sure how to accomplish this. Thanks for any help on this.
0
Comment
Question by:AkAlan
  • 2
  • 2
6 Comments
 
LVL 40

Accepted Solution

by:
Sharath earned 250 total points
ID: 35050113
Alter the function like this.
ALTER FUNCTION [dbo].[FN_LABORCOSTS] 
              (@JobNumber CHAR(5)) 
RETURNS MONEY 
AS 
  BEGIN 
    DECLARE  @TotalAmount MONEY 
     
    SELECT @TotalAmount = SUM(ts.LaborAmount + ISNULL(f.FringeCost,0)) 
      FROM TimeSheets ts 
           LEFT JOIN (  SELECT TsKey, 
                          SUM(FringeCost) FringeCost 
                     FROM Fringe 
                 GROUP BY TsKey) f 
             ON ts.TsKey = f.TsKey 
     WHERE ts.JobNumber = @JobNumber 
     
    RETURN @TotalAmount 
  END

Open in new window

0
 
LVL 75

Assisted Solution

by:Anthony Perkins
Anthony Perkins earned 250 total points
ID: 35052154
Or just simply (no points please):
ALTER FUNCTION [dbo].[FN_LABORCOSTS] (@JobNumber CHAR(5))

RETURNS MONEY

AS

BEGIN 
     
RETURN (
   SELECT   SUM(ts.LaborAmount + ISNULL(f.FringeCost, 0))
   FROM     TimeSheets ts
            LEFT JOIN (SELECT   TsKey,
                                SUM(FringeCost) FringeCost
                       FROM     Fringe
                       GROUP BY TsKey) f ON ts.TsKey = f.TsKey
   WHERE    ts.JobNumber = @JobNumber 
     )
END

Open in new window

0
 
LVL 75

Expert Comment

by:Anthony Perkins
ID: 35063539
Sharath_123,

My apologies, as you can see I did try, unfortunately it seems the author overlooked my request.

Feel free to object.

Anthony
0
 
LVL 6

Author Comment

by:AkAlan
ID: 35070776
Ace, I just realized what happened here. I will try and rectify it. I thought the second post was you with a cleaner solution than your first.
0
 
LVL 40

Expert Comment

by:Sharath
ID: 35071490
acperkins -  Not an issue. :) Expected a split, but that's ok.
0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Long way back, we had to take help from third party tools in order to encrypt and decrypt data.  Gradually Microsoft understood the need for this feature and started to implement it by building functionality into SQL Server. Finally, with SQL 2008, …
SQL Server engine let you use a Windows account or a SQL Server account to connect to a SQL Server instance. This can be configured immediatly during the SQL Server installation or after in the Server Authentication section in the Server properties …
Along with being a a promotional video for my three-day Annielytics Dashboard Seminor, this Micro Tutorial is an intro to Google Analytics API data.
Internet Business Fax to Email Made Easy - With eFax Corporate (http://www.enterprise.efax.com), you'll receive a dedicated online fax number, which is used the same way as a typical analog fax number. You'll receive secure faxes in your email, fr…

920 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

16 Experts available now in Live!

Get 1:1 Help Now