asked on There is already an open DataReader associated with this Command which must be closed first.
I receivr the following error when executing this code:
There is already an open DataReader associated with this Command which must be closed first.
Code:
String sConnectionString = "Provider=Microsoft.ACE.OL
"Data Source=" + Server.MapPath("file.xlsx"
"Extended Properties=Excel 12.0";
DbProviderFactory factory = DbProviderFactories.GetFac
SqlConnection sqlConnectionString = new SqlConnection("Data Source=server;Initial Catalog=database;Persist Security Info=True;MultipleActiveRe
sqlConnectionString.Open()
SqlCommand cmd = new SqlCommand();
try
{
using (DbConnection connection = factory.CreateConnection()
{
connection.ConnectionStrin
using (DbCommand command = connection.CreateCommand()
{
command.CommandText = "SELECT [col1],[col2] FROM [Sheet1$]";
connection.Open();
using (DbDataReader dr = command.ExecuteReader())
{
int lineItems = 0;
while (dr.Read())
{
string strItemNum = dr["col1"].ToString().Trim
string strPart = dr["col2"].ToString().Trim
cmd.CommandText = "INSERT INTO table1 VALUES (@ProjectID, @VersionID)";
cmd.Parameters.Add("@Proje
cmd.Parameters["@ProjectID
cmd.Parameters.Add("@Versi
cmd.Parameters["@VersionID
cmd.CommandType = CommandType.Text;
cmd.Connection = sqlConnectionString;
cmd.ExecuteReader();
}
dr.Close();
}
}
connection.Close();
}
}
catch (Exception ex)
{
Response.Write(ex.Message)
}
sqlConnectionString.Close(
There is already an open DataReader associated with this Command which must be closed first.
Code:
String sConnectionString = "Provider=Microsoft.ACE.OL
"Data Source=" + Server.MapPath("file.xlsx"
"Extended Properties=Excel 12.0";
DbProviderFactory factory = DbProviderFactories.GetFac
SqlConnection sqlConnectionString = new SqlConnection("Data Source=server;Initial Catalog=database;Persist Security Info=True;MultipleActiveRe
sqlConnectionString.Open()
SqlCommand cmd = new SqlCommand();
try
{
using (DbConnection connection = factory.CreateConnection()
{
connection.ConnectionStrin
using (DbCommand command = connection.CreateCommand()
{
command.CommandText = "SELECT [col1],[col2] FROM [Sheet1$]";
connection.Open();
using (DbDataReader dr = command.ExecuteReader())
{
int lineItems = 0;
while (dr.Read())
{
string strItemNum = dr["col1"].ToString().Trim
string strPart = dr["col2"].ToString().Trim
cmd.CommandText = "INSERT INTO table1 VALUES (@ProjectID, @VersionID)";
cmd.Parameters.Add("@Proje
cmd.Parameters["@ProjectID
cmd.Parameters.Add("@Versi
cmd.Parameters["@VersionID
cmd.CommandType = CommandType.Text;
cmd.Connection = sqlConnectionString;
cmd.ExecuteReader();
}
dr.Close();
}
}
connection.Close();
}
}
catch (Exception ex)
{
Response.Write(ex.Message)
}
sqlConnectionString.Close(
.NET ProgrammingC#ASP.NET
Last Comment
Dirk Haest
ASKER CERTIFIED SOLUTION
Log in or sign up to see answer
Become an EE member today7-DAY FREE TRIAL
Members can start a 7-Day Free trial then enjoy unlimited access to the platform
or
Learn why we charge membership fees
We get it - no one likes a content blocker. Take one extra minute and find out why we block content.
Not exactly the question you had in mind?
Sign up for an EE membership and get your own personalized solution. With an EE membership, you can ask unlimited troubleshooting, research, or opinion questions.
ask a question
Might be because you are repeatedly adding the connection to the command (you are also repeatedly adding parameters which will also make it fallover with parameter already exists) can you try this:
Another tip is to check the state of a connection before you open/close it i.e.:
in your case we know it won't be open because it has only just been created but good practise in other scenarios.
HTH
Gav
String sConnectionString = "Provider=Microsoft.ACE.OLEDB.12.0;" +
"Data Source=" + Server.MapPath("file.xlsx") + ";" +
"Extended Properties=Excel 12.0";
DbProviderFactory factory = DbProviderFactories.GetFactory("System.Data.OleDb");
SqlConnection sqlConnectionString = new SqlConnection("Data Source=server;Initial Catalog=database;Persist Security Info=True;MultipleActiveResultSets=True;User ID=user;Password=password");
sqlConnectionString.Open();
SqlCommand cmd = new SqlCommand(sqlConnectionString);
cmd.CommandType = CommandType.Text;
cmd.CommandText = "INSERT INTO table1 VALUES (@ProjectID, @VersionID)";
cmd.Parameters.Add("@ProjectID", SqlDbType.NVarChar);
cmd.Parameters.Add("@VersionID", SqlDbType.NVarChar);
try
{
using (DbConnection connection = factory.CreateConnection())
{
connection.ConnectionString = sConnectionString;
using (DbCommand command = connection.CreateCommand())
{
command.CommandText = "SELECT [col1],[col2] FROM [Sheet1$]";
connection.Open();
using (DbDataReader dr = command.ExecuteReader())
{
int lineItems = 0;
while (dr.Read())
{
string strItemNum = dr["col1"].ToString().Trim();
string strPart = dr["col2"].ToString().Trim();
cmd.Parameters["@ProjectID"].Value = ProjectDropDown.SelectedValue;
cmd.Parameters["@VersionID"].Value = Label3.Text;
cmd.ExecuteNonQuery();
}
dr.Close();
}
}
connection.Close();
}
}
catch (Exception ex)
{
Response.Write(ex.Message);
}
sqlConnectionString.Close();
Another tip is to check the state of a connection before you open/close it i.e.:
if (sqlConnectionString.State == ConnectionState.Closed)
sqlConnectionString.Open();
in your case we know it won't be open because it has only just been created but good practise in other scenarios.
HTH
Gav
Another remark: when you use the using-statement, you don't have to close your connection (this will be done)
http://www.hanselman.com/blog/WhyTheUsingStatementIsBetterThanASharpStickInTheEyeAndASqlConnectionRefactoringExample.aspx
http://www.hanselman.com/blog/WhyTheUsingStatementIsBetterThanASharpStickInTheEyeAndASqlConnectionRefactoringExample.aspx
Experts Exchange has (a) saved my job multiple times, (b) saved me hours, days, and even weeks of work, and often (c) makes me look like a superhero! This place is MAGIC!
Walt Forbes
Open in new window