Solved

GPO WINS Script Not Working #2

Posted on 2011-03-09
12
683 Views
Last Modified: 2013-11-25
Alright, this is a continuation of my original question, here http://www.experts-exchange.com/Programming/Languages/Visual_Basic/VB_Script/Q_26865173.html

Now, the script will set the WINS and the DNS.  I want the script to see if the values are set first.  If they are, leave it alone.  Since this script will be run every time the computer starts, I don't want to make any undue changes.

So, I've added some if statements.  The first If statement for the WINS works fine but, the second for the DNS is failing.

I have included a screenshot.  What is happening in debug, as you can see is, the DNSSearchServerOrder is null but, the if statement is not returning true.

Second, when it gets to the second if statement, the script abruptly stops. This is most likly becuase it is out of bounds as the array is null.  I have also tried with Len() and that fails as well.

Notice the debug window at the bottom.  Property 17 is for the objNIC.  It is an array and the value is null.  Why would the script say that it is not null?

Am I missing something like initializing my own array and setting it with the one off the nic to perform operations against?

Totally lost here.

Here is the current script:

On Error Resume Next

Const STR_NEWDNS1 = "10.0.1.35" 
Const STR_NEWDNS2 = ""
Const STR_NEWWINS1= "10.0.1.35" 
Const STR_NEWWINS2= ""

SetDnsWins "."		

Sub SetDnsWins( strServer )
	strWinMgmt = "winmgmts:{impersonationLevel=impersonate}!//"& strServer &""
	Set objNICs = GetObject( strWinMgmt ).InstancesOf( "Win32_NetworkAdapterConfiguration" )

	For Each objNIC In objNICs
		If objNIC.IPEnabled Then
			'winsprimary = objNIC.WINSPrimaryServer
			If Not objNIC.WINSPrimaryServer = "10.0.1.35" Then
				objNIC.SetWINSServer STR_NEWWINS1,STR_NEWWINS2
			End If
			If objNIC.DNSServerSearchOrder = null Then
				objNIC.SetDNSServerSearchOrder Array(STR_NEWDNS1)
			End If
			If Not objNIC.DNSServerSearchOrder(0) = "10.0.1.35" Then
				objNIC.SetDNSServerSearchOrder Array(STR_NEWDNS1)
			End If
		End If
	Next

End Sub

Open in new window


SetWINS.vbs Debug
0
Comment
Question by:cefranklin
  • 7
  • 5
12 Comments
 
LVL 51

Expert Comment

by:Netman66
ID: 35093897
In line 20 try changing the value "null" to "Null".

VB is weird sometimes with case.

0
 
LVL 2

Author Comment

by:cefranklin
ID: 35095111
Did that no go
0
 
LVL 51

Expert Comment

by:Netman66
ID: 35095151
If you replace Null with " ", does it change anything?

0
 
LVL 2

Author Comment

by:cefranklin
ID: 35095958
That doesn't work either.  The script ends abruptly like the second part when I try to access an array that is null.
0
 
LVL 2

Author Comment

by:cefranklin
ID: 35095978
I am just doing at the command prompt cscript /X SetWINS.vbs then selecting a debugger and running through it.  Will try taking off the On Error Resume Next and see what happens.
0
 
LVL 2

Author Comment

by:cefranklin
ID: 35096004
Microsoft VBScript runtime error: Type mismatch when using the " " to compare...
and same thing when comparing to Null
0
3 Use Cases for Connected Systems

Our Dev teams are like yours. They’re continually cranking out code for new features/bugs fixes, testing, deploying, testing some more, responding to production monitoring events and more. It’s complex. So, we thought you’d like to see what’s working for us.

 
LVL 51

Expert Comment

by:Netman66
ID: 35096035
RobSampson is the defacto man here.  I'm hoping he steps in.

Since the whole script isn't there, I can't run it up here.

0
 
LVL 51

Expert Comment

by:Netman66
ID: 35096044
What about removing the space - ""?

As I don't have time to build up the missing section above your snippet, I can't test it here to see what gives.

0
 
LVL 2

Author Comment

by:cefranklin
ID: 35096071
There is no missing section, that is the whole script heh.  Maybe I am approaching this wrong.  Instead of comparing to null and it says it is not, I am thinking if I say Not null and see what happens.
0
 
LVL 2

Author Comment

by:cefranklin
ID: 35096570
Tried removing the space in " " and that is a type mismatch as well.
0
 
LVL 51

Accepted Solution

by:
Netman66 earned 500 total points
ID: 35097594
Ok, I think I've got it.

Change line 20 to this:

If IsNull(objNIC.DNSServerSearchOrder) Then


Let me know
0
 
LVL 2

Author Closing Comment

by:cefranklin
ID: 35098349
That worked, thanks so much!
0

Featured Post

3 Use Cases for Connected Systems

Our Dev teams are like yours. They’re continually cranking out code for new features/bugs fixes, testing, deploying, testing some more, responding to production monitoring events and more. It’s complex. So, we thought you’d like to see what’s working for us.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

I hope you'll find this tutorial useful and interesting. So let's try to extend Tcl with a new package.  For anyone more deeply interested please check out the book "Practical Programming in Tcl and Tk". It's really one of the best written books abo…
If you need to start windows update installation remotely or as a scheduled task you will find this very helpful.
Learn the basics of while and for loops in Python.  while loops are used for testing while, or until, a condition is met: The structure of a while loop is as follows:     while <condition>:         do something         repeate: The break statement m…
This tutorial will teach you the core code needed to finalize the addition of a watermark to your image. The viewer will use a small PHP class to learn and create a watermark.

919 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

22 Experts available now in Live!

Get 1:1 Help Now