Go Premium for a chance to win a PS4. Enter to Win

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 699
  • Last Modified:

GPO WINS Script Not Working #2

Alright, this is a continuation of my original question, here http://www.experts-exchange.com/Programming/Languages/Visual_Basic/VB_Script/Q_26865173.html

Now, the script will set the WINS and the DNS.  I want the script to see if the values are set first.  If they are, leave it alone.  Since this script will be run every time the computer starts, I don't want to make any undue changes.

So, I've added some if statements.  The first If statement for the WINS works fine but, the second for the DNS is failing.

I have included a screenshot.  What is happening in debug, as you can see is, the DNSSearchServerOrder is null but, the if statement is not returning true.

Second, when it gets to the second if statement, the script abruptly stops. This is most likly becuase it is out of bounds as the array is null.  I have also tried with Len() and that fails as well.

Notice the debug window at the bottom.  Property 17 is for the objNIC.  It is an array and the value is null.  Why would the script say that it is not null?

Am I missing something like initializing my own array and setting it with the one off the nic to perform operations against?

Totally lost here.

Here is the current script:

On Error Resume Next

Const STR_NEWDNS1 = "10.0.1.35" 
Const STR_NEWDNS2 = ""
Const STR_NEWWINS1= "10.0.1.35" 
Const STR_NEWWINS2= ""

SetDnsWins "."		

Sub SetDnsWins( strServer )
	strWinMgmt = "winmgmts:{impersonationLevel=impersonate}!//"& strServer &""
	Set objNICs = GetObject( strWinMgmt ).InstancesOf( "Win32_NetworkAdapterConfiguration" )

	For Each objNIC In objNICs
		If objNIC.IPEnabled Then
			'winsprimary = objNIC.WINSPrimaryServer
			If Not objNIC.WINSPrimaryServer = "10.0.1.35" Then
				objNIC.SetWINSServer STR_NEWWINS1,STR_NEWWINS2
			End If
			If objNIC.DNSServerSearchOrder = null Then
				objNIC.SetDNSServerSearchOrder Array(STR_NEWDNS1)
			End If
			If Not objNIC.DNSServerSearchOrder(0) = "10.0.1.35" Then
				objNIC.SetDNSServerSearchOrder Array(STR_NEWDNS1)
			End If
		End If
	Next

End Sub

Open in new window


SetWINS.vbs Debug
0
cefranklin
Asked:
cefranklin
  • 7
  • 5
1 Solution
 
Netman66Commented:
In line 20 try changing the value "null" to "Null".

VB is weird sometimes with case.

0
 
cefranklinAuthor Commented:
Did that no go
0
 
Netman66Commented:
If you replace Null with " ", does it change anything?

0
Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
cefranklinAuthor Commented:
That doesn't work either.  The script ends abruptly like the second part when I try to access an array that is null.
0
 
cefranklinAuthor Commented:
I am just doing at the command prompt cscript /X SetWINS.vbs then selecting a debugger and running through it.  Will try taking off the On Error Resume Next and see what happens.
0
 
cefranklinAuthor Commented:
Microsoft VBScript runtime error: Type mismatch when using the " " to compare...
and same thing when comparing to Null
0
 
Netman66Commented:
RobSampson is the defacto man here.  I'm hoping he steps in.

Since the whole script isn't there, I can't run it up here.

0
 
Netman66Commented:
What about removing the space - ""?

As I don't have time to build up the missing section above your snippet, I can't test it here to see what gives.

0
 
cefranklinAuthor Commented:
There is no missing section, that is the whole script heh.  Maybe I am approaching this wrong.  Instead of comparing to null and it says it is not, I am thinking if I say Not null and see what happens.
0
 
cefranklinAuthor Commented:
Tried removing the space in " " and that is a type mismatch as well.
0
 
Netman66Commented:
Ok, I think I've got it.

Change line 20 to this:

If IsNull(objNIC.DNSServerSearchOrder) Then


Let me know
0
 
cefranklinAuthor Commented:
That worked, thanks so much!
0

Featured Post

Keep up with what's happening at Experts Exchange!

Sign up to receive Decoded, a new monthly digest with product updates, feature release info, continuing education opportunities, and more.

  • 7
  • 5
Tackle projects and never again get stuck behind a technical roadblock.
Join Now