• Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 592
  • Last Modified:

Correct Syntax for SQL statement

I am trying to put a stored procedure in my code in VBA , but for some reason I can't figure the proper syntax to return the value.
I am able to get the result when I run in SQL but I can' t run it in my VBA code.

this is what I have in my sql server query:
DECLARE @I_sCompanyID smallint, @O_mNoteIndex numeric(19,5), @O_iErrorState int;
select @I_sCompanyID = CMPANYID from DYNAMICS..SY01500 where INTERID = 'TEST4';
exec DYNAMICS.[dbo].[smGetNextNoteIndex] @I_sCompanyID, 1, @O_mNoteIndex output,
@O_iErrorState output; SELECT @O_mNoteIndex

and my vba code is below , but when I try to get my value , it always return 1 instead of
711.00000

what am I missing?

thanks
David
Private Sub ButSave_Click()
Dim intReturn As Integer

    'Retrieve an ADO Connection for the current user
    Set cn = UserInfoGet.CreateADOConnection
    'Set the current Database company
    cn.DefaultDatabase = UserInfoGet.IntercompanyID
    cmd.ActiveConnection = cn

'Get next note id and then insert batch record
strsql = "DECLARE @I_sCompanyID smallint, @O_mNoteIndex numeric(19,5), @O_iErrorState int; " & _
         "select @I_sCompanyID = CMPANYID from DYNAMICS..SY01500 where INTERID = 'TEST4'; " & _
         "exec DYNAMICS.[dbo].[smGetNextNoteIndex] @I_sCompanyID, 1, @O_mNoteIndex output, " & _
         "@O_iErrorState output; SELECT @O_mNoteIndex"

cmd.CommandText = strsql
cmd.Execute intReturn
MsgBox (intReturn)





End Sub

Open in new window

SQLScript.JPG
0
taverny
Asked:
taverny
  • 5
  • 3
1 Solution
 
Daniel ReynoldsSoftware Applications Developer / IntegratorCommented:
Why not just call the stored procedure?

strsql = "exec myStoredProcedure 'param1','param2'"
 
0
 
tavernyAuthor Commented:
i thought that was what I was doing ,
I am actually trying to follow the info from an other question that I have open , and one expert told me to do it this way.
it seems to work in SQL but I guess I don't know how to store the value returned from this SQL statment
here is the original post:
http://www.experts-exchange.com/Microsoft/Applications/Microsoft_Dynamics/Q_26843202.html
0
 
tavernyAuthor Commented:
can someone help me on getting the value back from the sql statment?
0
Free Tool: Site Down Detector

Helpful to verify reports of your own downtime, or to double check a downed website you are trying to access.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

 
judgekingCommented:
I've attached an example of how I call a SP and get the output.  Basically, you have to define the SP parms, and whether it's an input or output.

But using your code above, you may be able to get the result by changing the code to this:

'(change the last bit of your SQL to SELECT @O_mNoteIndex AS NoteIndex
Dim oRs 'returned recordset

Set oRs = cmd.Execute(intReturn) 'intReturn only tells us how many rows were affected
On error resume next
MsgBox oRs(0) 'Not sure if index starts at 0 or 1
MsgBox oRs(1) 'Not sure if index starts at 0 or 1
MsgBox oRs("NoteIndex") 'May be able to use the output name if you make the change above


Const adCmdStoredProc   = 4
  Const adParamInput      = 1
  Const adParamOutput     = 2
  Const adInteger         = 3
  Const adDate            = 7
  Const adVarChar         = 200

  Set oCommand = CreateObject("ADODB.Command")
  
  oCommand.ActiveConnection = Conn
  oCommand.CommandTimeout = 600
  oCommand.CommandType = adCmdStoredProc
  oCommand.CommandText = "spAddReprintTransaction"
  oCommand.Parameters.Append oCommand.CreateParameter("@EntryID", adInteger, adParamInput, , EntryID)
  oCommand.Parameters.Append oCommand.CreateParameter("@DistribType", adVarChar, adParamInput, 50, DistribType)
  oCommand.Parameters.Append oCommand.CreateParameter("@FaxNumber", adVarChar, adParamInput, 50, FaxNumber)
  oCommand.Parameters.Append oCommand.CreateParameter("@UserName", adVarChar, adParamInput, 50, UserName)
  oCommand.Parameters.Append oCommand.CreateParameter("@FailureID", adInteger, adParamInput, , FailureID)
  oCommand.Parameters.Append oCommand.CreateParameter("@TransID", adInteger, adParamOutput)
  oCommand.Execute
  lTransID = oCommand.Parameters("@TransID")

Open in new window

0
 
tavernyAuthor Commented:
Thank you for your reponse . I am gonna try that now.
0
 
tavernyAuthor Commented:
at the same time that you reponded another expert also responded to my other questions. I will post his answer in here.
but since you seem to understand very well stored procedure , may be you can explain me a little more your code so I can try to do it on my own the next time it happens again.
this is what I understand so far if I look at your code:
line 1 thru 6 create constant with the value specified on the right
line 8 thru 11  we create a connection to the server

then that's where I am not following , line 12 13 , I am not sure if it is a defined name or it is a stored procedure.
then the following append the new constant to the stored procedure, how do you know what the stored procedure expect from the code.

thanks for your helpl, but I am very new to store procedure
0
 
judgekingCommented:
Yes, spAddReprintTransaction is the name of a SP in my DB.  The next lines set up the parms for the SP (with values if input parms), with TransID being an output parm, that's how I retrieve the value on line 21.  When calling any SP, you have to know what parms it expects and what types of values they are (int, char, datetime, etc) or else the call will fail.

The code below might work for you, but you need to find out the name of the second parm, I've just put the name @Flag for now:
Const adCmdStoredProc   = 4
  Const adParamInput      = 1
  Const adParamOutput     = 2
  Const adSmallInt        = 2
  Const adInteger         = 3
  Const adDate            = 7
  Const adVarChar         = 200
  Const adNumeric         = 131

  Dim oCommand
  Dim iCompanyID, iNoteIndex
  
  Set oCommand = CreateObject("ADODB.Command")  
  Set oRs = cn.Execute("select CMPANYID from DYNAMICS..SY01500 where INTERID = 'TEST4'")
  iCompanyID = oRs("CMPANYID")
  oCommand.ActiveConnection = cn
  oCommand.CommandTimeout = 600
  oCommand.CommandType = adCmdStoredProc
  oCommand.CommandText = "smGetNextNoteIndex"
  oCommand.Parameters.Append oCommand.CreateParameter("@I_sCompanyID", adSmallInt, adParamInput, , iCompanyID)
  oCommand.Parameters.Append oCommand.CreateParameter("@Flag", adInteger, adParamInput, , 1)
  oCommand.Parameters.Append oCommand.CreateParameter("@O_mNoteIndex", adNumeric, adParamOutput)
  oCommand.Parameters.Append oCommand.CreateParameter("@O_iErrorState", adInteger, adParamOutput)
  oCommand.Execute
  iNoteIndex = oCommand.Parameters("@O_mNoteIndex")

Open in new window

0
 
tavernyAuthor Commented:
Thanks for the response.
I will probably need your help in the near future regarding stored procedure , but thanks for your help already.
0
 
judgekingCommented:
No problem, thanks for the 'accept'.  
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Keep up with what's happening at Experts Exchange!

Sign up to receive Decoded, a new monthly digest with product updates, feature release info, continuing education opportunities, and more.

  • 5
  • 3
Tackle projects and never again get stuck behind a technical roadblock.
Join Now