Broken down into practical pointers and step-by-step instructions, the IT Service Excellence Tool Kit delivers expert advice for technology solution providers. Get your free copy now.
Single quote ! (Again)
My audit trail in Access contains the line below.
It works fine until there is an single quote in the BuildStr and then it fails.
How do I amend the "BuildStr=" code below to cater for the single quote.
Syntax error (missing operator) in query expression ''** Address1 Changed From: 17 Main Street , NewYork To: 17 Main Street , NewYork O'Brien
(Note the surname O'Brien has a single quote)
It works fine until there is an single quote in the BuildStr and then it fails.
How do I amend the "BuildStr=" code below to cater for the single quote.
Syntax error (missing operator) in query expression ''** Address1 Changed From: 17 Main Street , NewYork To: 17 Main Street , NewYork O'Brien
(Note the surname O'Brien has a single quote)
BuildStr = "** " & ccont.Name & " Changed From: " & ccont.OldValue & " To: " & ccont.Value & Chr(13) & Chr(10
Who is Participating?
Actually this line is probably the cause of my error.
It crashes when the is a single quote in my string (e.g. the name O'Brien)
CurrentDb.Execute "insert into [tblAuditlog] (Auditstr,auditDate) values ( '" & AuditDetails & "',#" & Now() & " #)"
It crashes when the is a single quote in my string (e.g. the name O'Brien)
CurrentDb.Execute "insert into [tblAuditlog] (Auditstr,auditDate) values ( '" & AuditDetails & "',#" & Now() & " #)"
BuildStr = "** " & ccont.Name & " Changed From: " & ccont.OldValue & " To: " & chr(34) & ccont.Value & chr(34) & Chr(13) & Chr(10
try
CurrentDb.Execute "insert into [tblAuditlog] (Auditstr,auditDate) values (" & Chr(34) & AuditDetails & chr(34) & ",#" & Now() & " #)"
CurrentDb.Execute "insert into [tblAuditlog] (Auditstr,auditDate) values (" & Chr(34) & AuditDetails & chr(34) & ",#" & Now() & " #)"
Or just wrap Your input with Replace(auditdetails,"'","
Doubling up the single quotes is what I've found to work well
Doubling up the single quotes is what I've found to work well
You original code is fine except that you need to "escape" all single quotes in the input string before you construct the command string.
Single quotes embedded in a value need to be escaped by doubling them (two single quotes in a row means one single quote).
I think this can best be done with the replace function. Before using it in the line you're having trouble with, create a temp variable from AuditDetails by changing all single quotes ' into two single quotes '' and use that variable in your command string.
Unless you escape (double) your single quotes, the final command string, no matter how it is constructed, will not be valid.
Single quotes embedded in a value need to be escaped by doubling them (two single quotes in a row means one single quote).
I think this can best be done with the replace function. Before using it in the line you're having trouble with, create a temp variable from AuditDetails by changing all single quotes ' into two single quotes '' and use that variable in your command string.
Unless you escape (double) your single quotes, the final command string, no matter how it is constructed, will not be valid.
"It works fine until there is an single quote in the BuildStr and then it fails."
Exactly. Why is why ... contrary to popular belief ... Singe Quotes are problematic when used in Access criteria expressions - for exactly that reason. Use the Chr(34) ... Double Quote ... as shown above ... to wrap Text values.
mx
Exactly. Why is why ... contrary to popular belief ... Singe Quotes are problematic when used in Access criteria expressions - for exactly that reason. Use the Chr(34) ... Double Quote ... as shown above ... to wrap Text values.
mx
Chr(34) works fine for single quotes but shifts the problem to embedded double quotes which will still cause a parse error.
Handling single quotes but not double quotes may be fine for this application, in which case go with the Chr(34) approach as it is more efficient.
If you want to be able to have either single or double quotes in the string without failing, then one or the other of them will need to be escaped (doubled).
Handling single quotes but not double quotes may be fine for this application, in which case go with the Chr(34) approach as it is more efficient.
If you want to be able to have either single or double quotes in the string without failing, then one or the other of them will need to be escaped (doubled).
Thanks all.
(I do find it amazing that the Microsofts of theis world have not found a better way to handle this matter!)
(I do find it amazing that the Microsofts of theis world have not found a better way to handle this matter!)
Question has a verified solution.
Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.
Have a better answer? Share it in a comment.
All Courses
From novice to tech pro — start learning today.
Can you elaborate on this? I've used the Replace method for many years and have not had trouble with criteria expressions, as long as I escape the single quote.