Solved

invalid column name using sp_msforeachdb

Posted on 2011-03-12
14
1,359 Views
Last Modified: 2012-05-11
Hi
I'm having a problem with sp_msforeachdb throwing an error "Invalid column name 'USERCREATED'."
For the purpose of example, I've stripped back what I'm actually trying to achieve to this:

execute sp_msforeachdb 'if ((''?'' LIKE ''%CoLive'') or (''?'' LIKE ''%CoData''))
BEGIN
USE [?]
print ''?''
select ''?'' AS DBNAME,USERID,USERCREATED FROM USERS
END
'
Running this in SSMS the Results tab includes all three columns for both databases that match the LIKE selection. In the Messages tab I get the aforementioned error.

Thanks
ResultsTabs.png
MessagesTab.png
0
Comment
Question by:JeremyLloyd
  • 8
  • 6
14 Comments
 
LVL 14

Expert Comment

by:Daniel_PL
ID: 35116142
Try this approach:

execute sp_msforeachdb '
USE [?]
IF ((DB_NAME() LIKE ''%CoLive'') OR (DB_NAME() LIKE ''%CoData''))
BEGIN
PRINT ''?''
SELECT ''?'' AS DBNAME,USERID,USERCREATED FROM USERS
END
'

Open in new window

0
 

Author Comment

by:JeremyLloyd
ID: 35116238
Sorry, no, it still doesn't work. I also tried replacing the other instances of '?' with DB_NAME()
0
 

Author Comment

by:JeremyLloyd
ID: 35116276
Here's 2 interesting things.

1. Without the USERCREATED column the query runs fine (note ONLY the DemoDataV90CoData and DemoDataV90CoLive databases are ever listed)

2. I have a MSRS database "ReportServer". This happens to have a Users table and a UserId column. I took the database offline and the query ran without errors.

There are plenty of other databases loaded and they don't have a Users table at all.
0
Enterprise Mobility and BYOD For Dummies

Like “For Dummies” books, you can read this in whatever order you choose and learn about mobility and BYOD; and how to put a competitive mobile infrastructure in place. Developed for SMBs and large enterprises alike, you will find helpful use cases, planning, and implementation.

 
LVL 14

Expert Comment

by:Daniel_PL
ID: 35116280
What is the result set of following query?
USE DemoDataV90CoLive
SELECT * FROM sys.columns
where [object_id] = OBJECT_ID('USERS')

Open in new window

0
 

Author Comment

by:JeremyLloyd
ID: 35116292
0
 
LVL 14

Expert Comment

by:Daniel_PL
ID: 35116311
Sorry, my mistake. I put wrong code, 'cose of my wife ;)
Try this:

execute sp_msforeachdb '
USE ?
IF EXISTS (SELECT * FROM sys.columns
where [object_id] = OBJECT_ID(''USERS''))
BEGIN
SELECT DB_NAME(),* FROM sys.columns
where [object_id] = OBJECT_ID(''USERS'') AND name LIKE ''USERCREATED''
END
ELSE
PRINT CAST (DB_NAME() AS VARCHAR(100))+'' Has no such an object'''

Open in new window

0
 

Author Comment

by:JeremyLloyd
ID: 35116334
Messages:
master Has no such an object
tempdb Has no such an object
model Has no such an object
msdb Has no such an object
DemoDataV90CoSpool Has no such an object
DemoDataV90CoDocs Has no such an object
ReportServerTempDB Has no such an object
WebDAVSQLStorage Has no such an object
DemoDataV90CoForms Has no such an object
WebTestLog Has no such an object
DatabaseStats Has no such an object

Missing databases are:
DemoDataV90CoLive
DemoDataV90CoData
ReportServer
dbwithcolumn.png
0
 

Author Comment

by:JeremyLloyd
ID: 35116372
I've tried adding a Users table to another database with a mixture of column names, and it seems there's an error message for each column in the query which doesn't exist in the Users table. If there is no Users table there are no errors.

But, the whole point of the LIKE filter is to skip irrelevant databases. Even if the LIKE wasn't working properly one would expect to see every database name in the output - which one doesn't.

This is just nuts!!!
0
 
LVL 14

Expert Comment

by:Daniel_PL
ID: 35116394
Ok, try this:
execute sp_msforeachdb '
USE [?]
IF ((DB_NAME() LIKE ''%CoLive'' OR DB_NAME() LIKE ''%CoData'') AND DB_NAME() NOT LIKE ''%ReportServer%'')
BEGIN
PRINT ''?''
SELECT ''?'' AS DBNAME,USERID,USERCREATED FROM USERS
END
'

Open in new window

0
 

Author Comment

by:JeremyLloyd
ID: 35116400
Same problem. Messages are:
DemoDataV90CoLive
Msg 207, Level 16, State 1, Line 6
Invalid column name 'USERCREATED'.
DemoDataV90CoData
0
 
LVL 14

Accepted Solution

by:
Daniel_PL earned 500 total points
ID: 35120319
This one should fix your problem ;)

DECLARE @cmd1 VARCHAR(500)
SET @cmd1='IF (''?'' LIKE ''%CoLive'' OR ''?'' LIKE ''%CoData'') EXECUTE (''USE ? SELECT DB_NAME() AS DBNAME, USERID, USERCREATED FROM USERS'')'
EXEC sp_msforeachdb @command1=@cmd1

Open in new window

0
 

Author Comment

by:JeremyLloyd
ID: 35123138
That worked, but why?
0
 

Author Comment

by:JeremyLloyd
ID: 35123145
Sorry, clicked, to quickly... Thanks for solving that. I wouldn't have figured that one out myself. What is it that's different that makes it work? Why didn't it work any way?

Thanks again
Jeremy
0
 
LVL 14

Expert Comment

by:Daniel_PL
ID: 35123275
If any of databases has users table whole query was evaluated regardless of if clause.
This approach eliminates this evaluation.

Take care,
Daniel
0

Featured Post

Efficient way to get backups off site to Azure

This user guide provides instructions on how to deploy and configure both a StoneFly Scale Out NAS Enterprise Cloud Drive virtual machine and Veeam Cloud Connect in the Microsoft Azure Cloud.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

by Mark Wills Attending one of Rob Farley's seminars the other day, I heard the phrase "The Accidental DBA" and fell in love with it. It got me thinking about the plight of the newcomer to SQL Server...  So if you are the accidental DBA, or, simp…
Ever needed a SQL 2008 Database replicated/mirrored/log shipped on another server but you can't take the downtime inflicted by initial snapshot or disconnect while T-logs are restored or mirror applied? You can use SQL Server Initialize from Backup…
Internet Business Fax to Email Made Easy - With eFax Corporate (http://www.enterprise.efax.com), you'll receive a dedicated online fax number, which is used the same way as a typical analog fax number. You'll receive secure faxes in your email, fr…
Microsoft Active Directory, the widely used IT infrastructure, is known for its high risk of credential theft. The best way to test your Active Directory’s vulnerabilities to pass-the-ticket, pass-the-hash, privilege escalation, and malware attacks …

816 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

12 Experts available now in Live!

Get 1:1 Help Now