Solved

Why is the date not added to the saved folder in the attached code?

Posted on 2011-03-16
31
417 Views
Last Modified: 2012-05-11
I would like to back up the contents of a folder "eDIGSNEW"  into a folder named "eDIGS" on the "F:" drive
with current date and time to be added to the folder each day it is saved.
The attached code runs but does not add the date and time to the folder. How should this code be modified so that the current date is added to the "eDIGSNEW" folder everytime it is saved. Thanks
@echo off
:: variables
set drive=F:\Backup
set folder=%date:~10,4%_%date:~4,2%_%date:~7,2%
set backupcmd=xcopy /s /c /d /e /h /i /r /y

%backupcmd% "C:\shared$\eDIGSNEW" "%drive%\eDIGS"

echo Backup Complete!
@pause

Open in new window

0
Comment
Question by:PDSWSS
  • 16
  • 15
31 Comments
 
LVL 33

Expert Comment

by:knightEknight
ID: 35148775
@echo off
:: variables
set drive=F:\Backup
set folder=%date:~10,4%_%date:~4,2%_%date:~7,2%
set backupcmd=xcopy /s /c /d /e /h /i /r /y

md "%drive%\eDIGS_%folder%"

%backupcmd% "C:\shared$\eDIGSNEW" "%drive%\eDIGS_%folder%"

echo Backup Complete!
@pause
0
 
LVL 33

Expert Comment

by:knightEknight
ID: 35148792
oops, i put the date on the wrong folder:

@echo off
:: variables
set drive=F:\Backup
set folder=%date:~10,4%_%date:~4,2%_%date:~7,2%
set backupcmd=xcopy /s /c /d /e /h /i /r /y

md  "C:\shared$\eDIGSNEW_%folder%"

%backupcmd% "C:\shared$\eDIGSNEW_%folder%" "%drive%\eDIGS"

echo Backup Complete!
@pause
0
 
LVL 33

Expert Comment

by:knightEknight
ID: 35149024
actually, the first one may have been right after all -- I'm confused by your last sentence: "...the current date is added to the "eDIGSNEW" folder" - I think you mean the eDIGS folder instead, correct?

I'm adding an echo statement for clarity:

@echo off
::variables
set drive=F:\Backup
set folder=eDIGS_%date:~10,4%_%date:~4,2%_%date:~7,2%
set backupcmd=xcopy/s/c/d/e/h/i/r/y

md "%drive%\%folder%"

@echo %backupcmd%  "C:\shared$\eDIGSNEW"  "%drive%\%folder%"
%backupcmd%  "C:\shared$\eDIGSNEW"  "%drive%\%folder%"

echo Backup Complete!
@pause
0
 

Author Comment

by:PDSWSS
ID: 35149235
Yes. That was a mistake. The date should appear on the "eDIGS" folder. Thanks
0
 
LVL 33

Expert Comment

by:knightEknight
ID: 35149275
Note that I added eDIGS to the folder variable in my most recent post:  
set folder=eDIGS_%date:~10,4%_%date:~4,2%_%date:~7,2%
0
 

Author Comment

by:PDSWSS
ID: 35149297
What is the meaning of /s /c /d /e /h /i /r /y?  Thanks
0
 

Author Comment

by:PDSWSS
ID: 35149420
Tested your code. Did not add date to the eDIGS Folder.
See error message. I had another folder in the Backup Folder = eDIGS3.15.11

It says the folder it is attempting to create already exists and then creates an eDIGS folder without the date.
Picture-3.png
0
 
LVL 33

Accepted Solution

by:
knightEknight earned 500 total points
ID: 35149449
From the error message, I think you are using the wrong post (the one where I was confused about the target).  Use this one instead:

@echo off
::variables
set drive=F:\Backup
set folder=eDIGS_%date:~10,4%_%date:~4,2%_%date:~7,2%
set backupcmd=xcopy/s/c/d/e/h/i/r/y

md "%drive%\%folder%"

@echo %backupcmd%  "C:\shared$\eDIGSNEW"  "%drive%\%folder%"
%backupcmd%  "C:\shared$\eDIGSNEW"  "%drive%\%folder%"

echo Backup Complete!
@pause
0
 
LVL 33

Expert Comment

by:knightEknight
ID: 35149471
To see the meaning of the XCOPY options, do this at a command prompt:

xcopy /?
0
 

Author Comment

by:PDSWSS
ID: 35149491
What is the meaning of these letters    /s /c /d /e /h /i /r /y?
0
 

Author Comment

by:PDSWSS
ID: 35149652
Used your latest code exactly and got exactly the same result =   F:\BAckup\eDIGS

NO DATE is added to the end of the eDIGS folder.  
0
 
LVL 33

Expert Comment

by:knightEknight
ID: 35149664
please run this at a command prompt and post the result here:


set folder=eDIGS_%date:~10,4%_%date:~4,2%_%date:~7,2%
echo %folder%
0
 

Author Comment

by:PDSWSS
ID: 35149722
C:\Users\Administrator>

0
 
LVL 33

Expert Comment

by:knightEknight
ID: 35149762
now post the result of this command:

date/t
0
 

Author Comment

by:PDSWSS
ID: 35149879
see attached
Picture-4.png
0
Why You Should Analyze Threat Actor TTPs

After years of analyzing threat actor behavior, it’s become clear that at any given time there are specific tactics, techniques, and procedures (TTPs) that are particularly prevalent. By analyzing and understanding these TTPs, you can dramatically enhance your security program.

 

Author Comment

by:PDSWSS
ID: 35150630
Any ideas about the issue here?
0
 
LVL 33

Expert Comment

by:knightEknight
ID: 35150693
you used the wrong slash:  use / instead of \  as in date/t

You will need to press CTRL-C to break out of the date prompt above (if it is still like that).
0
 
LVL 33

Expert Comment

by:knightEknight
ID: 35150712
also, in addition to date/t please re-run the following and paste another screenshot as you did above:

set folder=eDIGS_%date:~10,4%_%date:~4,2%_%date:~7,2%
echo %folder%
0
 

Author Comment

by:PDSWSS
ID: 35151101
Screen shot attached. Thanks
Picture-4.png
0
 
LVL 33

Expert Comment

by:knightEknight
ID: 35151220
this is two separate commands:

first run:
set folder=eDIGS_%date:~10,4%_%date:~4,2%_%date:~7,2%

THEN run:
echo %folder%
0
 

Author Comment

by:PDSWSS
ID: 35151312
Screen shot attached -
Picture-2.png
0
 
LVL 33

Expert Comment

by:knightEknight
ID: 35151414
That is the expected result.  Do me a favor and cut-n-paste this into a separate batch file and show the result here.  It won't do anything, it just echos the commands.


@echo off
setlocal

::variables
set drive=F:\Backup
set folder=eDIGS_%date:~10,4%_%date:~4,2%_%date:~7,2%
set backupcmd=xcopy/s/c/d/e/h/i/r/y

ECHO md "%drive%\%folder%"

ECHO %backupcmd%  "C:\shared$\eDIGSNEW"  "%drive%\%folder%"
REM  %backupcmd%  "C:\shared$\eDIGSNEW"  "%drive%\%folder%"

REM echo Backup Complete!
REM @pause

Open in new window

0
 

Author Comment

by:PDSWSS
ID: 35151570
I cut and pasted into notepad and saved as a .cmd file. Ran it and it did nothing as you said.  Screen shot of cut and paste is attached. Is that what you are looking for?
Picture-5.png
0
 
LVL 33

Expert Comment

by:knightEknight
ID: 35151586
sorry, i get what you are doing now.  I didn't realize you would be double-clicking it.  (I run .cmd files from a command prompt, but either way works.)

Remove the word "REM" before @pause on the last line -- save it and run it again.
0
 

Author Comment

by:PDSWSS
ID: 35151991
I can not cut and paste into the cmd prompt. Can you?
0
 

Author Comment

by:PDSWSS
ID: 35152055
Screen shot attached. Looks like your code works.
Something I forgot to mention. The first time I ran your code, I got a message that it could not be saved because this file already existed and it displayed eDIGS_2011_03_16 in the message. This is very strange since there never was such a file in the F:\backup folder.  I'm going to create another folder and try saving into a different folder.
Thanks,
Picture-1.png
0
 
LVL 33

Expert Comment

by:knightEknight
ID: 35152132
Actually, you can cut-n-paste to a command prompt by setting the "Quick Edit" option, but don't worry about that now, it isn't important.

The output shows that the script is working as expected -- assuming you are specifying the correct source directory to be backed up.

Let's try a simpler version that doesn't use all the variables (which aren't really necessary)
@echo off
 setlocal

 set today=%date:~10,4%_%date:~4,2%_%date:~7,2%

 if not exist "C:\shared$\eDIGSNEW\*" echo No files exist in "C:\shared$\eDIGSNEW"  & exit/b

 md "F:\Backup\eDIGS_%today%" >nul

 xcopy/s/c/d/e/h/i/r/y  "C:\shared$\eDIGSNEW"  "F:\Backup\eDIGS_%today%"

 echo Backup Complete!
@pause

Open in new window

0
 

Author Comment

by:PDSWSS
ID: 35152166
Tried to email this about 20 minutes ago but EE site was unavailable.  PROBLEM SOLVED.

Looks like I made a mistake and left out two of the "%"  Sorry about that.  Thought I cut and pasted it in but must not have.

If I could, I'd give you more points for the extra effort you put in.  I appreciate your sticking with this.

Have a great day.
0
 

Author Closing Comment

by:PDSWSS
ID: 35152171
Thanks for the extra effort.
Excellent solution+++
0
 

Author Comment

by:PDSWSS
ID: 35152185
I gave you the highest scores and yet they scored it at 7.8 - very good?
Whatever algorithm they use to calculate the score needs to be updated.
Does not reflect the actual process. Thanks again.
0
 
LVL 33

Expert Comment

by:knightEknight
ID: 35152196
no worries, i've never understood the scoring anyway.  :)
0

Featured Post

Control application downtime with dependency maps

Visualize the interdependencies between application components better with Applications Manager's automated application discovery and dependency mapping feature. Resolve performance issues faster by quickly isolating problematic components.

Join & Write a Comment

This article is an update and follow-up of my previous article:   Storage 101: common concepts in the IT enterprise storage This time, I expand on more frequently used storage concepts.
OfficeMate Freezes on login or does not load after login credentials are input.
This tutorial will walk an individual through configuring a drive on a Windows Server 2008 to perform shadow copies in order to quickly recover deleted files and folders. Click on Start and then select Computer to view the available drives on the se…
This tutorial will walk an individual through the process of configuring basic necessities in order to use the 2010 version of Data Protection Manager. These include storage, agents, and protection jobs. Launch Data Protection Manager from the deskt…

744 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

10 Experts available now in Live!

Get 1:1 Help Now