Solved

Open excel file from another excel file using VBA

Posted on 2011-03-17
5
285 Views
Last Modified: 2012-06-21
I need to have a VBA macro stored in a excel workbook that can open up another excel workbook and retrieve values from the 2nd workbook.

Here is the code I have so far. When I run it, I get a run-time error 438 "Object doesn't support this property or method".

Here's my code.

What am I doing wrong?


Sub CreateCsvFile()

Dim intFileNum As Integer
Dim intColNum As Integer
Dim strRec As String
Dim strFileName As String
Dim strDateTime As String
Dim strCell As String
Dim xlApp As Excel.Application
Dim xlWB1 As Excel.Workbook
Set xlApp = New Excel.Application
xlApp.Visible = True
Set xlWB1 = xlApp.Workbooks.Open("c:\data\cadata.xlsx")

strFileName = "C:\DATA\CaData.csv"
Close #intFileNum
intFileNum = FreeFile()
Open strFileName For Output As intFileNum

strDateTime = Date & " " & Time & ",REV30,"
strRec = strDateTime

' Loop thru and get seven day operating history

For intColNum = 4 To 13
    strCell = "C" & intColNum
    strRec = strRec & xlWB1.Range(strCell) & ","
    strCell = "D" & intColNum
    strRec = strRec & xlWB1.Range(strCell) & ","
    strCell = "E" & intColNum
    strRec = strRec & xlWB1.Range(strCell) & ","
    strCell = "F" & intColNum
    strRec = strRec & xlWB1.Range(strCell) & ","
    strCell = "G" & intColNum
    strRec = strRec & xlWB1.Range(strCell) & ","
    strCell = "H" & intColNum
    strRec = strRec & xlWB1.Range(strCell) & ","
    strCell = "I" & intColNum
    strRec = strRec & xlWB1.Range(strCell) & ","
    strCell = "J" & intColNum
    strRec = strRec & xlWB1.Range(strCell) & ","
Next

' Loop thru and get 10 most recent alarms

For intColNum = 4 To 13
    strCell = "O" & intColNum
    strRec = strRec & Range(strCell) & ","
Next

' Loop thru and get cumulative event counters

For intColNum = 18 To 30
    strCell = "G" & intColNum
    strRec = strRec & Range(strCell) & ","
Next

Print #intFileNum, strRec
Close #intFileNum
xlWB1.Close

End Sub
0
Comment
Question by:tremak
  • 3
  • 2
5 Comments
 
LVL 12

Expert Comment

by:telyni19
ID: 35157051
Which line does the code stop on? That is critical to knowing what the problem is.
0
 

Author Comment

by:tremak
ID: 35157145
My bad.

The first occurrence of the following line

strRec = strRec & xlWB1.Range(strCell) & ","
0
 
LVL 12

Accepted Solution

by:
telyni19 earned 500 total points
ID: 35157283
Try this instead of that line in each case:
strRec = strRec & xlWB1.Worksheets(1).Range(strCell) & ","

The Excel object doesn't support directly referencing a Range object, but the worksheet object does.
0
 

Author Closing Comment

by:tremak
ID: 35157346
Worked like a charm.

Thanks for the quick assist.
0
 
LVL 12

Expert Comment

by:telyni19
ID: 35157399
If you don't mind, here are a few other notes on other things I noticed as well:

You don't really need to assign the reference to a variable each time. You could combine it into one line that looks like this and have half as many lines inside your For loops:

strRec = strRec & xlWB1.Range("C" & intColNum) & ","

Also, intColNum seems a bit misleading. If you're referencing the cell by letter and number, then the number is the row number, not the column number. intRowNum would be clearer.

Finally, to improve the efficiency and conciseness of the code, you could use a With statement to reference the sheet rather than stating it each time. The code with all of these shifts and a bit of cleanup is attached.
Sub CreateCsvFile()

Dim intFileNum As Integer
Dim intRowNum As Integer
Dim strRec As String
Dim strFileName As String
Dim strDateTime As String
Dim xlApp As Excel.Application
Dim xlWB1 As Excel.Workbook

Const strFolder As String = "C:\data\"

Set xlApp = New Excel.Application

'Code will run faster when the application is not visible
'xlApp.Visible = True
Set xlWB1 = xlApp.Workbooks.Open(strFolder & "cadata.xlsx")

strFileName = strFolder & "CaData.csv"
Close #intFileNum
intFileNum = FreeFile()
Open strFileName For Output As intFileNum

strDateTime = Date & " " & Time & ",REV30,"
strRec = strDateTime

With xlWB1.Worksheets(1)

' Loop thru and get seven day operating history
For intRowNum = 4 To 13
    strRec = strRec & .Range("C" & intRowNum) & ","
    strRec = strRec & .Range("D" & intRowNum) & ","
    strRec = strRec & .Range("E" & intRowNum) & ","
    strRec = strRec & .Range("F" & intRowNum) & ","
    strRec = strRec & .Range("G" & intRowNum) & ","
    strRec = strRec & .Range("H" & intRowNum) & ","
    strRec = strRec & .Range("I" & intRowNum) & ","
    strRec = strRec & .Range("J" & intRowNum) & ","
Next

' Loop thru and get 10 most recent alarms

For intRowNum = 4 To 13
    strRec = strRec & .Range("O" & intRowNum) & ","
Next

' Loop thru and get cumulative event counters

For intRowNum = 18 To 30
    strRec = strRec & .Range("G" & intRowNum) & ","
Next

End With

Print #intFileNum, strRec
Close #intFileNum
xlWB1.Close

'Release set objects
Set xlWB1 = Nothing
Set xlApp = Nothing
End Sub

Open in new window

0

Featured Post

Is Your Active Directory as Secure as You Think?

More than 75% of all records are compromised because of the loss or theft of a privileged credential. Experts have been exploring Active Directory infrastructure to identify key threats and establish best practices for keeping data safe. Attend this month’s webinar to learn more.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

This article describes some techniques which will make your VBA or Visual Basic Classic code easier to understand and maintain, whether by you, your replacement, or another Experts-Exchange expert.
Freeze panes is an option within all variants of Excel to enable parts of a sheet to remain stationary when the cursor is in another part of the sheet. This is a very useful feature which is overlooked or under used.
This Micro Tutorial will demonstrate on a Mac how to change the sort order for chart legend values and decrpyt the intimidating chart menu.
This Micro Tutorial will demonstrate the scrolling table in Microsoft Excel using the INDEX function.

914 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

14 Experts available now in Live!

Get 1:1 Help Now