Solved

Excel VBA wrong code

Posted on 2011-03-17
16
314 Views
Last Modified: 2012-05-11
Please look at my code.
Option Explicit


Private Sub CommandButton1_Click()
    Dim FullFileName As String
  FullFileName = Application.GetOpenFilename("Excel files (*.xl*),*.xl*", _
    1, "Custom Dialog Title", , False)
    Workbooks.Open FullFileName
    Dim wbOpen As Workbook
    Set wbOpen = Workbooks.Open(FullFileName)
    Dim xSheet As Worksheet
    xSheet = wbOpen.Worksheet 'wrong here
    Dim m As Integer
    Dim n As Integer
    m = xlCellTypeLastRow
    n = xlCellTypeLastCol
    With wbOpen
        Dim X As Long
        Dim Y As Long
        X = xlCellTypeLastRow
        Y = xlCellTypeLastCol
        Dim i As Integer
        Dim j As Integer
        Dim a As Integer
        Dim b As Integer
        For i = 1 To X
              Sheet2.Cells(i, 1) = xSheet(1).Cells(i, 1)
              Sheet2.Cells(i, 2) = xSheet(1).Cells(i, 2)
              Sheet2.Cells(i, 3) = xSheet(1).Cells(i, 3)
              For a = 1 To m
                    If (Sheet1.Cells(a, 3) = xSheet.Cells(i, 1) And Sheet1.Cells(a, 4) = xSheet.Cells(i, 2) And Sheet1.Cells(a, 5) = xSheet.Cells(i, 3)) Then
                        b = a
                    Exit For
                    End If
              Next a
              Sheet2.Cells(i, 4) = Sheet1.Cells(a, 1)
              Sheet2.Cells(i, 5) = Sheet1.Cells(a, 2)
        Next i
    End With
    
    
        
End Sub

Function xlCellTypeLastRow()
    Dim LastRow As Long
    With ActiveSheet
        LastRow = .Range("A1").SpecialCells(xlCellTypeLastCell).Row
    End With
    xlCellTypeLastRow = LastRow
End Function

Function xlCellTypeLastCol()
    Dim LastCol As Long
    With ActiveSheet
        LastCol = .Cells(1, .Columns.Count).End(xlToLeft).Column
    End With
    xlCellTypeLastCol = LastCol
End Function

Open in new window

0
Comment
Question by:zhshqzyc
  • 9
  • 6
16 Comments
 
LVL 29

Expert Comment

by:leonstryker
ID: 35159672
xSheet = wbOpen.Worksheet 'wrong here

change

 xSheet = wbOpen.Worksheet(1)
0
 

Author Comment

by:zhshqzyc
ID: 35159729
Still wrong. The object doesn't support this property of method.
0
 
LVL 41

Expert Comment

by:dlmille
ID: 35159790
dim xSheet as worksheet

set xSheet =wbopen.worksheet.add ' if you're trying to add a new worksheet...
0
 

Author Comment

by:zhshqzyc
ID: 35159860
I have several worksheets. How to add them?
0
 
LVL 41

Expert Comment

by:dlmille
ID: 35159881
Take a couple minutes and articulate what you're trying to do.  The current state of your original question is "what is wrong with my code" so we focused on your syntax error.  Now, you want more help, and I'm glad to do that if you would highlight a few steps that indicate what you're trying to do with the code at a level which I can quickly respond.

Looking forward to your response,

Dave
0
 
LVL 41

Expert Comment

by:dlmille
ID: 35159893
The short answer to your question with no additional consideration is something like:

wbOpen.Worksheet.Add count:=3  ' to add 3 sheets

Dave
0
 
LVL 41

Expert Comment

by:dlmille
ID: 35159912
Here's one more example you might find useful to adopt to your code, if you're just trying to add a number of worksheets....

Sub AddSheets()
Dim mySheets() As Worksheet
Dim numSheetsAdded As Integer

numSheetsAdded = 3
   
    For i = 0 To numSheetsAdded
        ReDim Preserve mySheets(i)
        Set mySheets(i) = Worksheets.Add
    Next i
   

End Sub
0
 

Author Comment

by:zhshqzyc
ID: 35159957
Hi dlmille:

I just steped into the code,I could not go further. I have several sheets. I want to extract data to one sheet and write to the other sheet by some condition.
Option Explicit


Private Sub CommandButton1_Click()
    Dim FullFileName As String
  FullFileName = Application.GetOpenFilename("Excel files (*.xl*),*.xl*", _
    1, "Custom Dialog Title", , False)
    Workbooks.Open FullFileName
    Dim wbOpen As Workbook
    Set wbOpen = Workbooks.Open(FullFileName)
    Dim xSheet1 As Worksheet
    Dim xSheet2 As Worksheet
    xSheet1 = wbOpen.Worksheets.Add
 
    Dim m As Integer
    Dim n As Integer
    m = xlCellTypeLastRow
    n = xlCellTypeLastCol
  '  With wbOpen
        Dim X As Long
        Dim Y As Long
        X = xlCellTypeLastRow
        Y = xlCellTypeLastCol
        Dim i As Integer
        Dim j As Integer
        Dim a As Integer
        Dim b As Integer
        For i = 1 To X
              xSheet1(2).Cells(i, 1) = xSheet1(1).Cells(i, 1)
              xSheet1(2).Cells(i, 2) = xSheet1(1).Cells(i, 2)
              xSheet1(2).Cells(i, 3) = xSheet1(1).Cells(i, 3)
              For a = 1 To m
                    If (Sheet1.Cells(a, 3) = xSheet1(1).Cells(i, 1) And Sheet1.Cells(a, 4) = xSheet1(1).Cells(i, 2) And Sheet1.Cells(a, 5) = xSheet1(1).Cells(i, 3)) Then
                        b = a
                    Exit For
                    End If
              Next a
              xSheet(1).Cells(i, 4) = Sheet1.Cells(a, 1)
              xSheet(1).Cells(i, 5) = Sheet1.Cells(a, 2)
        Next i
   ' End With
    
    
        
End Sub

Function xlCellTypeLastRow()
    Dim LastRow As Long
    With ActiveSheet
        LastRow = .Range("A1").SpecialCells(xlCellTypeLastCell).Row
    End With
    xlCellTypeLastRow = LastRow
End Function

Function xlCellTypeLastCol()
    Dim LastCol As Long
    With ActiveSheet
        LastCol = .Cells(1, .Columns.Count).End(xlToLeft).Column
    End With
    xlCellTypeLastCol = LastCol
End Function

Open in new window

0
IT, Stop Being Called Into Every Meeting

Highfive is so simple that setting up every meeting room takes just minutes and every employee will be able to start or join a call from any room with ease. Never be called into a meeting just to get it started again. This is how video conferencing should work!

 
LVL 41

Expert Comment

by:dlmille
ID: 35160018
So, you're opening a file that has several sheets.  You want to extract data from those sheets into a new sheet that is added at the beginning?
0
 

Author Comment

by:zhshqzyc
ID: 35160045
No, suppose I open a file by FileOpen dialog
FullFileName = Application.GetOpenFilename("Excel files (*.xl*),*.xl*", _
    1, "Custom Dialog Title", , False)

Open in new window

Then in this excel file there are already three sheets. Sheet1 has data, I want to grab dat from sheet1 and write them to sheet2.
0
 
LVL 41

Expert Comment

by:dlmille
ID: 35160058
The Excel file has 3 sheets, let's say their names are Sheet1, Sheet2, and Sheet3 - and all three exist.  Is there data in all three sheets, or just in Sheet1.   Do you really need to add a sheet (e.g., create Sheet4), or just use the blank Sheet2 (is Sheet2 blank)?

Dave
0
 

Author Comment

by:zhshqzyc
ID: 35160076
No, I don't want to add new sheet. Now I just want to use a blank sheet 2. I might misunderstand the add method.
0
 
LVL 41

Expert Comment

by:dlmille
ID: 35160082
ok - give me a second - I'm rewriting your code to patch things up...

Dave
0
 
LVL 41

Expert Comment

by:dlmille
ID: 35160134
Ok - I've not tried to follow the logic as much as try to identify the things you want to identify.

To get a handle to a sheet, there are several ways:

dim mySheet as worksheet
set mysheet = worksheets.add (this creates a new sheet and gives the handle to that sheet as mySheet)

another way...

activeworkbook.sheets(1) <- this is a reference to the Sheet1 sheet using the index of 1
activeworkbook.sheets(2) <- same thing with index of 2, for Sheet2

finally another way...

activeworkbook.sheets("sheetname") <- referencing the sheet using a sheet name

you could assign mySheet to any of these using the

set mySheet = activeworkbook.sheets(1)

or in your example...

set mySheet = myOpen.Sheets(1)

I've attempted to replace your code and you can correct as you understand your logic.  Sheet(1) is the first sheet (default "Sheet1"), and Sheet(2) is the second (default "Sheet2")

See code below:
Option Explicit


Private Sub CommandButton1_Click()
    Dim FullFileName As String
    Dim wbOpen As Workbook
    Dim xSheet1 As Worksheet
    Dim xSheet2 As Worksheet
    
    Dim i As Integer
    Dim j As Integer
    Dim a As Integer
    Dim b As Integer
    Dim X As Long
    Dim Y As Long
    Dim m As Integer
    Dim n As Integer
    
    'Open a worksheet file based on user input
    FullFileName = Application.GetOpenFilename("Excel files (*.xl*),*.xl*", 1, "Custom Dialog Title", , False)
    Workbooks.Open FullFileName
    Set wbOpen = Workbooks.Open(FullFileName) 'workbook has 3 sheets
    

        m = xlCellTypeLastRow
        n = xlCellTypeLastCol


        X = xlCellTypeLastRow
        Y = xlCellTypeLastCol

        For i = 1 To X
              wbOpen.Sheets(2).Cells(i, 1) = wbOpen.Sheets(1).Cells(i, 1)
              wbOpen.Sheets(2).Cells(i, 2) = wbOpen.Sheets(1).Cells(i, 2)
              wbOpen.Sheets(2).Cells(i, 3) = wbOpen.Sheets(1).Cells(i, 3)
              For a = 1 To m
                    If (wbOpen.Sheets(1).Cells(a, 3) = wbOpen.Sheets(2).Cells(i, 1) And wbOpen.Sheets(1).Cells(a, 4) = wbOpen.Sheets(2).Cells(i, 2) And wbOpen.Sheets(1).Cells(a, 5) = wbOpen.Sheets(2).Cells(i, 3)) Then
                        b = a
                    Exit For
                    End If
              Next a
              wbOpen.Sheets(1).Cells(i, 4) = wbOpen.Sheets(2).Cells(a, 1)
              wbOpen.Sheets(1).Cells(i, 5) = wbOpen.Sheets(2).Cells(a, 2)
        Next i
   ' End With
    
    
        
End Sub

Function xlCellTypeLastRow()
    Dim LastRow As Long
    With ActiveSheet
        LastRow = .Range("A1").SpecialCells(xlCellTypeLastCell).Row
    End With
    xlCellTypeLastRow = LastRow
End Function

Function xlCellTypeLastCol()
    Dim LastCol As Long
    With ActiveSheet
        LastCol = .Cells(1, .Columns.Count).End(xlToLeft).Column
    End With
    xlCellTypeLastCol = LastCol
End Function

Open in new window


Does this help?

dave
0
 
LVL 41

Accepted Solution

by:
dlmille earned 500 total points
ID: 35160145
Alternatively, you could have had the:

dim mySheet1 as worksheet, mySheet2 as worksheet

With wbOpen

   set mySheet1 = .sheets(1)
   set mysheet2 = .sheets(2)
end with

and then used mySheet1 and mySheet2 instead of wbOpen.Sheets(1) and wbOpen.Sheets(2)

it would help you in maintenance if you adopt one approach and then use that throughout.  These are just options...

Dave
0
 

Author Comment

by:zhshqzyc
ID: 35160187
The code is running perfectly. Let me just check the logic. Thank you very much.
0

Featured Post

Better Security Awareness With Threat Intelligence

See how one of the leading financial services organizations uses Recorded Future as part of a holistic threat intelligence program to promote security awareness and proactively and efficiently identify threats.

Join & Write a Comment

A little background as to how I came to I design this code: Around 5 years ago I designed an add-in that formatted Excel files to a corporate standard, applying different cell colours and font type depending on whether the cells contained inputs,…
If you need to start windows update installation remotely or as a scheduled task you will find this very helpful.
The view will learn how to download and install SIMTOOLS and FORMLIST into Excel, how to use SIMTOOLS to generate a Monte Carlo simulation of 30 sales calls, and how to calculate the conditional probability based on the results of the Monte Carlo …
This Micro Tutorial will demonstrate the scrolling table in Microsoft Excel using the INDEX function.

746 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

13 Experts available now in Live!

Get 1:1 Help Now