Solved

How to modify VB Script to check file existence?

Posted on 2011-03-18
6
465 Views
Last Modified: 2012-05-11
Hi,

can you help me to adjust my VB script? I need to search the script that exists in the %TEMP% file test.log, and if so, read the contents (this is always one digit), and added that the current file name in parentheses.
Finally, the script must delete the text file test.log.
In the event that no file test.log in the temp directory is not, the script work as now.

Thanks in advance for your great help.

TM
Set objFSO = CreateObject("Scripting.FileSystemObject")
Set objShell = CreateObject("WScript.Shell")
strDesktop = objShell.ExpandEnvironmentStrings("%USERPROFILE%") & "\Desktop"
strUserName = objShell.ExpandEnvironmentStrings("%USERNAME%")
strDestination = "\\S1\tests\2011 A\"
arrExtensions = Array(".pp", "doc", "xls")

If Right(strDesktop, 1) <> "\" Then strDesktop = strDesktop & "\"
If Right(strDestination, 1) <> "\" Then strDestination = strDestination & "\"
For Each objFile In objFSO.GetFolder(strDesktop).Files
	boolCopy = False
	For Each strExt In arrExtensions
		If LCase(Left(Mid(objFile.Name, InStrRev(objFile.Name, ".")), Len(strExt))) = LCase(strExt) Then boolCopy = True
	Next
	If boolCopy = True Then
      strNewName = strUserName & "_" & objFile.Name
      If objFSO.FileExists(strDestination & strNewName) = True Then objFSO.DeleteFile strDestination & strNewName, True
      objFSO.CopyFile objFile.Path, strDesktop & strNewName, True
      objFSO.MoveFile objFile.Path, strDestination & strNewName
   End If
Next
MsgBox "Your files have been copied to " & strDestination

Open in new window

0
Comment
Question by:Thomas_Meyer
  • 3
  • 3
6 Comments
 
LVL 12

Expert Comment

by:prashanthd
ID: 35165622
Still not clear with the requirements,

What is location of temp file?
What do you mean by add that the current file name in parentheses?

It would be good if you can give an example
0
 

Author Comment

by:Thomas_Meyer
ID: 35165934
Okay, I'll try to explain it further:

In the System folder "%Temp%" I have a text file test.log.
At this moment, my script works by renaming an existing file on your desktop user name (system variable "%USERNAME%") and I need to make the newly renamed file added more digits of the test.log file (if file exists).
The result might look like this:
The script renames the file on your desktop: Thomas.Meyer(2). pptx
0
 
LVL 12

Expert Comment

by:prashanthd
ID: 35175075
Try the following...

regards
Prashanth
Set objFSO = CreateObject("Scripting.FileSystemObject")
Set objShell = CreateObject("WScript.Shell")
strDesktop = objShell.ExpandEnvironmentStrings("%USERPROFILE%") & "\Desktop\test"
strUserName = objShell.ExpandEnvironmentStrings("%USERNAME%")
strtempfile=objShell.ExpandEnvironmentStrings("%temp%")&"\test.log"
strDestination = "\\S1\tests\2011 A\"
arrExtensions = Array(".pp", "doc", "xls")

tempnum=""
If objfso.FileExists(strtempfile) Then
    Set tempfile=objfso.OpenTextFile(strtempfile,1)
    tempnum=Trim(tempfile.ReadLine)
    tempfile.close
    strNewName = strUserName & "_" & Replace(objFile.Name,".","("&tempnum&").")
End If

If Right(strDesktop, 1) <> "\" Then strDesktop = strDesktop & "\"
If Right(strDestination, 1) <> "\" Then strDestination = strDestination & "\"
For Each objFile In objFSO.GetFolder(strDesktop).Files
    boolCopy = False
    For Each strExt In arrExtensions
        If LCase(Left(Mid(objFile.Name, InStrRev(objFile.Name, ".")), Len(strExt))) = LCase(strExt) Then 
            boolCopy = True
        End If
    Next
    If boolCopy = True Then
        
        If Len(tempnum)>0 Then
            Set tempfile=objfso.OpenTextFile(strtempfile,1)
            tempnum=Trim(tempfile.ReadLine)
            strNewName = strUserName & "_" & Replace(objFile.Name,".","("&tempnum&").")
        Else
            strNewName = strUserName & "_" & objFile.Name
        End If
        If objFSO.FileExists(strDestination & strNewName) = True Then 
            objFSO.DeleteFile strDestination & strNewName, True
            objFSO.CopyFile objFile.Path, strDesktop & strNewName, True
            objFSO.MoveFile objFile.Path, strDestination & strNewName
        End If
    End If
Next
MsgBox "Your files have been copied to " & strDestination

Open in new window

0
Active Directory Webinar

We all know we need to protect and secure our privileges, but where to start? Join Experts Exchange and ManageEngine on Tuesday, April 11, 2017 10:00 AM PDT to learn how to track and secure privileged users in Active Directory.

 

Author Comment

by:Thomas_Meyer
ID: 35175260
Hi,
I wrote a script error in that line (see below) and error: Object required: 'objFile'

strNewName = strUserName & "_" & Replace(objFile.Name,".","("&TempNum&").")

Regards,
TM
0
 
LVL 12

Accepted Solution

by:
prashanthd earned 500 total points
ID: 35175311
Delete line no 14 and try

regards
Prashanth
0
 

Author Closing Comment

by:Thomas_Meyer
ID: 35175380
It helped that it works as it should!
I give thanks and evaluation.
Regards
TM
0

Featured Post

Announcing the Most Valuable Experts of 2016

MVEs are more concerned with the satisfaction of those they help than with the considerable points they can earn. They are the types of people you feel privileged to call colleagues. Join us in honoring this amazing group of Experts.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

You can of course define an array to hold data that is of a particular type like an array of Strings to hold customer names or an array of Doubles to hold customer sales, but what do you do if you want to coordinate that data? This article describes…
If you need to start windows update installation remotely or as a scheduled task you will find this very helpful.
Show developers how to use a criteria form to limit the data that appears on an Access report. It is a common requirement that users can specify the criteria for a report at runtime. The easiest way to accomplish this is using a criteria form that a…
This lesson covers basic error handling code in Microsoft Excel using VBA. This is the first lesson in a 3-part series that uses code to loop through an Excel spreadsheet in VBA and then fix errors, taking advantage of error handling code. This l…

830 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question