Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people, just like you, are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
Solved

Adding a function to a class

Posted on 2011-03-20
5
307 Views
Last Modified: 2012-05-11
I tried to add a tax function to a class and it seems like it is not working.  here is the function and class below.  Now in the code below, I get the following errors:

      Invalid token 'double' in class, struct, or interface member declaration

and

'MarketingEmail.ShoppingCart.CalculateTax(string)': not all code paths return a value

What could be causing these errors and how do I fix this so that there is no error.  I want to be able to do the code in class so that all I have to do is call the function in my program based on my class.  Thanks!
namespace MarketingEmail
{
    public class ShoppingCart
    {

        private int shoppingcartid;
        private int shoppingcartitemid;
        private int shoppingcartitemcount;
        

        
         function double CalculateTax(string CustomerState)
        {
            double salestax;

            switch(CustomerState)
            {
                   

                case "Alabama":
                    salestax = 4.0;
                    break;

                case "Alaska":
                    salestax = 0.0;
                    break;

                case "Arizona":
                    salestax = 6.6;
                    break;

                case "Arkansas":
                    salestax = 6.0;
                    break;

                case "California":
                    salestax = 8.25;
                    break;

                case "Colorado":
                    salestax = 2.9;
                    break;

                case "Connecticut":
                    goto case "Arkansas";

                case "Delaware":
                    goto case "Alaska";
                    
                case "District of Columbia":
                    goto case "Arkansas";

                case "Florida":
                    goto case "Arkansas";

                case "Georgia":
                    goto case "Alabama";                    

                case "Hawaii":
                    goto case "Alabama";

                case "Idaho":
                    goto case "Arkansas";

                case "Illinois":
                    salestax = 6.25;
                    break;

                case "Indiana":
                    salestax = 7.0;
                    break;

                case "Iowa":
                    goto case "Arkansas";

                case "Kansas":
                    salestax = 5.3;
                    break;

                case "Kentucky":
                    goto case "Arkansas";
                    
                case "Louisiana":
                    goto case "Alabama";

                case "Maine":
                    salestax = 5.0;
                    break;

                case "Maryland":
                    goto case "Arkansas";

                case "Massachusetts":
                    salestax = 6.25;
                    break;

                case "Michigan":
                    goto case "Arkansas";

                case "Minnesota":
                    salestax = 6.875;
                    break;

                case "Mississippi":
                    goto case "Indiana";

                case "Missouri":
                    salestax = 4.225;
                    break;

                case "Montana":
                    goto case "Alaska";

                case "Nebraska":
                    salestax = 7.7;
                    break;

                case "Nevada":
                    salestax = 6.85;
                    break;

                case "New Hampshire":
                    goto case "Alaska";

                case "New Jersey":
                    goto case "Indiana";

                case "New Mexico":
                    salestax = 5.125;
                    break;                    

                case "NJ":
                    salestax = 7.0;
                    break;
            }

            return salestax;
        }

    }
}

Open in new window

0
Comment
Question by:VBBRett
5 Comments
 
LVL 11

Expert Comment

by:epichero22
ID: 35176490
What line is the first error on?
0
 
LVL 33

Accepted Solution

by:
Todd Gerbert earned 250 total points
ID: 35176560
Method's (or functions) in C# don't use the "Function" keyword, that's strictly a VB thing.

No:
function double CalculateTax(string CustomerState)
{
    ...
}

Open in new window


Yes:
double CalculateTax(string CustomerState)
{
    ...
}

Open in new window


Also, the C# compiler doesn't like it when you try and use a variable that never had anything assigned to it.
So, given:
double salestax;

switch(CustomerState)
{
    case "Alabama":
        salestax = 4.0;
        break;
}

return salestax;

Open in new window


It's possible, if "CustomerState" doesn't match any of the "case" statements that salestax will never have anything assigned to it, so the compiler gives you an error.  You can solve that by assigning a value to salestax when you declare it:
double salestax = 0;

switch(CustomerState)
{
    case "Alabama":
        salestax = 4.0;
        break;
}

return salestax;

Open in new window


Or by using a "default" case, which will be executed in the event no other case matches (which is probably a good idea anyway, will give you a chance to throw an exception or return a value indicating an error in case CustomerState isn't valid):
double salestax = 0;

switch(CustomerState)
{
	case "Alabama":
		salestax = 4.0;
		break;

    case "Alaska":
        salestax = 0.0;
        break;
	default:
		throw new Exception("Invalid CustomerState.");
}

return salestax;

Open in new window

0
 
LVL 29

Assisted Solution

by:anarki_jimbel
anarki_jimbel earned 250 total points
ID: 35177033
What about the second error - you need some default case. Like tgerbert pointed out. But probably, you may not want to rise an exception if some wrong state string is passed. Some other options are possible.

E.g., you always return 0 if no such state.
Or, you return negative value (probably, not the nicest solution but some people do so).
3. Or, you may add some boolean out parameter, like 'out canGetTaxForState.

And so on.

I'd also initialize the return velue at the beginning of a function  - in C#, unlike VB, values are not initialized by default.
0
 

Author Comment

by:VBBRett
ID: 35177410
OK, it appears that the not all code paths return a value is line 21 and it is the following line of code:

double CalculateTax(string CustomerState)
0
 
LVL 33

Expert Comment

by:Todd Gerbert
ID: 35177455
I didn't get that error when I copy & paste your code, just the two matters I pointed out. Can you re post your code as it is now?
0

Featured Post

Free Tool: Port Scanner

Check which ports are open to the outside world. Helps make sure that your firewall rules are working as intended.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

This article is for Object-Oriented Programming (OOP) beginners. An Interface contains declarations of events, indexers, methods and/or properties. Any class which implements the Interface should provide the concrete implementation for each Inter…
Performance in games development is paramount: every microsecond counts to be able to do everything in less than 33ms (aiming at 16ms). C# foreach statement is one of the worst performance killers, and here I explain why.
Established in 1997, Technology Architects has become one of the most reputable technology solutions companies in the country. TA have been providing businesses with cost effective state-of-the-art solutions and unparalleled service that is designed…
Email security requires an ever evolving service that stays up to date with counter-evolving threats. The Email Laundry perform Research and Development to ensure their email security service evolves faster than cyber criminals. We apply our Threat…

856 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question