[Webinar] Learn how to a build a cloud-first strategyRegister Now

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 494
  • Last Modified:

Not selecting the Top 10 from the VBA/SQL Statement

I have some VBA Code that is doing a Select TOP statement, where it takes the TOP number from a number that the user is prompt for on a form.

For some reason, it is selecting all the records not just the TOP 10.

I have included the VBA Code in the Code section.

Can someone please tell me what the issue might be?

Thanks,

gdunn
Private Sub cmdAssign_Click()
Dim db As DAO.Database
Dim qdf As DAO.QueryDef
Dim lngTop As Long
Dim strSQL As String
 
 
Set db = CurrentDb
db.QueryDefs.Delete "qryWorkAssigned"
Set qdf = db.CreateQueryDef("qryWorkAssigned")
lngTop = CLng(InputBox("Enter Amount to Assign"))
strSQL = "SELECT TOP " & lngTop & " numDay, numDay, txtAssignedTo, txtAssignedBy, dtmDateAssigned, numID, txtPmtTyp, txtSuff FROM [qryUnPro] ORDER BY numID"
 
qdf.SQL = strSQL
 
DoCmd.RunSQL "UPDATE qryWorkAssigned SET qryWorkAssigned.txtAssignedBy = [Enter Your User ID], qryWorkAssigned.txtAssignedTo = [Enter User ID Being Assigned], qryWorkAssigned.dtmDateAssigned = [Enter Today's Date]"
 
'Refresh MAPD Form
[Form_frmUnproUnassignedsubform].Requery
 
End Sub

Open in new window

0
gdunn59
Asked:
gdunn59
  • 6
  • 5
  • 3
  • +1
1 Solution
 
Aaron TomoskyTechnology ConsultantCommented:
I think it's because the input is a string so it wraps it in quotes when it just needs a straight number.
0
 
DatabaseMX (Joe Anderson - Microsoft MVP, Access and Data Platform)Commented:
"when it just needs a straight number."
It's converted in the line of code above >> lngTop = CLng(InputBox("Enter Amount to Assign"))

0
 
DatabaseMX (Joe Anderson - Microsoft MVP, Access and Data Platform)Commented:
Have you looked at query qryWorkAssigned once it has been created directly in the query designer and checked how many records are return .... ?
You can do that by commenting out everything after

qdf.SQL = strSQL
 
mx
0
Visualize your virtual and backup environments

Create well-organized and polished visualizations of your virtual and backup environments when planning VMware vSphere, Microsoft Hyper-V or Veeam deployments. It helps you to gain better visibility and valuable business insights.

 
Nick67Commented:
Throw a msgbox right after this line

strSQL = "SELECT TOP " & lngTop & " numDay, numDay, txtAssignedTo, txtAssignedBy, dtmDateAssigned, numID, txtPmtTyp, txtSuff FROM [qryUnPro] ORDER BY numID"

Msgbox strSQL

What is strSQL?  are there quotes or other nonsense in it?

If not, simplify first.
Try the code below.
Sub out the * and start adding in fields.

Something about TOP and Order by is tickling my spider sense, though
Dim db As DAO.Database
Dim rs As Recordset
Dim lngTop As Long
Dim strSQL As String
 
Set db = CurrentDb
lngTop = CLng(InputBox("Enter Amount to Assign"))
strSQL = "SELECT TOP " & lngTop & " *  from qryUnPro;"
Set rs = db.OpenRecordset(strSQL, dbOpenDynaset, dbSeeChanges)
rs.MoveLast
MsgBox rs.RecordCount

Open in new window

0
 
gdunn59Author Commented:
Nick67:

You're correct in saying that something about the Order by is tickling your spider sense.  So before I did anything out, I commented out the Order by clause, and then it worked like a charm.  Go figure!

Is there anyway around this?  So I can still sort?

Thanks,
gdunn59
0
 
gdunn59Author Commented:
Oops, meant to say "before I did anything else", not "out".
0
 
Nick67Commented:
You temptable it

select * from ( "select top x from tblWhatever") order by some column
0
 
Nick67Commented:

"select * from ( ELECT TOP " & lngTop & " numDay, numDay, txtAssignedTo, txtAssignedBy, dtmDateAssigned, numID, txtPmtTyp, txtSuff FROM [qryUnPro] ) as temptable ORDER BY numID"
0
 
Nick67Commented:
Well, you get the idea
0
 
DatabaseMX (Joe Anderson - Microsoft MVP, Access and Data Platform)Commented:
You never answered the question I asked above:

"Have you looked at query qryWorkAssigned once it has been created directly in the query designer and checked how many records are returned .... ?
0
 
gdunn59Author Commented:
DatabaseMX:

Sorry, yes I did and it is not just doing the Top number entered.

Based off of what Nick67 was saying, I commented out the "Order by" clause and it worked like a charm after that.

Thanks,

gdunn59
0
 
DatabaseMX (Joe Anderson - Microsoft MVP, Access and Data Platform)Commented:
Orderby should not affect this.
Are you saying the actual query does the same thing?
0
 
Nick67Commented:
The spidey sense was going.
Order by shouldn't do that..but it does sometimes... I think just in Access, not in sprocs

http://bytes.com/topic/access/answers/678509-select-top-order
http://www.mrexcel.com/forum/showthread.php?t=496073

I've had it happen, I can't remember where, hence the spidey sense.
0
 
DatabaseMX (Joe Anderson - Microsoft MVP, Access and Data Platform)Commented:
".but it does sometimes"
Well ... it works like this - from Help:

"Typically, you use the TopValues property setting together with sorted fields. The field you want to display top values for should be the leftmost field that has the Sort box selected in the query design grid. An ascending sort returns the bottommost records, and a descending sort returns the topmost records. If you specify that a specific number of records be returned, all records with values that match the value in the last record are also returned."

So ... unless you have duplicates in the Field that is being sorted, then you should only get the TOP amount of records - certainly not All.

mx
0
 
Nick67Commented:
Bugs do happen.
And as @gdunn59 noted
"SELECT TOP " & lngTop & " numDay, numDay, txtAssignedTo, txtAssignedBy, dtmDateAssigned, numID, txtPmtTyp, txtSuff FROM [qryUnPro] ORDER BY numID"
returns all the records, not the top X
"SELECT TOP " & lngTop & " numDay, numDay, txtAssignedTo, txtAssignedBy, dtmDateAssigned, numID, txtPmtTyp, txtSuff FROM [qryUnPro]"
returns the top X and not sorted.

Why?

I can't say.
I've had it happen, but it was quite some time ago.
Most times it doesn't matter.
You can force a report or a form to sort regardless of the underlying query's order, so then it doesn't matter.
If your doing recordset work, or combo boxes and list boxes it can be a pain.

But it happens.

It isn't the first bug that's been encountered, and it won't be the last.
FWIW, my backend is now SSEE 2005 -- and I can't replicate the problem anymore.
But I remember having it :)
0
 
Aaron TomoskyTechnology ConsultantCommented:
Try doing a nested select. So select top 10 from (allyourstuff) order by numid
0

Featured Post

Independent Software Vendors: We Want Your Opinion

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

  • 6
  • 5
  • 3
  • +1
Tackle projects and never again get stuck behind a technical roadblock.
Join Now