Solved

Catching errors in system call in Perl?

Posted on 2011-03-22
6
262 Views
Last Modified: 2012-06-27
Is there anything wrong in this code? Especially on line 4 and 11.

          system("java -jar SOMEFILE.java");
          if ($? == -1) {
              #send email 
              sendEmail("$somename1@mywork.com", "somename2@mywork.com", "logging Failed", "failed to execute: $!\n");
          } elsif ($? & 127) {
              printf "child died with signal %d, %s coredump\n",
                ($? & 127),  ($? & 128) ? 'with' : 'without';
              my $signal = ($? & 127);
              my $woCoredump = ($? & 128) ? 'with' : 'without';
              #send email
              sendEmail("$somename1@mywork.com", "somename2@mywork.com", "Logging Failed", "child died with signal $signal, $woCodedump coredump\n");
          } else {
              # Don't do anything because it is a successful system call.
          }

Open in new window



and this is the sendEmail sub function

# Email Function
    #($to, $from, $subject, $message)
    sub sendEmail
      {
          my ($to, $from, $subject, $message) = @_;
          my $sendmail = '/usr/lib/sendmail';
          open(MAIL, "|$sendmail -oi -t");
          print MAIL "From: $from\n";
          print MAIL "To: $to\n";
          print MAIL "Subject: $subject\n\n";
          print MAIL "$message\n";
          close(MAIL);
      }

Open in new window

0
Comment
Question by:Tolgar
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 3
  • 2
6 Comments
 
LVL 15

Accepted Solution

by:
DonConsolio earned 250 total points
ID: 35190083
> sendEmail("$somename1@mywork.com", "somename2@mywork.com", "logging Failed", "failed to execute: $!\n");

omit the "$" before somename1
sendEmail("somename1@mywork.com", "somename2@mywork.com", "logging Failed", "failed to execute: $!\n");
0
 

Author Comment

by:Tolgar
ID: 35191137
Sounds good. So is this rest of my code is right?

I can't run and check it for now that is why I am asking.

Thanks,
0
 
LVL 84

Expert Comment

by:ozo
ID: 35192138
Do you want to backquote the @ or do you want to interpolate an array named @mywork?
0
Technology Partners: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
LVL 84

Expert Comment

by:ozo
ID: 35192150
Or you may want to use q'' instead of qq""
0
 

Author Comment

by:Tolgar
ID: 35192263
I don;t know what you mean by backquote but I want to send email to this email address: somename1@mywork.com

Then should I use \ before @ as the following?

somename1\@mywork.com

Thanks,
0
 
LVL 84

Assisted Solution

by:ozo
ozo earned 250 total points
ID: 35192595

"somename1\@mywork.com"
or
'somename1@mywork.com'
0

Featured Post

Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
perl script help 12 106
Perl passing in variables to do substitution 6 79
Perl Write to Specific line in a file 15 115
Regex rule to match two different url 5 76
I've just discovered very important differences between Windows an Unix formats in Perl,at least 5.xx.. MOST IMPORTANT: Use Unix file format while saving Your script. otherwise it will have ^M s or smth likely weird in the EOL, Then DO NOT use m…
Many time we need to work with multiple files all together. If its windows system then we can use some GUI based editor to accomplish our task. But what if you are on putty or have only CLI(Command Line Interface) as an option to  edit your files. I…
Explain concepts important to validation of email addresses with regular expressions. Applies to most languages/tools that uses regular expressions. Consider email address RFCs: Look at HTML5 form input element (with type=email) regex pattern: T…

733 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question