Cannot delete range names with Excel VBA

I am processing about 75 workbooks from our intranet.  There is one worksheet for each that is going into a summary workbook, which then has a Table of contents Created.  this is done from an Excel application that pulls the workbook, creates the destination workbook and copy/pastes the 75 into the destination, then creates a table of contents.  As the process copies the worksheet into the destination, it creates a named range of the data based on a particular naming convention.  However, at the ends of the process when the destination workbook is completely created, I want to go through and delete all range names that beging with GP.  However, I cannot get it do to this.  I can delete all range names, but I don't want that, I only want to delete particular range names.  HOwever, what I have simply ignores those ranges with GP as the first two letters and I simply cannot understand why.  I tried converting the name to a string for testing, but that did not work either
Sub DeleteNamedRanges(strWbkName As String)
'/******************************************************************************
' Clears out all the unnecessary named ranges in the workbook.  GP is the prefix
' used by the Green Package
' DO NOT USE GP to start range name otherwise it will be DELETED!
'/******************************************************************************
Dim MyName As Name
Dim intText As Integer
Dim strName As String
Workbooks(strWbkName).Activate

    For Each MyName In Names
    If Left(MyName.Name, 2) = "GP" Then
        MyName.Delete
    End If
    Next MyName
End Sub

Open in new window

ssmith94015Asked:
Who is Participating?

Improve company productivity with a Business Account.Sign Up

x
 
SiddharthRoutConnect With a Mentor Commented:
Ok try this

Replace

MyName.Delete

with

Workbooks(strWbkName).Names(MyName.Name).Delete

Sid
0
 
SiddharthRoutCommented:
Try this

For Each MyName In Workbooks(strWbkName).Names

Sid
0
 
FernandoFernandesCommented:
also, you could check if all the sheets are unprotected... these names are defined in a worksheet scope, and protected sheets dont let you delete names from them.

Sid's suggestion is also good, because you'll be forcing Excel to delete the names from that specific destination workbook.
0
The 14th Annual Expert Award Winners

The results are in! Meet the top members of our 2017 Expert Awards. Congratulations to all who qualified!

 
ssmith94015Author Commented:
I change it to the attached, but still does not recognize the range name.
Sub DeleteNamedRanges(strWbkName As String)
'/******************************************************************************
' Clears out all the unnecessary named ranges in the workbook.  GP is the prefix
' used by the Green Package
' DO NOT USE GP to start range name otherwise it will be DELETED!
'/******************************************************************************
Dim MyName As Name
Dim intText As Integer
Dim strName As String
Workbooks(strWbkName).Activate

    For Each MyName In Workbooks(strWbkName).Names
    If Left(MyName.Name, 2) = "GP" Then
        MyName.Delete
    End If
    Next MyName
End Sub

Open in new window

0
 
SiddharthRoutCommented:
Try this

If UCase(Left(Trim(MyName.Name), 2)) = "GP" Then

Sid
0
 
ssmith94015Author Commented:
Still won't work.  However, I did a debug.print  of

Debug.Print "Just MyName: " & MyName
 Debug.Print "MyName and Name: " & MyName.Name

ANd it returned this, so I think it simply is not getting to the GP part of the data
Just MyName: ='SECTOR-SWTACTC'!$A$6:$BQ$51
MyName and Name: 'SECTOR-SWTACTC'!GPData
0
 
SiddharthRoutCommented:
Oh Ok got it....

Give me few moments.

Sid
0
 
SiddharthRoutCommented:
Try this

Sub DeleteNamedRanges(strWbkName As String)
    Dim MyName As Name
    Dim intText As Integer
    Dim strName As String, MyArray() As String
    
    Workbooks(strWbkName).Activate

    For Each MyName In Workbooks(strWbkName).Names
        On Error Resume Next
        MyArray = Split(MyName.Name, "!")
        On Error GoTo 0
        If UCase(Left(Trim(MyArray(1)), 2)) = "GP" Then
            MyName.Delete
        End If
    Next MyName
End Sub

Open in new window


Sid
0
 
SiddharthRoutCommented:
Sorry Use this

Sub DeleteNamedRanges(strWbkName As String)
    Dim MyName As Name
    Dim intText As Integer
    Dim strName As String, MyArray() As String
    
    Workbooks(strWbkName).Activate

    For Each MyName In Workbooks(strWbkName).Names
        On Error Resume Next
        MyArray = Split(MyName.Name, "!")
        If UCase(Left(Trim(MyArray(1)), 2)) = "GP" Then
            MyName.Delete
        End If
        On Error GoTo 0
    Next MyName
End Sub

Open in new window


Sid
0
 
ssmith94015Author Commented:
I have attached a screen shot of some debugging.  It recognizes the GP now, but is not deleting properly Debug Screen
0
 
FernandoFernandesCommented:
If myname.name like '*!GP*' then
myname.delete
End if
0
 
FernandoFernandesCommented:
use quotes not apostrophy
0
 
FernandoFernandesConnect With a Mentor Commented:
This is Sid's code (credit for him, please!)
but I changed somethings based on my experience:
1) never define error treatment inside the loop
2) instead of using array, i removed the array and changed the condition
Sub DeleteNamedRanges(strWbkName As String)
On Error Resume Next
    Dim MyName As Name
    
    Workbooks(strWbkName).Activate

    For Each MyName In Workbooks(strWbkName).Names
        If UCase(Left(Trim(MyName.Name), 2)) like "*!GP*" Then
            MyName.Delete
        End If
    Next MyName
End Sub

Open in new window

0
 
ssmith94015Author Commented:
Sid, it deletes everyting again.  Fernando, tried that, but it did not work either.  I don't think there is a solution.  Either it deletes everything or nothing.
0
 
SiddharthRoutCommented:
Can you upload a sample file?

Sid
0
 
FernandoFernandesCommented:
can you post the resulting file here ???
I want to try some ideas... Sid will also have fun with it...

<email removed by SouthMod>
0
 
SiddharthRoutCommented:
>>>if you prefer to send to email, because of confidentiality, <edit>

FernandoFernandes: I am afraid that is not allowed in EE :(

Sid
0
 
FernandoFernandesCommented:
damn... it's ok ... sorry EE moderator, it won't happen again.
0
 
SiddharthRoutCommented:
FF: I also learnt it the hard way :(

ssmith94015: If you want you can delete all the data from your workbook and then upload it.

Sid
0
 
FernandoFernandesCommented:
smith,
make a copy of your file
run this code in it
and upload it to EE

sub RemoveAllContent()
dim sht as worksheet
application.enableevents=false
application.calculation = xlcalculationmanual
for each sht in activeworkbook
sht.unprotect
sht.cells.clearcontents
next
application.enableevents=true
application.calculation = xlcalculationautomatic
End Sub

Open in new window

0
 
ssmith94015Author Commented:
Actually, I FINALLY GOT IT TO WORK!!!  Sid, a little variation on some ideas you gave me.
Sub DeleteNamedRanges(strWbkName As String)
'/******************************************************************************
' Clears out all the unnecessary named ranges in the workbook.  GP is the prefix
' used by the Green Package
' DO NOT USE GP to start range name otherwise it will be DELETED!
'/******************************************************************************
    Dim MyName As Name
    Dim strMyName As String
    Dim intText As Integer
    Dim intLength As Integer
    Dim strFinalName    As String

    Workbooks(strWbkName).Activate

    For Each MyName In Workbooks(strWbkName).Names
        On Error Resume Next
        strMyName = CStr(MyName.Name)
        intText = InStr(MyName.Name, "!")
        intLength = Len(strMyName)
        strFinalName = Right(strMyName, intLength - intText)
        If Left(strFinalName, 2) = "GP" Then
           Workbooks(strWbkName).Names(strFinalName).Delete
        End If
        On Error GoTo 0
    Next MyName

End Sub

Open in new window

0
 
SiddharthRoutCommented:
Glad it's sorted :)

Sid
0
 
SiddharthRoutCommented:
ssmith94015: I feel FF also worked on this and hence I wouldn't mind sharing points with him :)

Sid
0
 
ssmith94015Author Commented:
Will do.  I will contact moderator and it is very gracious of you.
0
 
SiddharthRoutCommented:
Thanks for understanding :)

Sid
0
 
FernandoFernandesCommented:
Thanks guys !
It's ok with the points, no need to worry about it.
:-)
0
 
ssmith94015Author Commented:
Thank you both again..  This was a real show-stopper.  Sid, you have repeatedly saved my patootee on this project.  Fernando, look forward to more help from you!  This is all done in Excel and I usually program databases out of a server or ACCESS, so have been really challeneged on this and I appreciate the help.  There is still way more to do, so more questions will be coming soon to the EE near you!
0
 
FernandoFernandesCommented:
:-) Thanks a lot SSmith... Looking forward to trying helping you again !
p.s.: I like to be in topics where Sid is, i usually learn something new with him too :-)

Have a good one, and good luck to us all !
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.