Copy data from different workbook

Hi Experts,

I would like to request Experts help. Need to crosscheck data at Listing workbook (Column A) with Master Data workbook (Column A). If the same number exists in column A (Master Data WB), copy data from Column  B to D (Listing WB) at column B to D (Master Data WB) at the row where the number exist.

If the number not available, copy data from column A to D (Listing WB) as new data row at MasterData WB. After copying the data, update cell at Column E (Master Data WB) with “StoreA”. Hope Experts will help me to create this feature. Attached the workbooks for Experts perusal.



Listing.xls
MasterData.xls
CartilloAsked:
Who is Participating?
 
nutschCommented:
I think I get it. It seems I'm missing an err.clear in the code.

Thomas
Sub SendToMaster()
Dim i As Long, lgFoundRow As Long
Dim shtMaster As Worksheet, shtListing As Worksheet, wbkMaster as workbook

Application.ScreenUpdating = False
On Error Resume Next

Set shtListing = ActiveSheet

set wbkMaster = Workbooks("MasterData.xls")

if err<>0 then set wbkMaster =workbooks.open("\\dac0q\File\ Document\Data\MasterData.xls")

if wbkMaster.readonly then
msgbox "MasterData workbook must be opened read-only for data update. Try again later"
exit sub
end if

Set shtMaster = wbkMaster.Sheets("MasterList")

err.clear

With shtListing

    For i = 3 To .Cells(.Rows.Count, 1).End(xlUp).Row
    

            lgFoundRow = Application.WorksheetFunction.Match(.Cells(i, 1), shtMaster.Columns(1), 0)
        
        If Err <> 0 Then
            Err.Clear
            .Rows(i).Copy shtMaster.Cells(Rows.Count, 1).End(xlUp).Offset(1)
            shtMaster.Cells(Rows.Count, 1).End(xlUp).End(xlToRight).Offset(, 1) = "StoreA"
        Else
            .Range(.Cells(i, 2), .Cells(i, 4)).Copy shtMaster.Cells(lgFoundRow, 2)
        End If
        
    Next i
    
End With

wbkmaster.close(true)

Application.ScreenUpdating = True

End Sub

Open in new window

0
 
Saqib Husain, SyedEngineerCommented:
Make a copy of the sheet on the Listing workbook and enter this formula on A3

=IF(ISNA(MATCH(OUT!$A3,'[Copy of MasterData.xls]MasterList'!$A:$A,0)),OUT!A3,VLOOKUP(OUT!$A3,'[Copy of MasterData.xls]MasterList'!$A:$D,COLUMN(),0))

and copy it to column D and down as far as needed.

Enter this formula in column E and copy it down

=IF(ISNA(MATCH(OUT!$A3,'[Copy of MasterData.xls]MasterList'!$A:$A,0)),"","Store A")

You would have to change the file name in the formulas (in [] brackets) to whatever you have.

See attached

Saqib
Copy-of-Listing.xls
Copy-of-MasterData.xls
0
 
CartilloAuthor Commented:
Hi ssaqibh,

Is that possible to convert this in macro?
0
Cloud Class® Course: Certified Penetration Testing

This CPTE Certified Penetration Testing Engineer course covers everything you need to know about becoming a Certified Penetration Testing Engineer. Career Path: Professional roles include Ethical Hackers, Security Consultants, System Administrators, and Chief Security Officers.

 
nutschCommented:
Hi Cartillo,

Here is a code that should do what you need if you launch it from Listing workbook, assuming Master Data is open.

Sub SendToMaster()
Dim i As Long, lgFoundRow As Long
Dim shtMaster As Worksheet, shtListing As Worksheet

Application.ScreenUpdating = False

Set shtListing = ActiveSheet
Set shtMaster = Workbooks("MasterData.xls").Sheets("MasterList")

With shtListing

    For i = 3 To .Cells(.Rows.Count, 1).End(xlUp).Row
    
        On Error Resume Next
            lgFoundRow = Application.WorksheetFunction.Match(.Cells(i, 1), shtMaster.Columns(1), 0)
        
        If Err <> 0 Then
            Err.Clear
            .Rows(i).Copy shtMaster.Cells(Rows.Count, 1).End(xlUp).Offset(1)
            shtMaster.Cells(Rows.Count, 1).End(xlUp).End(xlToRight).Offset(, 1) = "StoreA"
        Else
            .Range(.Cells(i, 2), .Cells(i, 4)).Copy shtMaster.Cells(lgFoundRow, 2)
        End If
        
    Next i
    
End With

Application.ScreenUpdating = True

End Sub

Open in new window


Thomas
0
 
CartilloAuthor Commented:
Hi Thomas,

Thanks for the code.

I’m intent to save the MasterData workbook at this network folder " \\dac0q\File\ Document\Data". Can we copy the Listing data to this network folder path? and if in case the workbook was open at the time we intent to copy the data, the message box will remind the user that the data can't be copied at that point of time. Hope you will consider this request.
0
 
nutschCommented:
Try this then. It will open the workbook if it's not open and exit the sub after warning if the masterdata is read-only.

Thomas
Sub SendToMaster()
Dim i As Long, lgFoundRow As Long
Dim shtMaster As Worksheet, shtListing As Worksheet, wbkMaster as workbook

Application.ScreenUpdating = False
On Error Resume Next

Set shtListing = ActiveSheet

set wbkMaster = Workbooks("MasterData.xls")

if err<>0 then set wbkMaster =workbooks.open("\\dac0q\File\ Document\Data\MasterData.xls")

if wbkMaster.readonly then
msgbox "MasterData workbook must be opened read-only for data update. Try again later"
exit sub
end if

Set shtMaster = wbkMaster .Sheets("MasterList")


With shtListing

    For i = 3 To .Cells(.Rows.Count, 1).End(xlUp).Row
    

            lgFoundRow = Application.WorksheetFunction.Match(.Cells(i, 1), shtMaster.Columns(1), 0)
        
        If Err <> 0 Then
            Err.Clear
            .Rows(i).Copy shtMaster.Cells(Rows.Count, 1).End(xlUp).Offset(1)
            shtMaster.Cells(Rows.Count, 1).End(xlUp).End(xlToRight).Offset(, 1) = "StoreA"
        Else
            .Range(.Cells(i, 2), .Cells(i, 4)).Copy shtMaster.Cells(lgFoundRow, 2)
        End If
        
    Next i
    
End With

Application.ScreenUpdating = True

End Sub

Open in new window

0
 
CartilloAuthor Commented:
Hi Thomas,

Thanks for the revised code. Have checked, new data row was created at MasterData workbook even though the number is already existed at MasterList. Hope you can fix this.
0
 
CartilloAuthor Commented:
Hi Thomas,

Sorry for the wrong update. Actually what happen was,each time I update the workbook (Master Data), row 3 from Listing workbook is copied over as new row at Master Data WB. Hope you can fix this. Can we save and closed the Masterdata WB after updating the workbook?
0
 
nutschCommented:
Sure, try this, with the addition of a save line at the end.

THomas


Sub SendToMaster()
Dim i As Long, lgFoundRow As Long
Dim shtMaster As Worksheet, shtListing As Worksheet, wbkMaster as workbook

Application.ScreenUpdating = False
On Error Resume Next

Set shtListing = ActiveSheet

set wbkMaster = Workbooks("MasterData.xls")

if err<>0 then set wbkMaster =workbooks.open("\\dac0q\File\ Document\Data\MasterData.xls")

if wbkMaster.readonly then
msgbox "MasterData workbook must be opened read-only for data update. Try again later"
exit sub
end if

Set shtMaster = wbkMaster.Sheets("MasterList")


With shtListing

    For i = 3 To .Cells(.Rows.Count, 1).End(xlUp).Row
    

            lgFoundRow = Application.WorksheetFunction.Match(.Cells(i, 1), shtMaster.Columns(1), 0)
        
        If Err <> 0 Then
            Err.Clear
            .Rows(i).Copy shtMaster.Cells(Rows.Count, 1).End(xlUp).Offset(1)
            shtMaster.Cells(Rows.Count, 1).End(xlUp).End(xlToRight).Offset(, 1) = "StoreA"
        Else
            .Range(.Cells(i, 2), .Cells(i, 4)).Copy shtMaster.Cells(lgFoundRow, 2)
        End If
        
    Next i
    
End With

wbkmaster.close(true)

Application.ScreenUpdating = True

End Sub

Open in new window

0
 
CartilloAuthor Commented:
Hi Thomas,

Thanks for the help. Noticed the first data row (row 3) from Listing workbook always copied at Master Data workbook (multiple entry) each update. I have attached the sample for your perusal. Please help.
MasterData.xls
0
 
CartilloAuthor Commented:
Hi Thomas,

Thanks a lot for the superb solution.
0
 
CartilloAuthor Commented:
Hi Thomas,

Hope you can help me with this Q, I'm using your solution but intent to amend it. Hope you will consider:

http://www.experts-exchange.com/Software/Office_Productivity/Office_Suites/MS_Office/Excel/Q_26913230.html
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.