Encoding URL

escape is a local variable that is no longer valid when the function returns. If single threaded, you can do this:
   static char escaped[2000] = {0};

Otherwise, you should define escape from the caller and pass it in as an argument.

Yes, sorry, I left out the main function of the code:

int main()
{
    char *address = "123 #5 M&M Street";
    cout << "address=" << address << endl;
    cout << "address=" << urlencode(address) <<endl;
}

Select allOpen in new window

Does it still crash when adding static?

Why not simply using 'InternetCanonicalizeUrl()' (http://msdn.microsoft.com/en-us/library/aa384342(VS.85).aspx) for that purpose instead of rolling your own solution?

@ phoffric yes it did
@ jkr - because I read that ICU() will not work when the data you're trying to encode is not a valid URL to begin with. I need to URL encode a string, then append it to the URL afterwards. Is there a way to use ICU() to a string that does not contain a URL?

Very good. Glad to be of assistance.

No I mean it still crashed.

sorry for the confusion.

here's the current code:

int main()
{
    char *address = "123 #5 M&M Street";
    cout << "address=" << address << endl;
    cout << "address=" << urlencode(address) <<endl;
}

char *urlencode(char *c)
{
    
    static char escaped[2000] = {0};
	char *buffer;
    int max = strlen(c);
    for(int i=0; i<max; i++)
    {
        if ( (48 <= c[i] && c[i] <= 57) ||//0-9
             (65 <= c[i] && c[i] <= 90) ||//abc...xyz
             (97 <= c[i] && c[i] <= 122) || //ABC...XYZ
             (c[i]=='~' || c[i]=='!' || c[i]=='*' || c[i]=='(' || c[i]==')' || c[i]=='\'')
        )
        {
			
            strncat(escaped, (const char*)c[i],1);
        }
        else
        {

			sprintf(buffer, "%x", c[i]);
            strncat(escaped,"%",2);
            strncat(escaped,buffer,strlen(buffer) );//converts char 255 to string "ff"
        }
    }
    return escaped;
}

Select allOpen in new window

still something wrong with the concatenation I believe

Plain UrlEncode ? http://msdn.microsoft.com/en-us/library/zttxte6w.aspx

>>@ jkr - because I read that ICU() will not work when the data you're trying
>>to encode is not a valid URL to begin with. I need to URL encode a string,
>>then append it to the URL afterwards. Is there a way to use ICU() to a
>>string that does not contain a URL?

Why don't you just build the whole URL with the data you have and pas it to that function afterwards? Since it is to end up as an URL anyway, I'd at leat try that ;o)

hah I guess I was overthinking (or underthinking*) that jkr.

do you have a working example?

char *url = "http://microsoft.com/website/mywebpage/";
	char buffer[50] = {0};
	DWORD sz;
	InternetCanonicalizeUrl(url, buffer, &sz, 0);
	cout << buffer;

Select allOpen in new window

has a blank output?

char *urlencode(char *c)
{

    static char escaped[2000] = {0};
    char *buffer=(char*)malloc(2000);
    escaped[0]='\0';
    int max = strlen(c);
    for(int i=0; i<max; i++)
    {
        if ( (48 <= c[i] && c[i] <= 57) ||//0-9                                             
             (65 <= c[i] && c[i] <= 90) ||//abc...xyz                                       
             (97 <= c[i] && c[i] <= 122) || //ABC...XYZ                                     
             (c[i]=='~' || c[i]=='!' || c[i]=='*' || c[i]=='(' || c[i]==')' || c[i]=='\'')
        )
        {

            strncat(escaped, (const char*)&c[i],1);
        }
        else
        {

            sprintf(buffer, "%x", c[i]);
            strncat(escaped,"%",2);
            strncat(escaped,buffer,strlen(buffer) );//converts char 255 to string "ff"      
        }
    }
    return escaped;
}

Select allOpen in new window

Thank you works perfectly.

Very good. Glad to be of assistance again :)