array : I can't place the space into an array (translation from morse code to letter)


My program translate the sequence given, but the output should be: "SAVE FUN", but instead, it prints:"SAVE                    FUN".

I try to add a space to an array, but it doesn't seem to be working.

Any suggestion would be greatly appreciated.

using namespace std;

int main(){
string code[30];
string word="";
string	sentence =" ... .- ...- . ..-- ..-. ..- -.";

string morseCode[] = {".-", "-...", "-.-.", "-..", ".", "..-.", 
	"--.", "....", "..", ".---", "-.-", ".-..", "--", "-.", "---", 
".--.", "--.-", ".-.", "...", "-", "..-", "...-", ".--", "-..-", 

int n = 0; int m=0;
int i =0;
while(m !=-1)
m = sentence.find(' ', n);
word = sentence.substr( n, m-n);

for(int i=0; i<sizeof(code)/sizeof(code[0]) ;++i)
{string st=code[i];
for(int j=0;j<sizeof(morseCode)/sizeof(morseCode[0]);++j)
if(st == morseCode[j]) word+=char(j+65);
if( st == "..--") (word +=" ");// HERE is my main issue}

cout <<word<<endl;
return 0;}

Open in new window

Who is Participating?

[Product update] Infrastructure Analysis Tool is now available with Business Accounts.Learn More

I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Hi pgmerLA,

the problem is as you already marked the line with 'if ( st == "..--" )' - the problem simply is that when st == '..--' you add 'sizeof(morseCode)/sizeof(morseCode[0])' times a ' ' since this 'if' is within the inner loop - IMO you should move the 'if ( st == "..--" )' to be called before the inner loop starts and in case it's true use add one single ' ' and call 'continue' to skip further evaluation of this word.

Hope that helps,


Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
pgmerLAAuthor Commented:
Thanks a lot!
You're welcome, I'm glad I could help.

Have a nice day,

best regards,

It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today

From novice to tech pro — start learning today.