asked on 8/11/2011

Simple PHP function

I have a bunch of php scripts that need to sanitize integers. It seems inefficient to do this:
$var1 = filter_input(INPUT_GET, 'var1',FILTER_SANITIZE_NUMBER_INT);
$var2 = filter_input(INPUT_GET, 'var2',FILTER_SANITIZE_NUMBER_INT);
$var3 = filter_input(INPUT_GET, 'var3',FILTER_SANITIZE_NUMBER_INT);

I don't want to use classes (I have my reasons). Looking for some quick code to do this efficiently.

PHP Web Development

Last Comment

jeff_zucker

8/16/2011

oleggold

8/11/2011

why don't just have 1 sanitizing var,e.g:
$sanit_var = filter_input(INPUT_GET, 'var1 ',FILTER_SANITIZE_NUMBER_INT);
$var1 = $sanit_var;
$sanit_var = filter_input(INPUT_GET, 'var2 ',FILTER_SANITIZE_NUMBER_INT);
$var2 = $sanit_var;
or even better ,write a tiny return of sanitized value so sanitation only happens on demand ,less code and less memory.

Beverley Portlock

8/11/2011

"Question: I have a bunch of php scripts that need to sanitize integers. It seems inefficient to do this:...."

How do you know it is inefficient? Have you checked the algorithm?

PHP code running in memory is very fast. You will make no noticeable savings from doing this in other ways even if you are checking thousands of integers. Each of these operations takes about 2 microseconds so even if you cut it down by 90% for 100 operations you will save 180 microseconds. Do you think anyone will notice that?

jeff_zucker

8/11/2011

ASKER

I just reread my original post and i don't think I explained it that well. I have a ton of variables, all with different names that need to be sanitized. It seems inefficient to have to copy/paste
$var1 = filter_input(INPUT_GET, 'var1',FILTER_SANITIZE_NUMBER_INT);
Then edit $var1 to be $var2, then edit 'var1' to be 'var2', etc. and to do this hundreds of times for each variable name.

Ideally, I just create an array and feed it to a function. I'm looking for help with writing that function.

Beverley Portlock

8/11/2011

That is indeed a different problem. All they all called something like $var1 $var2 ..... $var981 and so on?

ASKER CERTIFIED SOLUTION

Beverley Portlock

8/11/2011

THIS SOLUTION IS ONLY AVAILABLE TO MEMBERS.

View this solution by signing up for a free trial.

Members can start a 7-Day free trial and enjoy unlimited access to the platform.

See Pricing Options

Start Free Trial

Sandeep Kothari

8/12/2011

why so many times... use a function ...

try this...

function sanitizeInt($data){
$r = filter_var($data,FILTER_SANITIZE_NUMBER_INT);
return $r;
}

Open in new window

Reference for your help : http://www.php.net/manual/en/function.filter-var.php

jeff_zucker

8/15/2011

ASKER

This is what i was looking for.

Sandeep Kothari

8/15/2011

have you tried my solution.... no I am not arguing over points... silly people do that ... I am just saying try that piece of code.... its quite clean and efficient ...

jeff_zucker

8/16/2011

ASKER

kshna: Thanks for your help. I'm sure yours would work too. I had already started to implement the first solution, so I kept going with it. Sorry about that. I'll take a look later to see what is the correct thing to do in this situation where there are multiple good answers.