Solved

Dynamic SQL Error - Incorrect syntax near ')'.

Posted on 2011-09-05
4
824 Views
Last Modified: 2012-05-12
Hi All,

Can anyone suggest why I am receiving the following error within the attached SQL. The error is on the line 4 'SET @query = '..

Error:

Msg 102, Level 15, State 1, Line 4
Incorrect syntax near ')'.

Thanks,

Rit
DECLARE @cols NVARCHAR(2000), @query NVARCHAR(4000)

	SELECT @cols = COALESCE(@cols + ',' + QUOTENAME(Car_Name), QUOTENAME(Car_Name)) FROM lookup_cars ORDER BY Car_Name, OrderSeq

	SET @query = 
	'SELECT *  FROM 
	(
		view_new_cars
	)t

	PIVOT (COUNT(t.CarID) FOR T.Car_Name IN (' + @cols + ')) as PVT'

	EXEC(@query)

Open in new window

0
Comment
Question by:rito1
  • 2
4 Comments
 
LVL 18

Accepted Solution

by:
x-men earned 500 total points
ID: 36484478
use a "print @query" to check it the string is ok
0
 
LVL 1

Author Closing Comment

by:rito1
ID: 36484496
Good thinking! :-)
0
 
LVL 68

Expert Comment

by:Qlemo
ID: 36484823
And the error is? You should post that usually, as the accepted post might have helped, but isn't the solution. In such cases please post the solution, accept it and optionally award assist points to experts' posts.

The error is: You need to cut off the first comma from @cols, and make sure there is always a value, even if the select to construct @cols does not return any rows.
Instead, I would insert a dummy value into the final SQL:
SET @query = 
        'SELECT *  FROM 
        (
                view_new_cars
        )t

        PIVOT (COUNT(t.CarID) FOR T.Car_Name IN ( '''' ' + @cols + ')) as PVT'

Open in new window

0
 
LVL 1

Author Comment

by:rito1
ID: 36487029
Thanks for the advice Qlemo.
0

Featured Post

What Should I Do With This Threat Intelligence?

Are you wondering if you actually need threat intelligence? The answer is yes. We explain the basics for creating useful threat intelligence.

Join & Write a Comment

Composite queries are used to retrieve the results from joining multiple queries after applying any filters. UNION, INTERSECT, MINUS, and UNION ALL are some of the operators used to get certain desired results.​
Ever needed a SQL 2008 Database replicated/mirrored/log shipped on another server but you can't take the downtime inflicted by initial snapshot or disconnect while T-logs are restored or mirror applied? You can use SQL Server Initialize from Backup…
Illustrator's Shape Builder tool will let you combine shapes visually and interactively. This video shows the Mac version, but the tool works the same way in Windows. To follow along with this video, you can draw your own shapes or download the file…
This video gives you a great overview about bandwidth monitoring with SNMP and WMI with our network monitoring solution PRTG Network Monitor (https://www.paessler.com/prtg). If you're looking for how to monitor bandwidth using netflow or packet s…

762 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

21 Experts available now in Live!

Get 1:1 Help Now