SQL Joins - Date Criteria being ignored

Posted on 2011-09-08
Medium Priority
Last Modified: 2012-05-12

I've got a stored procedure that returns data into a form.  This was working well until I was tasked with also adding another table.

I have a main dbAppointments table which has data like this:

appID          fileID          feeusrID         appDate
100             283283      7459               2010-02-06 01:00:00.000
101             285674      7125               2010-05-06 02:00:00.000
102             287444      7459               2010-06-08 02:00:00.000

and I have a secondary table udApptExtraInvite which has data like this:

origAppID    appFeeUsrID
100              7220
101              7459; 7220

I need all appID's and origAppID's that have, for example, 7459 as the dbAppointments.feeusrID or contained within udApptExtraInvite.appFeeUsrID and I need date filtering.  All origAppID's from udApptExtraInvite are viable appID's in dbAppointments.

Note, there are appID's in the dbAppointments table with a feeusrID of 7459 that are not in the udApptExtraInvite table as origAppID.

This is part of the procedure for testing.  My issue is the correct data comes back but when I add the date filter, the script basically is only removing the applicable entries from the udApptExtraInvite table and not filtering anything further.  If I remove "OR AEI.appFeeUsrID like @FEES" the date filtering works correctly.

How do I resolve this?  Any suggestions would be appreciated.

Declare @FEEUSRID as bigint
SET @FEEUSRID = '7459'
Declare @FEES as varchar(50)
set @fees = '%' + convert(varchar, @FEEUSRID) + '%'

SELECT dbo.dbAppointments.*,
dbo.dbClient.clNo + '/' + dbo.dbFile.fileNo AS clfileno,
INNER JOIN dbo.dbFile ON dbo.dbAppointments.fileID = dbo.dbFile.fileID
INNER JOIN dbo.dbUser ON dbo.dbAppointments.feeusrID = dbo.dbUser.usrID
INNER JOIN dbo.dbClient ON dbo.dbFile.clID = dbo.dbClient.clID
LEFT JOIN udapptextrainvite AEI ON dbo.dbAppointments.appID = AEI.origAppID

dbo.dbAppointments.feeusrid = coalesce(7459, dbo.dbAppointments.feeusrid)  
OR AEI.appFeeUsrID like @FEES  
AND (dbo.dbappointments.appdate > '2011-09-30 01:00:00.000')
order by appid
Question by:smsstech
LVL 143

Accepted Solution

Guy Hengel [angelIII / a3] earned 2000 total points
ID: 36502630
your OR and AND mixing in the where clause is the issue
please try
WHERE ( dbo.dbAppointments.feeusrid = coalesce(7459, dbo.dbAppointments.feeusrid)   
     OR AEI.appFeeUsrID like @FEES  
  AND dbo.dbappointments.appdate > '2011-09-30 01:00:00.000'
order by appid

Open in new window


Author Closing Comment

ID: 36502663
Sigh.  Thanks my friend.  Perhaps I've been looking at this too long.  I definitely appreciate the help.  :)

Featured Post

Free Tool: SSL Checker

Scans your site and returns information about your SSL implementation and certificate. Helpful for debugging and validating your SSL configuration.

One of a set of tools we are providing to everyone as a way of saying thank you for being a part of the community.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

     When we have to pass multiple rows of data to SQL Server, the developers either have to send one row at a time or come up with other workarounds to meet requirements like using XML to pass data, which is complex and tedious to use. There is a …
Occasionally there is a need to clean table columns, especially if you have inherited legacy data. There are obviously many ways to accomplish that, including elaborate UPDATE queries with anywhere from one to numerous REPLACE functions (even within…
SQL Database Recovery Software repairs the MDF & NDF Files, corrupted due to hardware related issues or software related errors. Provides preview of recovered database objects and allows saving in either MSSQL, CSV, HTML or XLS format. Ensures recov…
Stellar Phoenix SQL Database Repair software easily fixes the suspect mode issue of SQL Server database. It is a simple process to bring the database from suspect mode to normal mode. Check out the video and fix the SQL database suspect mode problem.

600 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question