[Okta Webinar] Learn how to a build a cloud-first strategyRegister Now

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 1009
  • Last Modified:

Method 'SaveAs' of object '_Workbook' failed

In Access I use VBA to open a single worksheet Excel file and save it as a text file. I never had a problem with it but it gives the above error on a user's PC in a different location.

    Set myXL = New Excel.Application
    myXL.Visible = False
    Set wb = myXL.Workbooks.Open(strXLfile)
    myXL.DisplayAlerts = False 'don't want dialog box
    With wb
        .SaveAs Filename:=strNewName, FileFormat:=xlTxtFileType
        .Close SaveChanges:=False
    End With
    myXL.DisplayAlerts = True


0
TimHudspith
Asked:
TimHudspith
  • 6
  • 6
1 Solution
 
dlmilleCommented:
You might get an error if the saveas file is already opened, or already exists

Dave
0
 
NorieCommented:
Tim

Are you sure you are using the correct file format?

I've never seen, and can't find a reference to, a format called xlTxtFileType.

Why not try just xlText?
0
 
TimHudspithAuthor Commented:
imnorie - I should have pasted in the whole procedure. 'xlTxtFileType' is actually an argument of type Excel.xlFileFormat in this subprocedure. The calling procedure can choose whether to save the the file as CSV (in which case it passes in the constant xlCSVWindows) or TXT (in which case it passes in xlTextWindows).
0
Independent Software Vendors: We Want Your Opinion

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
TimHudspithAuthor Commented:
Additional info - the user is located in Taiwan and I think is using a Chinese-language Windows, if that makes any difference.
0
 
NorieCommented:
Do you mean it's passed as an argument to the function?

What happens when you don't and just use either of the file format constants you want to use?

Another thing that could be a problem is strFileName not being a valid filename.

How/where are you defining that?
0
 
TimHudspithAuthor Commented:
Yes, it is passed in as an argument defined in the caller subprocedure, and strFileName is defined by the location of the original Excel file, which is held in an Access table. This has worked fine on my PC for a long time with no problems. There is no question of the filepath being incorrect - I have eliminated that possibility.

I will try a dedicated procedure without the xlFileFormat argument being passed in and see how that fares.
0
 
NorieCommented:
Tim

You aren't using the filepath in the code.

What's the full error message anyway?

Is it basically what you posted, or is there something that could possibly point to where the problem is?
0
 
TimHudspithAuthor Commented:
The error message is exactly as per this question title: error number 1004, "Method 'SaveAs' of object '_Workbook' failed.
0
 
NorieCommented:
Tim

Where is the path in the code?

All you appear to be using is the filename, without the path the file will get save in what VBA/Windows regards as the current directory.
0
 
TimHudspithAuthor Commented:
The path is held in a table that contains a list of files to import. The import procedure loops down this table's recordset importing the files, most of which are text or csv - no problems there. When it encouters this particular Excel file there is a Yes/No field value in that table that indicates that it must call the subprocedure to convert the Excel workbook to a text file. The file path is read from the field into a string variable which is then passed to the subprocedure.
0
 
NorieCommented:
Tim

Could you please check the value of strNewName?

Does it include the full path and a valid filename?

That's for the user having the problem.
0
 
TimHudspithAuthor Commented:
I'll pick this question up again on Monday when the user is back in the office. Thanks for your help so far.
0
 
NorieCommented:
No problem.
0

Featured Post

[Webinar] Cloud and Mobile-First Strategy

Maybe you’ve fully adopted the cloud since the beginning. Or maybe you started with on-prem resources but are pursuing a “cloud and mobile first” strategy. Getting to that end state has its challenges. Discover how to build out a 100% cloud and mobile IT strategy in this webinar.

  • 6
  • 6
Tackle projects and never again get stuck behind a technical roadblock.
Join Now