Solved

SQL UPDATE query based on calculations

Posted on 2011-09-13
11
371 Views
Last Modified: 2012-05-12
Part of the criteria for this update query is a calculation.  Currently this figure 'liTotalCost' is made just once.  This number needs to be calculated for each record.  How do I integrate these calculations into the query?  I am working with VB6, Access 2003.  Thank you for your help.  
Dim strSQL5 As String
Dim liTotalCost As Long
Dim liBalMD As Long
Dim liEstMD As Long
Dim liActMD As Long

liBalMD = (CDbl([A]) + CDbl([B]) + CDbl([C]) 
liEstMD = (CDbl([X]) + CDbl([Y]) + CDbl([Z]) 

If liBalMD < 0 Then
    liActMD = (liEstMD + liBalMD)
Else
    liActMD = liEstMD
End If
liTotalCost = (CDbl([ActMDCost]) - liActMD)

strSQL5 = "Update DISTINCTROW [ProjOverview] o Left Join (SELECT ProjID, SUM(Amount) AS SumOfAmount From JONProjJoins GROUP BY ProjID) s ON s.ProjID = o.IDNmbr Set [Status] = 'Complete', [Complete] = Now , [TotalServicesAct] = [TotalServicesEst] Where (([Status] = 'Funded') AND (" & liTotalCost & " > Nz(s.SumOfAmount, 0))) OR (([Status] = 'Funded') AND (" & liTotalCost & ") > ([TotalEstimate]))"
DoCmd.RunSQL strSQL5

Open in new window

0
Comment
Question by:KimD2
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
  • 5
  • 5
11 Comments
 
LVL 4

Expert Comment

by:GeoffHarper
ID: 36531307
It looks OK to me, except for an extra paren.  It should be:
...Where (([Status] = 'Funded') AND (" & liTotalCost & " > Nz(s.SumOfAmount, 0)) OR (([Status] = 'Funded') AND (" & liTotalCost & ") > ([TotalEstimate]))"
DoCmd.RunSQL strSQL5

Open in new window

0
 

Author Comment

by:KimD2
ID: 36531380
"liTotalCost" needs to be re-calculated for each record.  Is it being recalculated when written like this?  I am new to this and not sure whay the query is not working.  Thank you for the paren note.  Unfortunately that was not it.  I do not receive an error - just the records that should be updated are not.    I appreciate your input.
0
 
LVL 14

Expert Comment

by:Brook Braswell
ID: 36531394
Put your Sum query in the Where clause

strSQL5 = "Update DISTINCTROW [ProjOverview] o " & _
             "Set [Status] = 'Complete', " & _
               "[Complete] = Now , " & _
       "[TotalServicesAct] = [TotalServicesEst] " & _
           "Where (([Status] = 'Funded') " & _
             "AND (" & liTotalCost & " > Nz(( SELECT SUM(Amount) AS SumOfAmount " & _
                     "From JONProjJoins s " & _
                    "where s.ProjID = o.IDNmbr " & _
                    "GROUP BY ProjID), 0))) OR (([Status] = 'Funded') AND (" & liTotalCost & ") > ([TotalEstimate]))"
DoCmd.RunSQL strSQL5
0
Comprehensive Backup Solutions for Microsoft

Acronis protects the complete Microsoft technology stack: Windows Server, Windows PC, laptop and Surface data; Microsoft business applications; Microsoft Hyper-V; Azure VMs; Microsoft Windows Server 2016; Microsoft Exchange 2016 and SQL Server 2016.

 

Author Comment

by:KimD2
ID: 36531562
Thank you but it is still not updating.  Do you have any other suggestions?  
0
 
LVL 14

Expert Comment

by:Brook Braswell
ID: 36531664
In what way is it not updating ?  Are you getting an error when you run the Update Query ?
0
 

Author Comment

by:KimD2
ID: 36531686
I do not get any errors.  It seems to run but the fields are not updated.  In the records where the criteria is met the fields (Status, Date.. ) remain unchanged.
0
 
LVL 14

Expert Comment

by:Brook Braswell
ID: 36531749
ok, check your where clause, step through the code and see if the where returns data.

Example:

Open a SQL editor:


 
Select * from [ProjOverview] o
Where ( ( [Status] = 'Funded') 
    AND ( 1000 > Nz(
                     ( SELECT SUM(Amount) AS SumOfAmount 
                        From JONProjJoins s 
                       where s.ProjID = o.IDNmbr 
                       GROUP BY s.ProjID), 0
                     )
                   )
             ) OR ( [Status] = 'Funded' AND 1000 > [TotalEstimate])

Open in new window

0
 
LVL 14

Accepted Solution

by:
Brook Braswell earned 500 total points
ID: 36531890
The more I look at this the more I want to remove some of these parenthesis and help you clean it up  :)



Dim strSQL5 As String
Dim SumSql  As string
Dim liTotalCost As Long
Dim liBalMD As Long
Dim liEstMD As Long
Dim liActMD As Long

liBalMD = (CDbl([A]) + CDbl([B]) + CDbl([C]) 
liEstMD = (CDbl([X]) + CDbl([Y]) + CDbl([Z]) 

If liBalMD < 0 Then
    liActMD = (liEstMD + liBalMD)
Else
    liActMD = liEstMD
End If
liTotalCost = (CDbl([ActMDCost]) - liActMD)

SumSql = "SELECT SUM(Amount) AS SumOfAmount " & _
           "FROM JONProjJoins s " & _
          "WHERE s.ProjID = o.IDNmbr " & _
          "GROUP BY s.ProjID"

strSQL5 = "UPDATE [ProjOverview] o " & _
             "SET [Status] = 'Complete', " & _
                 "[Complete] = Now , " & _
                 "[TotalServicesAct] = [TotalServicesEst] " & _
           "WHERE [Status] = 'Funded' " & _
             "AND (" & liTotalCost & " > Nz(" & SumSql & ", 0 ) " & _
              " OR " & liTotalCost & " > [TotalEstimate] )"
DoCmd.RunSQL strSQL5

Open in new window

0
 

Author Comment

by:KimD2
ID: 36532485
Ok -- the where does return data.  
0
 
LVL 14

Expert Comment

by:Brook Braswell
ID: 36532552
Make sure to place parens around the SumSql
SumSql = "( SELECT SUM(Amount) AS SumOfAmount " & _
           "FROM JONProjJoins s " & _
          "WHERE s.ProjID = o.IDNmbr " & _
          "GROUP BY s.ProjID )"

Open in new window

0
 

Author Closing Comment

by:KimD2
ID: 36532851
Thank you!   I revisited the data --- good data combined with your code worked perfectly.   Thank you also for the clean formatting.  It is certainly much clearer and easier to read.
0

Featured Post

Salesforce Has Never Been Easier

Improve and reinforce salesforce training & adoption using WalkMe's digital adoption platform. Start saving on costly employee training by creating fast intuitive Walk-Thrus for Salesforce. Claim your Free Account Now

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Load balancing is the method of dividing the total amount of work performed by one computer between two or more computers. Its aim is to get more work done in the same amount of time, ensuring that all the users get served faster.
This article describes how to use a set of graphical playing cards to create a Draw Poker game in Excel or VB6.
This video shows, step by step, how to configure Oracle Heterogeneous Services via the Generic Gateway Agent in order to make a connection from an Oracle session and access a remote SQL Server database table.
Via a live example, show how to extract insert data into a SQL Server database table using the Import/Export option and Bulk Insert.

691 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question