Improve company productivity with a Business Account.Sign Up

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 863
  • Last Modified:

Powershell

I am trying to write a powershell script to run a batc hfile that is located on the computers' C Drive. It should reads the name from the computers.txt that is on my C drive.
Please double check my work to see if I have done it correctly. I have NO EXPERIENCE in powershell. So please help.

function global:new-process()
 {
     param ([string]$computer, [string]$commandline=$(throw "Command line required."))
 
     $path = "\\$computer\root\cimv2:Win32_Process"
     $mc = new-object System.Management.ManagementClass $path
 
     $cmdargs = $commandline,$null,$null,0
 
     $ret = $mc.psbase.InvokeMethod("Create", $cmdargs)
     if ($ret -eq 0) {
         write-host "Created Process ID: $($cmdargs[3])"
     }
     else {
         write-host "Error $ret creating process."
     }
 
     $mc.psbase.Dispose()
 }
 
$servers = gc c:\Computers.txt
foreach ($server in $servers){new-process $server "c:\command1.bat"}



Thanks,
Paul
0
pauledwardian
Asked:
pauledwardian
  • 5
  • 5
1 Solution
 
QlemoBatchelor, Developer and EE Topic AdvisorCommented:
I have no idea if the script is correct, but there is no obvious flaw. However, it looks kind of cumbersome.

You main task is to run one and the same batch file remotely on different machines? PowerShell 2.0 allows for remoting to do that (see Invoke-Command) - it requires WinRM (part of PowerShell) to run and be configured on each remote machine, but allows for much more control.

Without PowerShell, just using the free PsExec from www.sysinternals.com, it is a one-liner:
  psexec @c:\computers.txt c:\command1.bat
0
 
pauledwardianAuthor Commented:
Can anyone PLEASE help with the code. Like I said Im a beginner.
Either check my work or help me out with a differant code.

Thank you all,
Paul
0
 
QlemoBatchelor, Developer and EE Topic AdvisorCommented:
If you do not clarify your original intention, you might get lousy answers. If an Expert poses a question, you should answer it. For clarity, here are mine:
* Why using PowerShell for this purpose?
* What can we expect to be on the remote side? PowerShell again?
* Is using other tools (like PsExec) an option?
0
Has Powershell sent you back into the Stone Age?

If managing Active Directory using Windows Powershell® is making you feel like you stepped back in time, you are not alone.  For nearly 20 years, AD admins around the world have used one tool for day-to-day AD management: Hyena. Discover why.

 
pauledwardianAuthor Commented:
Why using PowerShell for this purpose?
Because it is better than vbscript and easier to figure out.

* What can we expect to be on the remote side? PowerShell again?
It needs to execute a batch file that is located on the C drive of all computers in the domain. (The computers list are in a text file that powershell needs to execute on all of them.)

* Is using other tools (like PsExec) an option?
Not now since we are in hurry and we are looking for a faster way to approach. It would be a good tool if we had more time to spend and learn that tool.
0
 
QlemoBatchelor, Developer and EE Topic AdvisorCommented:
PsExec would be the fastest way - if it works, that is. But having the script stored locally, as you stated, and using the same credentials on each machine, should make it working instantly. As I have shown, it is a one-liner, and easy to run. Using WMI or PS Remoting introduces more issues than it is worth. In particular if you are in a hurry. The more appropriate way to run psexec is
  psexec @c:\computers.txt -u Domain\User -p Password -d c:\command1.bat

Open in new window

as that will detach PsExec from the processes it starts, allowing for parallel execution.

Does your script work the way you posted it? You still did not say that it does not.

0
 
pauledwardianAuthor Commented:
I appreciate the psexec line you provided.
But all I needed was to verify my script. It works on computers that I checked but I cannot verify it works on all computers since there are hundreds of them. Thats why I asked if somone can please verify the code to see if it is a right code.

Thanks,
Paul
0
 
QlemoBatchelor, Developer and EE Topic AdvisorCommented:
If it works on the few PCs you tested it against, you can assume it does work for all. Only possible reasons for failure are  login restrictions (credentials not valid for all machines), or machines not reachable.
0
 
pauledwardianAuthor Commented:
So by looking at the code can you conclude something? Like if it looks good to you or not?
0
 
QlemoBatchelor, Developer and EE Topic AdvisorCommented:
The only part I would change are the last lines:
$servers = gc c:\Computers.txt
foreach ($server in $servers){new-process $server "c:\command1.bat"}

Open in new window

is usually more PS-ish written
gc c:\Computers.txt | % { new-process $_ "c:\command1.bat" }

Open in new window

Next possible improvement would be to use jobs, which allow for parallel execution. But that would require some job control (e.g. limiting to 10 running jobs), which makes it look more complicated (but indeed it isn't that difficult to accomplish).
0
 
pauledwardianAuthor Commented:
thanks
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

Join & Write a Comment

Featured Post

Improved Protection from Phishing Attacks

WatchGuard DNSWatch reduces malware infections by detecting and blocking malicious DNS requests, improving your ability to protect employees from phishing attacks. Learn more about our newest service included in Total Security Suite today!

  • 5
  • 5
Tackle projects and never again get stuck behind a technical roadblock.
Join Now