Go Premium for a chance to win a PS4. Enter to Win

x
  • Status: Solved
  • Priority: Medium
  • Security: Public
  • Views: 251
  • Last Modified:

Delete based on Column, and date added

The attached module works quickly, but, what I need is to put in one more criteria, where it deletes the oldest, and leaves the newest.

For example it would keep the one with the 9/30/2011 date

Contraint Number              Date

453                                   9/01/2011
453                                   9/30/2011
Option Compare Database

Function DeleteDuplicates()
    Dim DeleteCount As Double ' Make this a Long if you really have that many records
    Dim temp
    Dim sql As String
    Dim rst As Recordset

    
    '' Change DESC to ASC to keep the older record
    '' Leave DESC to keep the newer record
    sql = "SELECT [tbl_GMNA Constraint Report Output].* FROM [tbl_GMNA Constraint Report Output] ORDER BY [tbl_GMNA Constraint Report Output].[Constraint Number] DESC"

    Set rst = CurrentDb.OpenRecordset(sql, dbOpenDynaset)
    
    If rst.EOF Then
        MsgBox "There are no records in this table!"
        Exit Function
    End If
    'Stop
    rst.MoveFirst
    Do Until rst.EOF
        If temp = rst![Constraint Number] Then
            rst.Delete
            DeleteCount = DeleteCount + 1
        Else
            temp = rst![Constraint Number]
        End If
        rst.MoveNext
    Loop
    Set rst = Nothing
    MsgBox "Found and deleted " & CStr(DeleteCount) & " records."

 End Function

Open in new window

0
mato01
Asked:
mato01
  • 7
  • 4
1 Solution
 
SheilsCommented:
Try this

 
Option Compare Database

Function DeleteDuplicates()
    Dim DeleteCount As Double ' Make this a Long if you really have that many records
    Dim temp
    Dim sql As String
	Dim sql2 as String
    Dim rst As Recordset
	Dim rst2 As Recordset
	Dim datMax as Date

    
    '' Change DESC to ASC to keep the older record
    '' Leave DESC to keep the newer record
    sql = "SELECT [tbl_GMNA Constraint Report Output].* FROM [tbl_GMNA Constraint Report Output] ORDER BY [tbl_GMNA Constraint Report Output].[Constraint Number] DESC"

    Set rst = CurrentDb.OpenRecordset(sql, dbOpenDynaset)
    
    If rst.EOF Then
        MsgBox "There are no records in this table!"
        Exit Function
    End If
    'Stop
    rst.MoveFirst
    Do Until rst.EOF
        If temp = rst![Constraint Number] Then
            
			sql2="SELECT [tbl_GMNA Constraint Report Output].* FROM [tbl_GMNA Constraint Report Output]" 
			sql2=sql2 & " WHERE [Constraint Number]=" & rst("Constraint Number") 
			sql2=sql2 & " ORDER BY [tbl_GMNA Constraint Report Output].[Constraint Number] DESC"
			
			rst2.open sql2
			
			datMax=rst2("fldDate")
			
			if rst2.Count>1 Then
			
			sql2="Delete * From [tbl_GMNA Constraint Report Output] WHERE [Constraint Number]=" & rst("Constraint Number")
			sql2=sql2 & " AND fldDate Is Not #" & datMax & "#"
			
			CurrentDB.Execute sql2
			
			End If
			
			rst2.close
			
            DeleteCount = DeleteCount + 1
        Else
            temp = rst![Constraint Number]
        End If
        rst.MoveNext
    Loop
    Set rst = Nothing
    MsgBox "Found and deleted " & CStr(DeleteCount) & " records."

 End Function

Open in new window

0
 
mato01Author Commented:
It gave an error "Compile Error: Method or data member not found"

at below line

rst2.Open sql2
0
 
SheilsCommented:
change fldDate to the name of the field that holds the date in your db and also change rst2.Count to rst2.RecordCount
0
Industry Leaders: We Want Your Opinion!

We value your feedback.

Take our survey and automatically be enter to win anyone of the following:
Yeti Cooler, Amazon eGift Card, and Movie eGift Card!

 
mato01Author Commented:
Make above suggested changes, and still "Compile Error: Method or data member not found" at
rst2.Open sql2. Did not work.  Also, tried to change rst2.Open sql2 to rst2.OpenRecordset sql2.
***********************************************************************************************************************
            rst2.Open sql2

            datMax = rst2("Date Added")
           
            If rst2.RecordCount > 1 Then
0
 
SheilsCommented:
try:

sql2="SELECT [tbl_GMNA Constraint Report Output].* FROM [tbl_GMNA Constraint Report Output]"
                  sql2=sql2 & " WHERE [Constraint Number]=" & rst.fields("Constraint Number")
                  sql2=sql2 & " ORDER BY [tbl_GMNA Constraint Report Output].[Constraint Number] DESC"
                  
                  rst2.open sql2
                  
                  datMax=rst2.fields("fldDate")

My apology for the syntax errors.

If you still have problem do a debug.print and post the output. That is

sql2="SELECT [tbl_GMNA Constraint Report Output].* FROM [tbl_GMNA Constraint Report Output]"
sql2=sql2 & " WHERE [Constraint Number]=" & rst.fields("Constraint Number")
sql2=sql2 & " ORDER BY [tbl_GMNA Constraint Report Output].[Constraint Number] DESC"

Debug.print sql2

The output will be in the immediate window. Copy and post                  
                  
0
 
mato01Author Commented:
That didn't work.  This is new for me.  How do I debug.print?
0
 
mato01Author Commented:
I've attached a sample of the database for reference.

The error message is

COMPILE ERROR: Method or Data Member Not Found highlights this line.

  rst2.Open sql2

test11.accdb
0
 
SheilsCommented:
This works

 
Function DeleteDuplicates()
    Dim DeleteCount As Long ' Make this a Long if you really have that many records
    Dim temp
    Dim sql As String
    Dim sql2 As String
    Dim rst As DAO.Recordset
    Dim rst2 As DAO.Recordset
    Dim datMax As Date

    
    '' Change DESC to ASC to keep the older record
    '' Leave DESC to keep the newer record
    sql = "SELECT [tbl_GMNA Constraint Report Output].* FROM [tbl_GMNA Constraint Report Output] ORDER BY [tbl_GMNA Constraint Report Output].[Constraint Number] DESC"

    Set rst = CurrentDb.OpenRecordset(sql, dbOpenDynaset)

    If rst.EOF Then
        MsgBox "There are no records in this table!"
        Exit Function
    End If
        
    rst.MoveFirst
    Do Until rst.EOF
  
        If temp = rst![Constraint Number] Then
        
        
        sql2 = "SELECT [tbl_GMNA Constraint Report Output].* FROM [tbl_GMNA Constraint Report Output]"
                  sql2 = sql2 & " WHERE [Constraint Number]='" & rst.Fields("Constraint Number")
                  sql2 = sql2 & "' ORDER BY [tbl_GMNA Constraint Report Output].[Constraint Number] DESC"
                  
                  
                  Set rst2 = CurrentDb.OpenRecordset(sql2, dbOpenDynaset)
                  
                  datMax = rst2.Fields("Date Added")

            
            If rst2.RecordCount > 1 Then
            
            sql2 = "Delete * From [tbl_GMNA Constraint Report Output] WHERE [Constraint Number]=" & rst("Constraint Number")
            sql2 = sql2 & " AND [Date Added] Is Not #" & datMax & "#"
            
            CurrentDb.Execute sql2
            
            End If
            
            rst2.Close
            
            DeleteCount = DeleteCount + 1
        Else
            temp = rst![Constraint Number]
        End If
        rst.MoveNext
    Loop
    Set rst = Nothing
    MsgBox "Found and deleted " & CStr(DeleteCount) & " records."

End Function

Open in new window

0
 
mato01Author Commented:
When I ran it, I received the following error.

Run-time error '3075.:

Invalid use of IS operator in query expression '[Constraint Number] = 766 AND [Date Added] Is not #9/11/2011'.
0
 
mato01Author Commented:
Changed

sql2 = sql2 & " AND [Date Added] Is Not #" & datMax & "#"

to

sql2 = sql2 & " AND [Date Added] <> #" & datMax & "#"

and received a  Run-time error '3464'

Data type mismatch in criteria expression
0
 
mato01Author Commented:
I was able to get an answer.  But, wanted to award you ALL the points for all your great help.  Thanks
0

Featured Post

Concerto's Cloud Advisory Services

Want to avoid the missteps to gaining all the benefits of the cloud? Learn more about the different assessment options from our Cloud Advisory team.

  • 7
  • 4
Tackle projects and never again get stuck behind a technical roadblock.
Join Now