asked on

ASKER

note: i would be initialize as 1 not 0. please review my syntax and offer suggestions. thanks

I'm not sure why you would need to create a Number object for localStorage.ctr unless there's a possibility it is not a number in which case your loop would fail. If you prefer to use a number object, you could use:

n=new Number(localStorage.ctr);
for (i=0; i<=n.valueOf();i++);

Open in new window

Personally, I would just parse the number as an integer:

for (i=0; i<=parseInt(localStorage.ctr);i++);

Open in new window

leakim971

for example : http://jsfiddle.net/88eJ2/

<ul>
    <script language="javascript" type="text/javascript">
    localStorage = {};
    localStorage.ctr = 3
    localStorage.item1 = "A";
    localStorage.item2 = "B";
    localStorage.item3 = "C";
    for (i=1;i<=localStorage.ctr;i++)
    { 
        document.write("<li><a href='x.php?item=" + localStorage["item" +i] + "'>" + localStorage["item" +i] + "</a></li>");
    }

</script>
</ul>

Open in new window

kbios

ASKER

I parsed the number as an integer as you suggested. I am still trying to get the <li> portion of the javascript to display properly on the HTML page. The following code should initially display 3 <li> detailed tags. At this point I'm trying to get the <li> to display. I will then come back use a variable for the item. Please look at the code and explain why the <li> tags are not displaying.

<script>
window.onload = viewlist();
</script>

<div id="content">
<div id="listitem">
<ul>
<script type="text/javascript" language="javascript">
function viewlist()
{
var i =1;
for (i=1; i<=parseInt(localStorage.trxCtr);i++);
{
document.write("<li><a href=getitemdetail.php?item='4004'></a></li>");
}
}
</script>
</ul>

kbios

ASKER

My localStorage variables should be available throughout my HTML I don't think I need/want the following contained within my function:
localStorage = {};
localStorage.ctr = 3
localStorage.item1 = "A";
localStorage.item2 = "B";
localStorage.item3 = "C";

When I view the source the of the html page I see the text 'document.write' where I think I should only see the <li> portion. In php I don't see the word 'echo' I only see the code I want.

The for loop is not creating multiple lines as it should nor are those lines being displayed.

kbios

ASKER

I don't think that my javascript function is getting called. I am using the following to launch the function.

<script>
window.onload = viewlist();
</script>

Any other suggestions to automatically run the function. I want the function to execute on loading/entering the page without having to submit.

ASKER CERTIFIED SOLUTION

Kim Walker

membership

This solution is only available to members.

To access this solution, you must be a member of Experts Exchange.

Start Free Trial

leakim971

<html><head></head><body>
<ul>
    <script language="javascript" type="text/javascript">
    localStorage = {};
    localStorage.ctr = 3
    localStorage.item1 = "A";
    localStorage.item2 = "B";
    localStorage.item3 = "C";
    for (i=1;i<=localStorage.ctr;i++)
    { 
        document.write("<li><a href='x.php?item=" + localStorage["item" +i] + "'>" + localStorage["item" +i] + "</a></li>");
    }
</script>
</ul>
</body></html>

Open in new window

kbios

ASKER

Here is the current code.

<div id="itemlist">
<ul>
<script type="text/ecmascript">
var i =1;
for (i=1;i<=parseInt(localStorage.trxCtr);i++);
{
document.write("<li><a href=getitemdetail.php?item='4004'>something here</a></li>");
}
</script>
</ul>
</div>

Thanks for the input on the anchor tag, it was inadvertantly deleted. I see where the code is now just a script and not a javascript and a big thanks for pointing toward the correct method. The <li> component DOES now appear. However I am expecting the number of <li>'s to be the value of my ctr. In the above example the counter is = 2 but only 1 <li> is displayed. Any thoughts on why the loop only returns 1 of the <li>'s?

Kim Walker

I just noticed a flaw in your link. Change:

<a href=getitemdetail.php?item='4004'>

Open in new window

to:

<a href='getitemdetail.php?item=4004'>

Open in new window

(move the quote to follow the equals mark)

kbios

ASKER

Thanks for your help. I am closing this question but opening another. You answered this question but I now need the proper syntax to select the item from within localStorage.

Kim Walker

This is what I get for copying and pasting and not double-checking my work. Remove the semi-colon at the end of the "for" declaration. You have:

     for (i=1;i<=parseInt(localStorage.trxCtr);i++);
      {
        document.write("<li><a href=getitemdetail.php?item='4004'>something here</a></li>");
      }

Open in new window

It should be:

     for (i=1;i<=parseInt(localStorage.trxCtr);i++)
      {
        document.write("<li><a href=getitemdetail.php?item='4004'>something here</a></li>");
      }

Open in new window

(no semi-colon at the end of line 1)

How do I use javascript to create HTML &lt;ul&gt;&lt;li&gt; tags?

How do I use javascript to create HTML <ul><li> tags?