How do I use javascript to create HTML <ul><li> tags?

I am trying to use javascript to create a page with <ul><li> tags. I have some localStorage variables that I want to retreive and display as an unnumbered list on an HTML page.

localStorage.ctr = 3
localStorage.item1 = A
localStorage.item2 = B
localStorage.item3 = C

Here is the approach I'm working with:


<ul>

<script type="text/javascript"> {
var i = 0;
for (i=0; i<=Number(localStorage.ctr);i++);
   {
    document.write "<li><a href=x.php?item=localStorage["item" +i]></a></li>"
   }
}
</script>

</ul>

I'm expecting the following html code:

<ul>
  <li><a href=x.php?item=A></a></li>
  <li><a href=x.php?item=B></a></li>
  <li><a href=x.php?item=C></a></li>
</ul>

Any help/suggestions are appreciated.

kbiosAsked:
Who is Participating?

Improve company productivity with a Business Account.Sign Up

x
 
Kim WalkerConnect With a Mentor Web Programmer/TechnicianCommented:
The execution of the function is not relevant to it's location in the html stream. I would expect, if the function were being executed, it would wipe out your entire page and replace it with the <li.....> code. document.write should only occur during page load. When you execute a document.write after the page load, it overwrites the page.

With that said, keep the script simple and let it run during the page load. You can leave your localStorage object in the head. It, too, should be outside any functions or loops in order to be global. In your comment above, you've used "localStorage.trxCtr" but I thought it was "localStorage.ctr".

<div id="content">
  <div id="listitem">
    <ul>
      < script type="text/ecmascript">
             var i =1;
            for (i=1; i<=parseInt(localStorage.ctr);i++);
            {
            document.write("<li><a href=getitemdetail.php?item='4004'>something here</a></li>");
            }  
       </script>
   </ul>

Open in new window


I need to point out that your sample does not include any text within the anchor tag. I've inserted "something here" in my code above to represent where the anchor text should appear. Otherwise, there's nothing for the view to click on to navigate to the linked page.

I've removed the language attribute of the script element. That attribute was deprecated some time ago. I've also used ecmascript instead of javascript. It really doesn't matter which you use there.

"ecmascript" is the politically correct name for javascript since it has no relationship to Java.
0
 
kbiosAuthor Commented:
note: i would be initialize as 1 not 0. please review my syntax and offer suggestions. thanks
0
 
Kim WalkerWeb Programmer/TechnicianCommented:
I'm not sure why you would need to create a Number object for localStorage.ctr unless there's a possibility it is not a number in which case your loop would fail. If you prefer to use a number object, you could use:

n=new Number(localStorage.ctr);
for (i=0; i<=n.valueOf();i++);

Open in new window


Personally, I would just parse the number as an integer:

for (i=0; i<=parseInt(localStorage.ctr);i++);

Open in new window

0
What Kind of Coding Program is Right for You?

There are many ways to learn to code these days. From coding bootcamps like Flatiron School to online courses to totally free beginner resources. The best way to learn to code depends on many factors, but the most important one is you. See what course is best for you.

 
leakim971PluritechnicianCommented:
for example : http://jsfiddle.net/88eJ2/


<ul>
    <script language="javascript" type="text/javascript">
    localStorage = {};
    localStorage.ctr = 3
    localStorage.item1 = "A";
    localStorage.item2 = "B";
    localStorage.item3 = "C";
    for (i=1;i<=localStorage.ctr;i++)
    { 
        document.write("<li><a href='x.php?item=" + localStorage["item" +i] + "'>" + localStorage["item" +i] + "</a></li>");
    }

</script>
</ul>

Open in new window

0
 
kbiosAuthor Commented:
I parsed the number as an integer as you suggested. I am still trying to get the <li> portion of the javascript to display properly on the HTML page. The following code should initially display 3 <li> detailed tags. At this point I'm trying to get the <li> to display. I will then come back use a variable for the item. Please look at the code and explain why the <li> tags are not displaying.

<script>
  window.onload = viewlist();
</script>
            
<div id="content">
  <div id="listitem">
    <ul>
      <script type="text/javascript" language="javascript">
         function viewlist()
         {
            var i =1;
            for (i=1; i<=parseInt(localStorage.trxCtr);i++);
            {
            document.write("<li><a href=getitemdetail.php?item='4004'></a></li>");
            }  
         }
       </script>
   </ul>
0
 
kbiosAuthor Commented:
My localStorage variables should be available throughout my HTML I don't think I need/want the following contained within my function:
    localStorage = {};
    localStorage.ctr = 3
    localStorage.item1 = "A";
    localStorage.item2 = "B";
    localStorage.item3 = "C";

When I view the source the of the html page I see the text 'document.write' where I think I should only see the <li> portion. In php I don't see the word 'echo' I only see the code I want.

The for loop is not creating multiple lines as it should nor are those lines being displayed.
0
 
kbiosAuthor Commented:
I don't think that my javascript function is getting called. I am using the following to launch the function.

<script>
  window.onload = viewlist();
</script>

Any other suggestions to automatically run the function. I want the function to execute on loading/entering the page without having to submit.
0
 
leakim971PluritechnicianCommented:
<html><head></head><body>
<ul>
    <script language="javascript" type="text/javascript">
    localStorage = {};
    localStorage.ctr = 3
    localStorage.item1 = "A";
    localStorage.item2 = "B";
    localStorage.item3 = "C";
    for (i=1;i<=localStorage.ctr;i++)
    { 
        document.write("<li><a href='x.php?item=" + localStorage["item" +i] + "'>" + localStorage["item" +i] + "</a></li>");
    }
</script>
</ul>
</body></html>

Open in new window

0
 
kbiosAuthor Commented:
Here is the current code.

<div id="itemlist">
    <ul>
      <script type="text/ecmascript">
      var i =1;
      for (i=1;i<=parseInt(localStorage.trxCtr);i++);
      {
        document.write("<li><a href=getitemdetail.php?item='4004'>something here</a></li>");
      }  
    </script>
  </ul>
</div>

Thanks for the input on the anchor tag, it was inadvertantly deleted. I see where the code is now just a script and not a javascript and a big thanks for pointing toward the correct method. The <li> component DOES now appear. However I am expecting the number of <li>'s to be the value of my ctr. In the above example the counter is = 2 but only 1 <li> is displayed. Any thoughts on why the loop only returns 1 of the <li>'s?
0
 
Kim WalkerWeb Programmer/TechnicianCommented:
I just noticed a flaw in your link. Change:

<a href=getitemdetail.php?item='4004'>

Open in new window


to:

<a href='getitemdetail.php?item=4004'>

Open in new window


(move the quote to follow the equals mark)
0
 
kbiosAuthor Commented:
Thanks for your help. I am closing this question but opening another. You answered this question but I now need the proper syntax to select the item from within localStorage.
0
 
Kim WalkerWeb Programmer/TechnicianCommented:
This is what I get for copying and pasting and not double-checking my work. Remove the semi-colon at the end of the "for" declaration. You have:

     for (i=1;i<=parseInt(localStorage.trxCtr);i++);
      {
        document.write("<li><a href=getitemdetail.php?item='4004'>something here</a></li>");
      }

Open in new window


It should be:

     for (i=1;i<=parseInt(localStorage.trxCtr);i++)
      {
        document.write("<li><a href=getitemdetail.php?item='4004'>something here</a></li>");
      }

Open in new window


(no semi-colon at the end of line 1)
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.