Solved

Regex to filter urls w/ certain words inside

Posted on 2011-09-21
25
298 Views
Last Modified: 2012-06-21
Hi,

I would like to exclude urls that contain certain words like "login", "contactus", etc., and preserve the rest other


Thanks for help!
0
Comment
Question by:wsyy
  • 8
  • 8
  • 5
  • +2
25 Comments
 
LVL 4

Expert Comment

by:reijnemans
Comment Utility
You mean something like this:

public static void main(String...urls) {
		String[] wordsToExclude = new String[] {"login, contactus"};
		List<String> accpetedUrls = new ArrayList<String>();
		
		String regex = toRegex(wordsToExclude);
		
		for (String url : urls) {
			if (!url.matches(regex)) {
				accpetedUrls.add(url);
			}
		}
	}
	
	public static String toRegex(String[] wordsToExclude) {
		StringBuilder sb = new StringBuilder();
		for (String wordToExclude : wordsToExclude) {
			sb.append("(");
			sb.append(wordToExclude);
			sb.append(") |");
		}
		// exclude the last | sign
		return sb.substring(0, sb.length() - 1);
	}

Open in new window

0
 

Author Comment

by:wsyy
Comment Utility
I meant that a regular expression can filter the target urls and keep the others.

Say,

String regex="something";
System.out.println("http://www.experts-exchange.com/login.html".matches(regex));
==return FALSE

System.out.println("http://www.experts-exchange.com/Programming/Languages/Java/Q_27319546.html".matches(regex));
==return TRUE
0
 
LVL 4

Expert Comment

by:reijnemans
Comment Utility
you mean somting like this

	public static void main(String...urls1) {
		String[] urls = new String[] {"www.login.htm", "www.lloogg.htm", "www.hello.htm", "www.blaat.com/contactus"};
		
		for (String string : urls) {
			System.out.println(urlOK(string));
		}
	}
	
	public static boolean urlOK(String url) {
		String regex = "(.*)(login|contactus)(.*)";
		return url.matches(regex);
	}

Open in new window

0
 
LVL 4

Expert Comment

by:reijnemans
Comment Utility
The example aboe returns:

true
false
false
true
0
 
LVL 4

Expert Comment

by:reijnemans
Comment Utility
BTWL this is a good url to test your regex: http://www.regexpal.com/
0
 

Author Comment

by:wsyy
Comment Utility
unfortunately, you misunderstood.

I want the results exactly opposite.

The results should be according to your example:

true
false
false
true
0
 

Author Comment

by:wsyy
Comment Utility
anyone can help?
0
 
LVL 47

Expert Comment

by:for_yan
Comment Utility


why wiould not you simply check indexOf()



for(url : urls){

boolean good = true;
if(url.indexOf("login")>-1)good = false;
if(url.indexOf("contact") > -1)good = false;
if(!good) .....//exclude

//use good ones
}
0
 
LVL 4

Expert Comment

by:reijnemans
Comment Utility
instead of
public static boolean urlOK(String url) {
		String regex = "(.*)(login|contactus)(.*)";
		return url.matches(regex);
	}

Open in new window


you do this

public static boolean urlOK(String url) {
		String regex = "(.*)(login|contactus)(.*)";
		return !url.matches(regex);
	}

Open in new window


now the result is the opposite
0
 

Author Comment

by:wsyy
Comment Utility
indexOf() doesn't accept regex
0
 

Author Comment

by:wsyy
Comment Utility
reijnemans:

since we have quite a few things to check, we want to make a uniform call to the matches function. So a ! upon some check while no ! on the other doesn't look a good choice for us.
0
 
LVL 47

Expert Comment

by:for_yan
Comment Utility
No, why do you need regex - this is just case for indexOf()
0
Do You Know the 4 Main Threat Actor Types?

Do you know the main threat actor types? Most attackers fall into one of four categories, each with their own favored tactics, techniques, and procedures.

 
LVL 86

Assisted Solution

by:CEHJ
CEHJ earned 62 total points
Comment Utility
I would

a. keep your words in a text file, from which you can make List<String>. That way you can extend/edit your choices without recompilation
http://technojeeves.com/joomla/index.php/free/74-string-list
b. Avoid regex. You don't need the overhead. Just loop through the List calling


boolean excluded = false;
for (String currentWordInList : wordList) {
   excluded = urlString.contains(currentWordInList);
   if(excluded) break;
}

Open in new window

0
 

Author Comment

by:wsyy
Comment Utility
for_yan,

need regex as there are a few words to exclude.

CEHJ,

need regex as the word-exclusion regex is commingled with other regex.
0
 

Author Comment

by:wsyy
Comment Utility
i think i actually find one solution
0
 
LVL 47

Expert Comment

by:for_yan
Comment Utility
Put these words into array or arraylist and check using indexOf() - don't think regex will make it better if you need more words
0
 
LVL 47

Expert Comment

by:for_yan
Comment Utility
regex is good when you have some complicated conditions for searching, and this is not the case here
0
 
LVL 47

Accepted Solution

by:
for_yan earned 63 total points
Comment Utility
       String [] badWords = {"login","contactus"};
        String patStr = "\\b(?:";
        for(String sar : badWords){
            patStr += sar + "|";
        }
        patStr = patStr.substring(0,patStr.length()-1);
        patStr += ")\\b";
        System.out.println(patStr);


String[] urls = new String[] {"www.login.htm", "www.lloogg.htm", "www.hello.htm", "www.blaat.com/contactus", "www.blaat.com/contactus/index.html"};

     //   Pattern p11 = Pattern.compile("\\b(?:login|contactus)\\b");

         Pattern p11 = Pattern.compile(patStr);

        for(String url : urls){
            Matcher mu = p11.matcher(url);
            if(mu.find())System.out.println(url + " to be excluded");
            else    System.out.println(url + " to be included");


        }

Open in new window


Output:
\b(?:login|contactus)\b
www.login.htm to be excluded
www.lloogg.htm to be included
www.hello.htm to be included
www.blaat.com/contactus to be excluded
www.blaat.com/contactus/index.html to be excluded

Open in new window

0
 

Author Comment

by:wsyy
Comment Utility
Here is the solution I figured out:

(?!.*(login|rss|member|contactus|aboutus|logout|reg|help).*).+

it works so far, but not sure of its performance.
0
 
LVL 47

Expert Comment

by:for_yan
Comment Utility
How many URLs do you have?
0
 
LVL 47

Expert Comment

by:for_yan
Comment Utility
You probably want to start the internal parentheses with (?: - to make it non-capturing
if you are concerned with performance

0
 
LVL 47

Expert Comment

by:for_yan
Comment Utility
Thinking about performance in theory is not always the best approach.

Start using it and then you'll know if the performance will be an issue.
It is very often we spend time saving tiny milliseconds, and the bottleneck ends up
to be in quite different place
0
 
LVL 86

Expert Comment

by:CEHJ
Comment Utility
>>
Here is the solution I figured out:

(?!.*(login|rss|member|contactus|aboutus|logout|reg|help).*).+

it works so far, but not sure of its performance.
>>

Exactly the same can be done with the approach i suggested, which is more extensible and more performant
0
 
LVL 10

Expert Comment

by:gordon_vt02
Comment Utility
Agreed with CEHJ.  If all your regex is doing is filtering exact words and you don't have a need for actual pattern matching beyond a simple String.contains() feature, iterating over a list of words is much faster and easier to maintain.  Every time you want to add a new filter, you have to modify the regex -- likely in code -- making it more complicated and difficult to read.  A simple List can be easily appended to and stored in an external file (the regex could as well) with one filter per line, making it a lot easier to read and maintain.
0
 
LVL 10

Expert Comment

by:gordon_vt02
Comment Utility
Make sure you use the right tool for the job.  Sure, you can flip a screwdriver around and use the handle to knock in a nail, but a hammer is going to be much more efficient.
0

Featured Post

How to improve team productivity

Quip adds documents, spreadsheets, and tasklists to your Slack experience
- Elevate ideas to Quip docs
- Share Quip docs in Slack
- Get notified of changes to your docs
- Available on iOS/Android/Desktop/Web
- Online/Offline

Join & Write a Comment

Suggested Solutions

Whatever be the reason, if you are working on web development side,  you will need day-today validation codes like email validation, date validation , IP address validation, phone validation on any of the edit page or say at the time of registration…
Basic understanding on "OO- Object Orientation" is needed for designing a logical solution to solve a problem. Basic OOAD is a prerequisite for a coder to ensure that they follow the basic design of OO. This would help developers to understand the b…
Viewers will learn one way to get user input in Java. Introduce the Scanner object: Declare the variable that stores the user input: An example prompting the user for input: Methods you need to invoke in order to properly get  user input:
This theoretical tutorial explains exceptions, reasons for exceptions, different categories of exception and exception hierarchy.

728 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

12 Experts available now in Live!

Get 1:1 Help Now