Regex to filter urls w/ certain words inside

Hi,

I would like to exclude urls that contain certain words like "login", "contactus", etc., and preserve the rest other


Thanks for help!
wsyyAsked:
Who is Participating?
 
for_yanConnect With a Mentor Commented:
       String [] badWords = {"login","contactus"};
        String patStr = "\\b(?:";
        for(String sar : badWords){
            patStr += sar + "|";
        }
        patStr = patStr.substring(0,patStr.length()-1);
        patStr += ")\\b";
        System.out.println(patStr);


String[] urls = new String[] {"www.login.htm", "www.lloogg.htm", "www.hello.htm", "www.blaat.com/contactus", "www.blaat.com/contactus/index.html"};

     //   Pattern p11 = Pattern.compile("\\b(?:login|contactus)\\b");

         Pattern p11 = Pattern.compile(patStr);

        for(String url : urls){
            Matcher mu = p11.matcher(url);
            if(mu.find())System.out.println(url + " to be excluded");
            else    System.out.println(url + " to be included");


        }

Open in new window


Output:
\b(?:login|contactus)\b
www.login.htm to be excluded
www.lloogg.htm to be included
www.hello.htm to be included
www.blaat.com/contactus to be excluded
www.blaat.com/contactus/index.html to be excluded

Open in new window

0
 
reijnemansCommented:
You mean something like this:

public static void main(String...urls) {
		String[] wordsToExclude = new String[] {"login, contactus"};
		List<String> accpetedUrls = new ArrayList<String>();
		
		String regex = toRegex(wordsToExclude);
		
		for (String url : urls) {
			if (!url.matches(regex)) {
				accpetedUrls.add(url);
			}
		}
	}
	
	public static String toRegex(String[] wordsToExclude) {
		StringBuilder sb = new StringBuilder();
		for (String wordToExclude : wordsToExclude) {
			sb.append("(");
			sb.append(wordToExclude);
			sb.append(") |");
		}
		// exclude the last | sign
		return sb.substring(0, sb.length() - 1);
	}

Open in new window

0
 
wsyyAuthor Commented:
I meant that a regular expression can filter the target urls and keep the others.

Say,

String regex="something";
System.out.println("http://www.experts-exchange.com/login.html".matches(regex));
==return FALSE

System.out.println("http://www.experts-exchange.com/Programming/Languages/Java/Q_27319546.html".matches(regex));
==return TRUE
0
Cloud Class® Course: C++ 11 Fundamentals

This course will introduce you to C++ 11 and teach you about syntax fundamentals.

 
reijnemansCommented:
you mean somting like this

	public static void main(String...urls1) {
		String[] urls = new String[] {"www.login.htm", "www.lloogg.htm", "www.hello.htm", "www.blaat.com/contactus"};
		
		for (String string : urls) {
			System.out.println(urlOK(string));
		}
	}
	
	public static boolean urlOK(String url) {
		String regex = "(.*)(login|contactus)(.*)";
		return url.matches(regex);
	}

Open in new window

0
 
reijnemansCommented:
The example aboe returns:

true
false
false
true
0
 
reijnemansCommented:
BTWL this is a good url to test your regex: http://www.regexpal.com/
0
 
wsyyAuthor Commented:
unfortunately, you misunderstood.

I want the results exactly opposite.

The results should be according to your example:

true
false
false
true
0
 
wsyyAuthor Commented:
anyone can help?
0
 
for_yanCommented:


why wiould not you simply check indexOf()



for(url : urls){

boolean good = true;
if(url.indexOf("login")>-1)good = false;
if(url.indexOf("contact") > -1)good = false;
if(!good) .....//exclude

//use good ones
}
0
 
reijnemansCommented:
instead of
public static boolean urlOK(String url) {
		String regex = "(.*)(login|contactus)(.*)";
		return url.matches(regex);
	}

Open in new window


you do this

public static boolean urlOK(String url) {
		String regex = "(.*)(login|contactus)(.*)";
		return !url.matches(regex);
	}

Open in new window


now the result is the opposite
0
 
wsyyAuthor Commented:
indexOf() doesn't accept regex
0
 
wsyyAuthor Commented:
reijnemans:

since we have quite a few things to check, we want to make a uniform call to the matches function. So a ! upon some check while no ! on the other doesn't look a good choice for us.
0
 
for_yanCommented:
No, why do you need regex - this is just case for indexOf()
0
 
CEHJConnect With a Mentor Commented:
I would

a. keep your words in a text file, from which you can make List<String>. That way you can extend/edit your choices without recompilation
http://technojeeves.com/joomla/index.php/free/74-string-list
b. Avoid regex. You don't need the overhead. Just loop through the List calling


boolean excluded = false;
for (String currentWordInList : wordList) {
   excluded = urlString.contains(currentWordInList);
   if(excluded) break;
}

Open in new window

0
 
wsyyAuthor Commented:
for_yan,

need regex as there are a few words to exclude.

CEHJ,

need regex as the word-exclusion regex is commingled with other regex.
0
 
wsyyAuthor Commented:
i think i actually find one solution
0
 
for_yanCommented:
Put these words into array or arraylist and check using indexOf() - don't think regex will make it better if you need more words
0
 
for_yanCommented:
regex is good when you have some complicated conditions for searching, and this is not the case here
0
 
wsyyAuthor Commented:
Here is the solution I figured out:

(?!.*(login|rss|member|contactus|aboutus|logout|reg|help).*).+

it works so far, but not sure of its performance.
0
 
for_yanCommented:
How many URLs do you have?
0
 
for_yanCommented:
You probably want to start the internal parentheses with (?: - to make it non-capturing
if you are concerned with performance

0
 
for_yanCommented:
Thinking about performance in theory is not always the best approach.

Start using it and then you'll know if the performance will be an issue.
It is very often we spend time saving tiny milliseconds, and the bottleneck ends up
to be in quite different place
0
 
CEHJCommented:
>>
Here is the solution I figured out:

(?!.*(login|rss|member|contactus|aboutus|logout|reg|help).*).+

it works so far, but not sure of its performance.
>>

Exactly the same can be done with the approach i suggested, which is more extensible and more performant
0
 
gordon_vt02Commented:
Agreed with CEHJ.  If all your regex is doing is filtering exact words and you don't have a need for actual pattern matching beyond a simple String.contains() feature, iterating over a list of words is much faster and easier to maintain.  Every time you want to add a new filter, you have to modify the regex -- likely in code -- making it more complicated and difficult to read.  A simple List can be easily appended to and stored in an external file (the regex could as well) with one filter per line, making it a lot easier to read and maintain.
0
 
gordon_vt02Commented:
Make sure you use the right tool for the job.  Sure, you can flip a screwdriver around and use the handle to knock in a nail, but a hammer is going to be much more efficient.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.