Solved

VBS issue

Posted on 2011-09-23
10
333 Views
Last Modified: 2012-05-12
I have VBS that I mashed together that is supposed to look in a folder and take .bkf extensions and change them to .txt. Then it is supposed to delete older files.

It gives me an error on line 9.

Can someone help me on this??

Thanks
Dim fso, startFolder, OlderThanDate

strComputer = "."
Set objWMIService = GetObject("winmgmts:" _
    & "{impersonationLevel=impersonate}!\\" & strComputer & "\root\cimv2")
Set FileList = objWMIService.ExecQuery _
    ("ASSOCIATORS OF {Win32_Directory.Name='\\server\itdept\adbackup'} Where " _
        & "ResultClass = CIM_DataFile")
For Each objFile In FileList
    If objFile.Extension = "bkf" Then
        strNewName = objFile.Drive & objFile.Path & _
            objFile.FileName & "." & "txt"
            errResult = objFile.Rename(strNewName)
        Wscript.Echo errResult
    End If
Next


 Set fso = CreateObject("Scripting.FileSystemObject")
 startFolder = "\\server\itdept\adbackup"
 OlderThanDate = DateAdd("d", -2, Date) ' 2 days 
 DeleteOldFiles startFolder, OlderThanDate 
 
  
 Function DeleteOldFiles(folderName, BeforeDate) 
 Dim folder, file, fileCollection, folderCollection, subFolder 
 Set folder = fso.GetFolder(folderName) 
 Set fileCollection = folder.Files 
 For Each file In fileCollection 
 	If file.DateLastModified < BeforeDate Then 
 		fso.DeleteFile(file.Path) 
 	End If 
 Next 
 Set folderCollection = folder.SubFolders 
 For Each subFolder In folderCollection 
 	DeleteOldFiles subFolder.Path, BeforeDate 
 Next 
 End Function

Open in new window

0
Comment
Question by:clynch302
  • 4
  • 3
  • 2
  • +1
10 Comments
 
LVL 28

Expert Comment

by:sammySeltzer
Comment Utility
I don't think it likes computer name being define as "."

strComputer = "."

Are you using this for more than one computer or are you planning on passing computer name as param?

Trying sticking actual computer name there and see what happens.

Also, do you have a different file name other than bkf on that folder?
0
 
LVL 51

Expert Comment

by:Bill Prew
Comment Utility
What error are you getting?

~bp
0
 
LVL 28

Expert Comment

by:sammySeltzer
Comment Utility
The error says (null) with some error code. That's what I got when I attempted to test it to see if I could figure out what could be wrong.

I wanted to clarify that defining your computer as strComputer="." doesn't mean there is something wrong with that declaration.

I would try using this to diagnose vmi to see if something is amiss with it.

http://windowsxp.mvps.org/repairwmi.htm

0
 

Author Comment

by:clynch302
Comment Utility
This is used on my computer only.  I have a folder that files are copied to that are .bkf. I need them to be .txt. So this is basically all ran from 1 system. I have a server unc in that I was testing.
0
 

Author Comment

by:clynch302
Comment Utility
Also, when I add my computer name it does not error out but it also does not rename the .bkf to .txt.
0
Enabling OSINT in Activity Based Intelligence

Activity based intelligence (ABI) requires access to all available sources of data. Recorded Future allows analysts to observe structured data on the open, deep, and dark web.

 
LVL 65

Expert Comment

by:RobSampson
Comment Utility
Hi, CIM_DataFile won't allow you to enumerate a remote folder.  If you have admin rights, you should set strComputer to the remote computer, then make the path relative to that computer.

strComputer = "server"
Set objWMIService = GetObject("winmgmts:" _
    & "{impersonationLevel=impersonate}!\\" & strComputer & "\root\cimv2")
Set FileList = objWMIService.ExecQuery _
    ("ASSOCIATORS OF {Win32_Directory.Name='D:\itdept\adbackup'} Where " _
        & "ResultClass = CIM_DataFile")

Open in new window


Regards,

Rob.
0
 

Author Comment

by:clynch302
Comment Utility
Ya, no dice.n I am still getting the same error. Basically all I need to do is rename bkf to txt and then delete the the oldest files. In my script the delete portion works just not the extension rename.
0
 
LVL 65

Accepted Solution

by:
RobSampson earned 500 total points
Comment Utility
OK, try it by deleting the target file (if it exists), and then using Move instead.  Also, this doesn't use the CIM_DataFile query, so it might be a bit quicker.

Make sure you test in on a test set of files first.

Regards,

Rob.
Dim objFSO, startFolder, OlderThanDate
Set objFSO = CreateObject("Scripting.FileSystemObject")
startFolder = "\\server\itdept\adbackup"
OlderThanDate = DateAdd("d", -2, Date) ' 2 days 
DeleteOldFiles startFolder, OlderThanDate 

RenameFiles startFolder

Sub DeleteOldFiles(folderName, BeforeDate) 
	For Each file In objFSO.GetFolder(folderName).Files
		If file.DateLastModified < BeforeDate Then
			fso.DeleteFile(file.Path), True
		End If 
	Next 
	For Each subFolder In objFSO.GetFolder(folderName).SubFolders
		DeleteOldFiles subFolder.Path, BeforeDate 
	Next 
End Sub

Sub RenameFiles(folderName)
	For Each objFile In objFSO.GetFolder(startFolder).Files
		If objFile.Extension = "bkf" Then
			strNewName = objFile.Path & ".txt"
			If objFSO.FileExists(strNewName) = True Then objFSO.DeleteFile strNewName, True
			objFSO.MoveFile objFile.Path, strNewName
		End If
	Next
	For Each subFolder In objFSO.GetFolder(folderName).SubFolders
		RenameFiles subFolder.Path
	Next 
End Sub

Open in new window

0
 

Author Closing Comment

by:clynch302
Comment Utility
Thank you for taking the time to assist me.
0
 
LVL 65

Expert Comment

by:RobSampson
Comment Utility
No problem. Thanks for the grade.

Regards,

Rob.
0

Featured Post

Free Trending Threat Insights Every Day

Enhance your security with threat intelligence from the web. Get trending threat insights on hackers, exploits, and suspicious IP addresses delivered to your inbox with our free Cyber Daily.

Join & Write a Comment

Displaying an arrayList in a listView using the default adapter is rarely the best solution. To get full control of your display data, and to be able to refresh it after editing, requires the use of a custom adapter.
If you’re thinking to yourself “That description sounds a lot like two people doing the work that one could accomplish,” you’re not alone.
Viewers will learn how to properly install Eclipse with the necessary JDK, and will take a look at an introductory Java program. Download Eclipse installation zip file: Extract files from zip file: Download and install JDK 8: Open Eclipse and …
In this fifth video of the Xpdf series, we discuss and demonstrate the PDFdetach utility, which is able to list and, more importantly, extract attachments that are embedded in PDF files. It does this via a command line interface, making it suitable …

762 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

10 Experts available now in Live!

Get 1:1 Help Now