VBS issue

I have VBS that I mashed together that is supposed to look in a folder and take .bkf extensions and change them to .txt. Then it is supposed to delete older files.

It gives me an error on line 9.

Can someone help me on this??

Thanks
Dim fso, startFolder, OlderThanDate

strComputer = "."
Set objWMIService = GetObject("winmgmts:" _
    & "{impersonationLevel=impersonate}!\\" & strComputer & "\root\cimv2")
Set FileList = objWMIService.ExecQuery _
    ("ASSOCIATORS OF {Win32_Directory.Name='\\server\itdept\adbackup'} Where " _
        & "ResultClass = CIM_DataFile")
For Each objFile In FileList
    If objFile.Extension = "bkf" Then
        strNewName = objFile.Drive & objFile.Path & _
            objFile.FileName & "." & "txt"
            errResult = objFile.Rename(strNewName)
        Wscript.Echo errResult
    End If
Next


 Set fso = CreateObject("Scripting.FileSystemObject")
 startFolder = "\\server\itdept\adbackup"
 OlderThanDate = DateAdd("d", -2, Date) ' 2 days 
 DeleteOldFiles startFolder, OlderThanDate 
 
  
 Function DeleteOldFiles(folderName, BeforeDate) 
 Dim folder, file, fileCollection, folderCollection, subFolder 
 Set folder = fso.GetFolder(folderName) 
 Set fileCollection = folder.Files 
 For Each file In fileCollection 
 	If file.DateLastModified < BeforeDate Then 
 		fso.DeleteFile(file.Path) 
 	End If 
 Next 
 Set folderCollection = folder.SubFolders 
 For Each subFolder In folderCollection 
 	DeleteOldFiles subFolder.Path, BeforeDate 
 Next 
 End Function

Open in new window

clynch302Asked:
Who is Participating?
 
RobSampsonCommented:
OK, try it by deleting the target file (if it exists), and then using Move instead.  Also, this doesn't use the CIM_DataFile query, so it might be a bit quicker.

Make sure you test in on a test set of files first.

Regards,

Rob.
Dim objFSO, startFolder, OlderThanDate
Set objFSO = CreateObject("Scripting.FileSystemObject")
startFolder = "\\server\itdept\adbackup"
OlderThanDate = DateAdd("d", -2, Date) ' 2 days 
DeleteOldFiles startFolder, OlderThanDate 

RenameFiles startFolder

Sub DeleteOldFiles(folderName, BeforeDate) 
	For Each file In objFSO.GetFolder(folderName).Files
		If file.DateLastModified < BeforeDate Then
			fso.DeleteFile(file.Path), True
		End If 
	Next 
	For Each subFolder In objFSO.GetFolder(folderName).SubFolders
		DeleteOldFiles subFolder.Path, BeforeDate 
	Next 
End Sub

Sub RenameFiles(folderName)
	For Each objFile In objFSO.GetFolder(startFolder).Files
		If objFile.Extension = "bkf" Then
			strNewName = objFile.Path & ".txt"
			If objFSO.FileExists(strNewName) = True Then objFSO.DeleteFile strNewName, True
			objFSO.MoveFile objFile.Path, strNewName
		End If
	Next
	For Each subFolder In objFSO.GetFolder(folderName).SubFolders
		RenameFiles subFolder.Path
	Next 
End Sub

Open in new window

0
 
sammySeltzerCommented:
I don't think it likes computer name being define as "."

strComputer = "."

Are you using this for more than one computer or are you planning on passing computer name as param?

Trying sticking actual computer name there and see what happens.

Also, do you have a different file name other than bkf on that folder?
0
 
Bill PrewCommented:
What error are you getting?

~bp
0
Cloud Class® Course: MCSA MCSE Windows Server 2012

This course teaches how to install and configure Windows Server 2012 R2.  It is the first step on your path to becoming a Microsoft Certified Solutions Expert (MCSE).

 
sammySeltzerCommented:
The error says (null) with some error code. That's what I got when I attempted to test it to see if I could figure out what could be wrong.

I wanted to clarify that defining your computer as strComputer="." doesn't mean there is something wrong with that declaration.

I would try using this to diagnose vmi to see if something is amiss with it.

http://windowsxp.mvps.org/repairwmi.htm

0
 
clynch302Author Commented:
This is used on my computer only.  I have a folder that files are copied to that are .bkf. I need them to be .txt. So this is basically all ran from 1 system. I have a server unc in that I was testing.
0
 
clynch302Author Commented:
Also, when I add my computer name it does not error out but it also does not rename the .bkf to .txt.
0
 
RobSampsonCommented:
Hi, CIM_DataFile won't allow you to enumerate a remote folder.  If you have admin rights, you should set strComputer to the remote computer, then make the path relative to that computer.

strComputer = "server"
Set objWMIService = GetObject("winmgmts:" _
    & "{impersonationLevel=impersonate}!\\" & strComputer & "\root\cimv2")
Set FileList = objWMIService.ExecQuery _
    ("ASSOCIATORS OF {Win32_Directory.Name='D:\itdept\adbackup'} Where " _
        & "ResultClass = CIM_DataFile")

Open in new window


Regards,

Rob.
0
 
clynch302Author Commented:
Ya, no dice.n I am still getting the same error. Basically all I need to do is rename bkf to txt and then delete the the oldest files. In my script the delete portion works just not the extension rename.
0
 
clynch302Author Commented:
Thank you for taking the time to assist me.
0
 
RobSampsonCommented:
No problem. Thanks for the grade.

Regards,

Rob.
0
Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.

All Courses

From novice to tech pro — start learning today.