Solved

Styling HTML Table output from MySQL Query Results

Posted on 2011-09-23
2
303 Views
Last Modified: 2012-05-12
I am attempting to create a report that will output the transactions for all clients in my database. I'm having a hard time getting the layout right, though. I need a space between the last row of the data table and the next client table header row.

I haven't started styling this yet, so please be kind - it's terribly ugly. If you have any suggestions on that front, please include them!

Here's what I have now:
Report Table
And here's my code:
<?php
include('config.php');
$account = ''; // Declare Account to Empty

$sql = "SELECT * from client, billing WHERE client.id = billing.client ORDER BY client.id DESC";
$result = mysql_query($sql) or die(mysql_error());

// Keeps getting the next row until there are no more to get
while($row = mysql_fetch_array($result)){
   if ($row['account'] != $account) { // check if new account
        $account = $row['account'];
        if ($cnt > 0) echo '</tr>'; // check if open table row
        $cnt = 0; // set $cnt to zero and echo table row for new account
        echo "<table border='1' width='800px' align='center'><th>Client ID</th><th>First Name</th><th>Last Name</th><th>Case Style</th><th>Accident Date</th><th>SOL Expires</th>";
        echo "<tr><td>";
        echo $row['account'];
        echo "</td><td>";
        echo $row['fname'];
        echo "</td><td>";
        echo $row['lname'];
        echo "</td><td>";
        echo $row['casestyle'];
        echo "</td><td>";
        echo $row['accidentdate'];
        echo "</td><td>";
        echo $row['solexpires'];
        echo "</td></tr></table>";
        echo "<br /><table border='1' width='800px' align='center'>";
        echo "<tr><th>Date</th><th>Client ID</th><th>Transaction Type</th><th>Charge</th><th>Billed From</th><th>Payment</th></tr>";
        }
        if ($cnt == 0) echo '<tr>';
        // Print out the contents of each row into a table
        echo "<td>";
        echo $row['date'];
        echo "</td><td>";
        echo $row['account'];
        echo "</td><td>";
        echo $row['job_type'];
        echo "</td><td>";
        echo $row['charge'];
        echo "</td><td>";
        echo $row['job_type'];
        echo "</td><td>";
        echo $row['payment'];
        echo "</td></tr>";
        $cnt++;
}

echo "</table>";
?>

Open in new window


Thanks in advance for your help.
0
Comment
Question by:goodie069
[X]
Welcome to Experts Exchange

Add your voice to the tech community where 5M+ people just like you are talking about what matters.

  • Help others & share knowledge
  • Earn cash & points
  • Learn & ask questions
2 Comments
 
LVL 3

Accepted Solution

by:
nrbreen earned 500 total points
ID: 36590520

You appear to be missing the /table after each data section

Change

        if ($cnt > 0) echo '</tr>'; // check if open table row

Open in new window


To

        if ($cnt > 0)  { echo '</tr></table><br />'; } // check if open table row

Open in new window

0
 

Author Comment

by:goodie069
ID: 36590577
Ugh, I knew it was something glaringly obvious. Thank you!!
0

Featured Post

Online Training Solution

Drastically shorten your training time with WalkMe's advanced online training solution that Guides your trainees to action. Forget about retraining and skyrocket knowledge retention rates.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Many old projects have bad code, but the budget doesn't exist to rewrite the codebase. You can update this code to be safer by introducing contemporary input validation, sanitation, and safer database queries.
This article discusses how to implement server side field validation and display customized error messages to the client.
This video teaches users how to migrate an existing Wordpress website to a new domain.
The viewer will learn how to dynamically set the form action using jQuery.

695 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question