Solved

SQL Case statement problem

Posted on 2011-09-28
3
234 Views
Last Modified: 2012-05-12
I have this :

UPDATE Nop_ProductVariant
SET Price = OldPrice + 2.00 + (
CASE
WHEN OldPrice              < 5 THEN 5.00 - (OldPrice - ProductCost)
WHEN OldPrice BETWEEN 5 AND 10 THEN 8.00 - (OldPrice - ProductCost)
WHEN OldPrice BETWEEN 10 AND 50 THEN 12.00 - (OldPrice - ProductCost)
END

But need to add another condition :

CASE
WHEN OldPrice              < 5 THEN 5.00 - (OldPrice - ProductCost)

NEED THIS INSTEAD :
If (OldPrice - ProductCost) < 5.00
      THEN 5.00 - (OldPrice - ProductCost)
       ELSE OldPrice                                    


WHEN OldPrice BETWEEN 5 AND 10 THEN 8.00 - (OldPrice - ProductCost)

NEED THIS INSTEAD :
If (OldPrice - ProductCost) < 8.00
      THEN 8.00 - (OldPrice - ProductCost)
       ELSE OldPrice    
                               

WHEN OldPrice BETWEEN 10 AND 50 THEN 12.00 - (OldPrice - ProductCost)

NEED THIS INSTEAD :
If (OldPrice - ProductCost) < 12.00
      THEN 12.00 - (OldPrice - ProductCost)
       ELSE OldPrice                                    

END

Can I still use the Case statement to do this? thanks

0
Comment
Question by:MikeMCSD
  • 2
3 Comments
 
LVL 14

Expert Comment

by:Christopher Gordon
ID: 36718590
You can nest Case Statements.  Not 100% sure if I followed your logic, but here is an example.
declare @myCosts table (Id int identity(1,1), myPrice money, myOldPrice money, myCalculatedPrice money)

insert into @myCosts values (6.00, 5.00, null)
insert into @myCosts values (10.00, 12.00, null)
insert into @myCosts values (45.00, 40.00, null)
insert into @myCosts values (2.00, 3.00, null)
insert into @myCosts values (24.00, 21.00, null)

update @myCosts

	set myCalculatedPrice = 	
	
	case 
		--if Old Price < 5
		when myOldPrice < 5 then 
			
			case 
				--the variance of "my old price" and "price" < 5 so subtract the variance from 5
				when (myOldPrice - myPrice) < 5 then (5 - (myOldPrice - myPrice)) 
				
				--the variance of "my old price" and "price" >- 5 so return myOldPrice
				else myOldPrice 
			end
		
		when myOldPrice < 10 then 
		
			case 
				--the variance of "my old price" and "price" < 5 so subtract the variance from 5
				when (myOldPrice - myPrice) < 8 then (8 - (myOldPrice - myPrice)) 
				
				--the variance of "my old price" and "price" >- 5 so return myOldPrice
				else myOldPrice 
			end
		
		
		when myOldPrice < 50 then 
		
		case 
				--the variance of "my old price" and "price" < 5 so subtract the variance from 5
				when (myOldPrice - myPrice) < 12 then (12 - (myOldPrice - myPrice)) 
				
				--the variance of "my old price" and "price" >- 5 so return myOldPrice
				else myOldPrice 
			end
		
	end																 

from @myCosts

select *
from	@myCosts

Open in new window

0
 
LVL 16

Author Comment

by:MikeMCSD
ID: 36718745
thanks gohord, ..  good idea about nesting.
I think this will work, I'll test it :

SET Price = OldPrice + 2.00 + (
CASE

WHEN OldPrice              < 5 THEN
      CASE
            WHEN (OldPrice - ProductCost) < 5.00  THEN 5.00 - (OldPrice - ProductCost)             
            ELSE OldPrice
      END

WHEN OldPrice BETWEEN 5 AND 10 THEN
      CASE
            WHEN (OldPrice - ProductCost) < 8.00  THEN 8.00 - (OldPrice - ProductCost)             
            ELSE OldPrice
      END

WHEN OldPrice BETWEEN 10 AND 50 THEN
      CASE
            WHEN (OldPrice - ProductCost) < 12.00  THEN 12.00 - (OldPrice - ProductCost)             
            ELSE OldPrice
      END

END
0
 
LVL 14

Accepted Solution

by:
Christopher Gordon earned 500 total points
ID: 36718808
Just a heads up, a case statement will automatically exit when it reaches a condition that is TRUE.

Because of this, the BETWEEN syntax isn't necessary.   You'll notice in my sample that I didn't use BETWEEN.

I guess it just boils down to what is easier for you (or the next programmer) to understand.  I honestly couldn't tell you if there was a best practice on which way to go.



0

Featured Post

Efficient way to get backups off site to Azure

This user guide provides instructions on how to deploy and configure both a StoneFly Scale Out NAS Enterprise Cloud Drive virtual machine and Veeam Cloud Connect in the Microsoft Azure Cloud.

Question has a verified solution.

If you are experiencing a similar issue, please ask a related question

Suggested Solutions

Title # Comments Views Activity
SQL Error in WHERE Clause 5 39
SQL Server - Slabs 9 36
Error running stored procedure 11 15
C# guarantee sql connection close 6 13
In this article we will get to know that how can we recover deleted data if it happens accidently. We really can recover deleted rows if we know the time when data is deleted by using the transaction log.
Load balancing is the method of dividing the total amount of work performed by one computer between two or more computers. Its aim is to get more work done in the same amount of time, ensuring that all the users get served faster.
Via a live example, show how to set up a backup for SQL Server using a Maintenance Plan and how to schedule the job into SQL Server Agent.
Via a live example, show how to shrink a transaction log file down to a reasonable size.

911 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

20 Experts available now in Live!

Get 1:1 Help Now