Link to home
Start Free TrialLog in
Avatar of jason bradway
jason bradway

asked on

Need assistance passing a date between two fields

I have an ADP with a 2008 SQL database and experiencing problems with the following code trying to pass the Admission Date from one table to populate another.  It is correct in mm/dd/yyyy format in my source table and when it is passed it shows at 12:00:00 AM.  The source field is formatted as DateTime in SQL and the form that I am pulling it from shows it correctly.  I have even gone as far as formatting the text box as shortdate to see if that would remedy the situation.  I have attempted a Convert Function with the same results.  Suggestions?
strSQL = " INSERT INTO MedHistoryPhysicalAdmission ( FAMILY, AdmissionDate )"
    strSQL = strSQL & " SELECT Convert(int," & [Forms]![MedicalHistoryPhysicalAdmissionLookupForm]![Family] & "), "
    strSQL = strSQL & "" & [Forms]![MedicalHistoryPhysicalAdmissionLookupForm]![AdmissionDate] & ";"

    DoCmd.RunSQL (strSQL)

Open in new window

Avatar of BrandonGalderisi
BrandonGalderisi
Flag of United States of America image

The datetime data type will have a time of 0 (12:00am) if one is not provided.  If you want to truly track only the date, consider using a DATE data type.
Avatar of jason bradway
jason bradway

ASKER

I originally had the destination field as datatype DATE and ran into difficulties with the statement failing with a data type mismatch.  It would only accept data with a datatype of DATETIME.
Avatar of Olaf Doschke
the canonical format for strings containing datetimes, which are autoconverted to  a datetime field in MS SQL Server is not mm/dd/yyyy but 'yyyymmdd hh:mm:ss'.

I know too little Access VB(A) to tell you what to use to convert your form control value, but now you know the right format it should be easy to accomplish via Year(), Month()  etc. or similar VB functions giving you the date parts.

Bye, Olaf.
Try this ...

Format([Forms]![MedicalHistoryPhysicalAdmissionLookupForm]![AdmissionDate] , "yyyy-mm-dd hh:nn:ss")


ET
Nope, it will not accept Format as a valid function.  Sounded good though.
Try this ...

DatePart("yyyy", [Forms]![MedicalHistoryPhysicalAdmissionLookupForm]![AdmissionDate]) & "-" & DatePart("m", [Forms]![MedicalHistoryPhysicalAdmissionLookupForm]![AdmissionDate]) & "-" & DatePart("d", [Forms]![MedicalHistoryPhysicalAdmissionLookupForm]![AdmissionDate])

ET
I've seen this before between Access & SQL Server ...

If the previous post does not work ... try this ...


CONVERT(VARCHAR(8), [Forms]![MedicalHistoryPhysicalAdmissionLookupForm]![AdmissionDate], 112)


ET
Is there a reason you are converting the datetime value to an int?

IE - " SELECT Convert(int," & [Forms]![MedicalHistoryPhysicalAdmissionLookupForm]![Family] & "), "

Try ET's suggestion here instead of the current line, so replace the above with

" SELECT Convert(varchar(8)," & [Forms]![MedicalHistoryPhysicalAdmissionLookupForm]![Family] & ", 112), "
You must use the date delimiters of SQL Server:

strSQL = strSQL & "'" & [Forms]![MedicalHistoryPhysicalAdmissionLookupForm]![AdmissionDate] & "';"

/gustav
Also .... for Date & Time, try this ...

CONVERT(VARCHAR(19), [Forms]![MedicalHistoryPhysicalAdmissionLookupForm]![AdmissionDate], 120)

Plus ... as mentioned by cactus data ... you will need to enclose the date in single quotes ... "'"


ET
ASKER CERTIFIED SOLUTION
Avatar of Olaf Doschke
Olaf Doschke
Flag of Germany image

Link to home
membership
This solution is only available to members.
To access this solution, you must be a member of Experts Exchange.
Start Free Trial
> If we're talking Access ..

We are, Olaf, but it is an ADP => syntax of SQL Server

/gustav
Yes, but the code creating the sql query is Access, isn't it? SQL Server does not use & fro string concatenation, but VB does. Note that I put the Format() function outside of the string, it generates the correct data literal.

Bye, Olaf.
You are right. It would work.

/gustav
@JasBrad

As you already tried the Format() function, the question is how. Of course SQL Server does not know it, but Access (VB) does. And it depends on the  [Forms]![MedicalHistoryPhysicalAdmissionLookupForm]![AdmissionDate], being a Date/Time value and not a string, so it depends how you have created your Access Form and it's AdmissionDate field.

Independant of your form and SQL Server locale settings this will work:

strSQL = " INSERT INTO MedHistoryPhysicalAdmission ( FAMILY, AdmissionDate )"
strSQL = strSQL & " SELECT 1, '20110929' "

DoCmd.RunSQL (strSQL) 

Open in new window


SQL Server does some automatic type conversions, mostly starting from a string literal, eg you can specify a uniquidentifier as a string and you can use the 'yyyymmdd' format for dates, but not without the single quotes. 20110929 would be interpreted as a number of course. '20110929' can also be the string, but if you select this into a datetime or daet field, SQL Server does convert it.

Open SQL Server Management Studio and click the "New Query" Toolbar button.
Then write: Select 29/09/2011
execute that.
It results in 0, because SQL Server doesn't interpret this as a date, but as a mathematical expression.

Select 1.0 * 09/29/2011
yields the more precise result 0.00015432322

See? 9 divided by 29 divided by 2011.

What you can do in general is test what SQL Server Management Studio says about your queries, simply copy the content of strSQL into the windows cliptext and paste it into a new query window to execute it there.

Execute this in SSMS:

select '20110929'

declare @date as DateTime
set @date = '20110929'
select @date

The first Select will result in the string, SQL Server does not convert, if there is no reason to do so.
The second Select results in the datetime value, as the variable set is of that type.

Bye, Olaf.

Olaf,
The problem I am running up against is that the function Format is not recognized or at least that is the error message I am getting when I attempt to put your code in.  This is what I have to use with the quotes to make it work and then get the error message.  Normally I would pass a parameter to a Stored Procedure to make it work but Access it blocking the value from being passed for some reason, so I am doing everything in VBA.
strSQL = " INSERT INTO MedHistoryPhysicalAdmission ( FAMILY, AdmissionDate )"
    strSQL = strSQL & " SELECT Convert(int," & [Forms]![MedicalHistoryPhysicalAdmissionLookupForm]![Family] & "), "
    strSQL = strSQL & "format(" & [Forms]![MedicalHistoryPhysicalAdmissionLookupForm]![AdmissionDate] & ", 'yyyymmdd');"

    DoCmd.RunSQL (strSQL)

Open in new window

Sorry Olaf, I wasnt reading your code properly and putting in too many quotes.  I now realize what I was doing wrong.  Thank you so very much.
JasBrad ... I answered your question yesterday as shown below ....

>>>>>Try this ...

Format([Forms]![MedicalHistoryPhysicalAdmissionLookupForm]![AdmissionDate] , "yyyy-mm-dd hh:nn:ss")


ET>>>>>


You said ....

Nope, it will not accept Format as a valid function.  Sounded good though.