VB SQL Connection

In my attached code...

Do my  Dispose() lines belong properly where they are or after the "Finally"?

Do I need to dispose of the SqlDataAdaptor?
Dim da As SqlDataAdapter = New SqlDataAdapter(sqlCmd)
        Dim ds As DataSet = New DataSet
        Dim dt As DataTable = New DataTable

        Try
            sqlConn.Open()
            da.Fill(ds)
            For Each dt In ds.Tables
                dt.TableName = dt.Rows(0)("TableName").ToString()
            Next
            If ds.Tables.Count > 0 Then
                InjectScript.Text = ""
            Else
                InjectScript.Text = "No data returned on this deal"
            End If
        Catch ex As Exception
            InjectScript.Text = ex.ToString
        Finally
            sqlCmd.Dispose()
            sqlConn.Dispose()
        End Try

Open in new window

Larry Bristersr. DeveloperAsked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Kiran SonawaneProject LeadCommented:
They are at correct place. Finally block is always executed even though there is exception in try block. Its good practice to dispose object whenever you are done with that object
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
Larry Bristersr. DeveloperAuthor Commented:
SHould I dispose of the data adaptor as well?
0
Kiran SonawaneProject LeadCommented:
Yes. Dispose method of SqlDataAdapter is available because it uses important system resources.
0
Get expert help—faster!

Need expert help—fast? Use the Help Bell for personalized assistance getting answers to your important questions.

Éric MoreauSenior .Net ConsultantCommented:
0
Larry Bristersr. DeveloperAuthor Commented:
emoreau:
Since we're building an entire application on the fly...it's important that we catch exceptions which we're emailing to ourselves.

Does using catch exceptions?
0
Éric MoreauSenior .Net ConsultantCommented:
0
Larry Bristersr. DeveloperAuthor Commented:
Perfect.  Thanks folks
0
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
.NET Programming

From novice to tech pro — start learning today.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.