Best practice for writing XSLT

Is this the best way of writing this statement?

I want it to check to see if more images exist in the XML, if so display a 'more images' button.

<xsl:if test="Photos/Photo">
	<xsl:for-each select="Photos/Photo">		
		<a class='gallery' href='{Link}' title="{Description}">
		  <xsl:if test="position() = 1">
				<xsl:element name="img">
					<xsl:attribute name="src">
						<xsl:value-of select="$img_more" />
					</xsl:attribute>
				</xsl:element>
		  </xsl:if>
		</a>
	</xsl:for-each>
</xsl:if>

Open in new window

d1114170Asked:
Who is Participating?
I wear a lot of hats...

"The solutions and answers provided on Experts Exchange have been extremely helpful to me over the last few years. I wear a lot of hats - Developer, Database Administrator, Help Desk, etc., so I know a lot of things but not a lot about one thing. Experts Exchange gives me answers from people who do know a lot about one thing, in a easy to use platform." -Todd S.

Geert BormansInformation ArchitectCommented:
you can remove this
<xsl:if test="Photos/Photo">

the for-each will do nothing if there are no Photos/Photo nodes
0
sybeCommented:
<xsl:if test="count(Photos/Photo) &gt; 0 ">
0

Experts Exchange Solution brought to you by

Your issues matter to us.

Facing a tech roadblock? Get the help and guidance you need from experienced professionals who care. Ask your question anytime, anywhere, with no hassle.

Start your 7-day free trial
It's more than this solution.Get answers and train to solve all your tech problems - anytime, anywhere.Try it for free Edge Out The Competitionfor your dream job with proven skills and certifications.Get started today Stand Outas the employee with proven skills.Start learning today for free Move Your Career Forwardwith certification training in the latest technologies.Start your trial today
XML

From novice to tech pro — start learning today.

Question has a verified solution.

Are you are experiencing a similar issue? Get a personalized answer when you ask a related question.

Have a better answer? Share it in a comment.