Solved

Java simple method error

Posted on 2012-03-09
12
332 Views
Last Modified: 2012-03-09
Why does this cause an error?

I'm getting "Incompatible operand types int[] and int" on line 6

public static int whichShip(int[][] array, int row, int col){
	 //find which ship got hit (find coordinate in compBoard array, and return the index)
		int i = 0;
		for (i = 0; i < array.length; i++){
		 for (int j = 0; j < array[i].length; j++){
			 if (array[i] == row && array[i][j] == col){
				 return i;
			 		}
			 }
		}
	}

Open in new window

0
Comment
Question by:Kyle Hamilton
  • 9
  • 3
12 Comments
 
LVL 47

Expert Comment

by:for_yan
Comment Utility
array[i] is one-dimensional array
beaciues array is two dimensional array

Open in new window

0
 
LVL 47

Expert Comment

by:for_yan
Comment Utility
you provbable meant somethimng like that - cpomparing int's

 if (i == row && j == col)
0
 
LVL 47

Expert Comment

by:for_yan
Comment Utility
I guesss this is how it should be
public static int whichShip(int[][] array, int row, int col){
	 //find which ship got hit (find coordinate in compBoard array, and return the index)
		int i = 0;
		for (i = 0; i < array.length; i++){
		 for (int j = 0; j < array[i].length; j++){
			 if (i== row && j == col){
				 return arry[i][j];
			 		}
			 }
		}
	}
                                  

Open in new window

0
 
LVL 47

Expert Comment

by:for_yan
Comment Utility
still does not make much sense , why jsust not to return

array[row][col]  ?
0
 
LVL 47

Accepted Solution

by:
for_yan earned 500 total points
Comment Utility
one thing is clear - you cannot write this:
array[i] == row

Open in new window

beacuse array[i] is one-dimensional int array int[]

Open in new window


and row is just int

so no comparison beteenn them can be made - this is a compiler error - rethink what you wanted to express
0
 
LVL 25

Author Comment

by:Kyle Hamilton
Comment Utility
I'm just staring to learn Java, so please pardon my ignorance...

I want to find the row where my coordinates (row, col) reside...

I changed my code to this, which is no longer causing an error (though I'm not sure that this is what I'm getting at yet...)

public static int whichShip(int[][] array, int row, int col){
	 //find which ship got hit (find coordinate in compBoard array, and return the index)
		int result = 0;
		for (int i = 0; i < array.length; i++){
			for (int j = 0; j < array[i].length; j++){
				if (i == row && array[i][j] == col){
					result = i;
				}
			 }
		}
		return result;
	}

Open in new window

0
How to improve team productivity

Quip adds documents, spreadsheets, and tasklists to your Slack experience
- Elevate ideas to Quip docs
- Share Quip docs in Slack
- Get notified of changes to your docs
- Available on iOS/Android/Desktop/Web
- Online/Offline

 
LVL 47

Expert Comment

by:for_yan
Comment Utility
>I want to find the row where my coordinates (row, col) reside...

Sorry I am not sure I undersatnd

you have two-dimensional array of int
this array for any two coordinates - row and column will return one value - which sits in the cell with this row and this column so for row = 2 and col = 1 it can return one value
which will be the value stored ion the element array[2][1] -and that may be any int value stored in that element
to solve this task you don't need to go through array just arry[row][col] wioll give you the result.

if you wnat to resolve the opposite question, Say I have int value 12 - which cell of my grid represented by array[row][col] is this value sitting?
is this waht you want?
0
 
LVL 47

Expert Comment

by:for_yan
Comment Utility
if you want the answer to the last question - then you cannot have method which returns one int value which could give answer to that last question.
because the answer for this question contains not one int number , but two int numbers - you need to return from this method both row and col
0
 
LVL 47

Expert Comment

by:for_yan
Comment Utility
in order to return the coordinates of the array element which has a specified value you need to define a new class , say class Coordinates which will have two fields - int row and int col and you can have a method which will return the instance of such class

for example

class Coordinates {
int row;
int col;
public Coordinates(int row, int col){
this.row = row;
this.col = col;
}

public int getRow() { return row; }

public int getColumn() { return col; }


}


once you define such method which will return instance of class Cooordinates
corresponding to the location in our array where the value has certain number
for example let's find coordinates of the eleemt whose value is 12:

then you may have something like below:

int value = 12;
Coordinates coords = getCoords(array, value);
System.out.println(coords.getRow() + " ," + coords.getColumn());

public Coordinates getCoords(int [][] array, int value){

for(int j=0;j<array.length; j++){
for(int i=0; i<array[j].length; i++){
if(array[j][i] == value){
Coordinates coords = new Coordinates(j, i);
return coords;

}

}
}
return null;
}







}

Open in new window

0
 
LVL 47

Expert Comment

by:for_yan
Comment Utility
This is a reall example how this would compile and work
(see output below)

public class Miscellaneous {

    static int[][] array = new int[][]{{1,2,3},{4,5,6} };


    public static  Coordinates getCoords(int [][] array, int value){

for(int j=0;j<array.length; j++){
for(int i=0; i<array[j].length; i++){
if(array[j][i] == value){
Coordinates coords = new Coordinates(j, i);
return coords;

}

}
}
return null;
}

    public static void main(String[] args) {

     int value = 6;
Coordinates coords = getCoords(array, value);
System.out.println(coords.getRow() + " , " + coords.getColumn());


    }
}

class Coordinates {
int row;
int col;
public Coordinates(int row, int col){
this.row = row;
this.col = col;
}

public int getRow() { return row; }

public int getColumn() { return col; }


}

Open in new window


Output:
1 , 2

Open in new window


indeed in the array we initialized in the beginning of the class
array[1][2] = 6
0
 
LVL 25

Author Comment

by:Kyle Hamilton
Comment Utility
Hi for_yan,

I completely screwed up what I was trying to achieve. And hence, it made no sense :)

I have since figured it out, but it's totally dependent on other stuff in the program and the method I wrote in the end has little to do with my original code:

public static int whichShip(int[][] array, int row, int col){
	 //find which ship got hit (find coordinate in compBoard array, and return the index)
		int result = 0;
		for (int i = 0; i < array.length; i++){
			for (int j = 0; j < array[i].length; j++){
				
				if(array[i][j] == (row * 10) + col){
					result = i;
					break;
				}
				
			 }
		}
		return result;
	}

Open in new window


I want to give you credit for steering me away from what I was doing... thus I will accept one of your answers even though I didn't actually use it.

Thank you so much.....
0
 
LVL 25

Author Closing Comment

by:Kyle Hamilton
Comment Utility
Thank you so much... I need all the help I can get!
0

Featured Post

What Should I Do With This Threat Intelligence?

Are you wondering if you actually need threat intelligence? The answer is yes. We explain the basics for creating useful threat intelligence.

Join & Write a Comment

Suggested Solutions

Introduction This article is the first of three articles that explain why and how the Experts Exchange QA Team does test automation for our web site. This article explains our test automation goals. Then rationale is given for the tools we use to a…
This article discusses four methods for overlaying images in a container on a web page
In this tutorial viewers will learn how to position overlapping items using z-index in CSS. They will also learn the restrictions on the z-index property.  Create a new HTML document with an internal stylesheet.: Create a div in CSS and name it Red.…
In this tutorial viewers will learn how to customize the background color and font color of highlighted text using the ::selection element in CSS Begin by defining the selected text as an element in CSS by typing "::selection": Style the ::selection…

728 members asked questions and received personalized solutions in the past 7 days.

Join the community of 500,000 technology professionals and ask your questions.

Join & Ask a Question

Need Help in Real-Time?

Connect with top rated Experts

10 Experts available now in Live!

Get 1:1 Help Now